Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: [PATCH 2/2] tty: serial: fsl_lpuart: improve lpuart32 registers clearing when shutdown
Date:   Wed,  9 Nov 2022 18:45:15 +0800
Message-Id: <20221109104515.17266-3-sherry.sun@nxp.com>
In-Reply-To: <20221109104515.17266-1-sherry.sun@nxp.com>
References: <20221109104515.17266-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5iJq7dLIgpCj2OuFoQ3CJltJO7Z3zE0cRlTinwguGqSjenU58EnB7nrR/2dM?=
 =?us-ascii?Q?wv/Zo8KXwa6n4ZAm9jb6pJ1ESCa9QWhMpxKikiInRYCcjrxW2g9n6S0YxiKN?=
 =?us-ascii?Q?ANUF08+65kDmqKrSEsHfcR/WAv2VyJ3ZVwInynQZZgxwkQYwC0HOmH598PGH?=
 =?us-ascii?Q?OqxNNFHjK3Cb1/59b8AuzOK4+T1VfFeY8+YJ+KRFP2G1YNuKciFwm8xQ5T6C?=
 =?us-ascii?Q?zeTtqClnTE4iSDpuZoKvzKlrT9C9zZQX9pLyzp5qSLbZ1402NMn81oCW19pt?=
 =?us-ascii?Q?UTtTyAwju3E7DmqdoxiSsiwTHFmI9TvanFJbWpnx/dAkPnHbGPP9NjunN6a4?=
 =?us-ascii?Q?nG2rgW4gTDn+a/m9TAORaeeyC3peVtnRm67Kkg/9RGmjD4QJVIYtVinaz1u9?=
 =?us-ascii?Q?bi13IUxZvvcmE4Y09jXyVylRurdHFP9zQnsLnKu5Fyaqyu/32SB/yJY7qTtn?=
 =?us-ascii?Q?hVgMRcmHnyMF8fM4igy6t2kBruIUqWml6wn8D1kFC047zWgMEMKvIfcjQiot?=
 =?us-ascii?Q?kYtoU8cqQK5/F7Z8XHtINHzekpAYKqx92fgzOnqwX0olDD3aecsgDI4pD5JA?=
 =?us-ascii?Q?KG9vuht5UcSWXILnG6Q8fdOXSpz+xPPOhfD/sYJeI35R6eAk5S6pQKa4zyDd?=
 =?us-ascii?Q?ga3VDrsVcUdWqgT+wty5S8MBOjOtKQ8FZK6PZfrgyoLY0XX4MVgBP10Ynwx/?=
 =?us-ascii?Q?dU1R2krgxUMqRUAZXjSC1QkMRChjpTfGibDybDbcqqu5MqMYPBSAEXjWg1mz?=
 =?us-ascii?Q?RTj7PtFR7bDPosoaenepgpaTzfbqFTP1921bWrmbd9vm8zM8nud1NMhcBp22?=
 =?us-ascii?Q?eLUjyS+/JOAOI7aTJqYDPFgkDi9i3BOWReB4cBEN4QCkuN0BeboLgk7cRlJH?=
 =?us-ascii?Q?SWn4gIyDbHeHaiQZpfP+h3zu9YvJRkg+vzoIasvPALIzmE02188ViDCbDzCE?=
 =?us-ascii?Q?mADLcFBwFPUrgqv7uyJNCaE6lfjhgZsYP7spQZJGiq4B3Ld6WoX5/1stQARQ?=
 =?us-ascii?Q?Ct/LXkjfPu48TPCYiabfyhDIsKRXCAa7QFyPBmaQqKj06dzJIqdwS58I1mzL?=
 =?us-ascii?Q?WiFnN2Sds6VoGq/s509CVWJflaPQOWHHGGDMD9V9t+4SQBFqBSrsZ3ELEB7V?=
 =?us-ascii?Q?fAJ89krQUWiH04T94etMucHwnvtzYMWGFVviHaWhySbIoPMmcp0ISZ0PU8sz?=
 =?us-ascii?Q?NSNBG/WxQyKuizQMKqL1RDvWFOlZ4kgEu3zhRthZwW/UVzOa3gSmGuhoQ70f?=
 =?us-ascii?Q?bDkIeVqw7lgx045YqVC3snrNvC5n5cHcqqdD03dLeaPxnznBPQQV7kxgKJdP?=
 =?us-ascii?Q?eymK3YUpt2FbjFU65PF182x5H9DU8MgQcWJjW31ZdhA2yFko4c8heBGXx+2z?=
 =?us-ascii?Q?qBz0Wx5tcCvBxvCc1YHekq+pY/p8vTzWWPGpS1A52JKzomIjs0roUWpV8fkn?=
 =?us-ascii?Q?fXLug7pr06YYcVN1KvfkVdiBZjvDpD8YuzyhBRMIAEZtPFxMZrfoJgBuVoTT?=
 =?us-ascii?Q?vHbE6zZQjIp3iE2wfnb41cRAZHUeRM3le8Rqeuc0WY03LKRJzLhUgWcOUffJ?=
 =?us-ascii?Q?h7ZQxQDTqGZeOK44BUcO6NPiBhrcGA4bjjI0SCjC?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ed131cf-7e55-4c40-e517-08dac23fbfe9
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 10:47:08.8132
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d7RICl7Mmt9+1p/H4OUEAujuQjcO8zEQIxobtzsgwiVkMLpq8oXcKzE8B1bXrjevgZ4zq9PnjOwBbIXlM1tc9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8406
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Need to clear the UARTSTAT and UARTMODIR registers when shutdown the
uart port, also clear the Rx/Tx DMA enable bits and loopback
configuration bit.

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 drivers/tty/serial/fsl_lpuart.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index f5a0a14fa366..43d9d6a6e94a 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1771,11 +1771,22 @@ static void lpuart32_shutdown(struct uart_port *port)
 
 	spin_lock_irqsave(&port->lock, flags);
 
+	/* clear statue */
+	temp = lpuart32_read(&sport->port, UARTSTAT);
+	lpuart32_write(&sport->port, temp, UARTSTAT);
+
+	/* disable Rx/Tx DMA */
+	temp = lpuart32_read(port, UARTBAUD);
+	temp &= ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
+	lpuart32_write(port, temp, UARTBAUD);
+
 	/* disable Rx/Tx and interrupts */
 	temp = lpuart32_read(port, UARTCTRL);
 	temp &= ~(UARTCTRL_TE | UARTCTRL_RE | UARTCTRL_ILIE |
-			UARTCTRL_TIE | UARTCTRL_TCIE | UARTCTRL_RIE);
+			UARTCTRL_TIE | UARTCTRL_TCIE | UARTCTRL_RIE |
+			UARTCTRL_LOOPS);
 	lpuart32_write(port, temp, UARTCTRL);
+	lpuart32_write(port, 0, UARTMODIR);
 
 	spin_unlock_irqrestore(&port->lock, flags);
 
-- 
2.17.1