Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: [PATCH 2/2] tty: serial: fsl_lpuart: Add runtime pm support
Date:   Wed,  9 Nov 2022 18:56:59 +0800
Message-Id: <20221109105659.17381-3-sherry.sun@nxp.com>
In-Reply-To: <20221109105659.17381-1-sherry.sun@nxp.com>
References: <20221109105659.17381-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?i5P802hhpmtrHxL6oITDZgr1ogiE4rrh8JFV5PFmBRTx3kr0cK4Hhxng5J0r?=
 =?us-ascii?Q?N0T0J7i+/ZvwyOVAcBezOPluAERpQRc5569E6YKi/D5gh55kdWm9pI0YqwYb?=
 =?us-ascii?Q?0mHiw2YoyPmGLaERqGUrOWLxuLBIfHbg1xOF04FEVBgbpkY6YzomuzM5CejB?=
 =?us-ascii?Q?WEj/fXnbBEhjxz3BdeThDGRb4rbp5j8QQaY1UeECPCt/NiRNV2G5sISVOp+/?=
 =?us-ascii?Q?KSGFL7wO/Uy4dC/APjAYpu7m4xP/wzELYOJdsWVZn3f+z9/ekjvmUH+BrN8j?=
 =?us-ascii?Q?f6Ec63VfuT4oUVCksqDPxWxOG2sjITUEOC3hSelLhSyn7GVXyE8Yzg17E1A3?=
 =?us-ascii?Q?3AzjuIX3x3Dszp6XsIfXs9ZezHQ8jmoOH9XPjmHcRyHbpTIynURW6OH01L8W?=
 =?us-ascii?Q?lxa4SOj01dlMRHBrRGEL7DqbujTFQZYSLrt6/6Ed/lmZXSFjWe9n/YMfIb12?=
 =?us-ascii?Q?JxlRUZLCkQ72iTVQNncQiix6s9nMG3li+LAQ/dbb53CsJssFdO+QClQYojRO?=
 =?us-ascii?Q?f85ApAIdQZRRjHldJrTd+Y7fHF+dpx71c/J6k2pNPVHZjJ9v/MHOLp5fVdOe?=
 =?us-ascii?Q?Z6pukFH9O/onQKlV+SN4U3Uvfg5Qx/9a7D/zYT5pDX5HymHV3W1w9GLEt0wS?=
 =?us-ascii?Q?dpqiMjqZ4brYDe2zNSyPGxPD9t2BnLJ8cPrAMukzlXwIyNshkEgyhJ70t+bg?=
 =?us-ascii?Q?1uPKalIs7H2Tpe3/E2QEX4+qWa5LBc+V+YkhlqWoQxWLKSOxg9lIn5Hlxhv8?=
 =?us-ascii?Q?IsRsEnVBmBzmEbW5zxT+tTwgEozAYa4sEtLjduRBYFRAD2rgIW+2tkvnDG6X?=
 =?us-ascii?Q?s6w78ymJzNXb1X5jzKTn076a5krHw3XXy/Wv7wTsAMajjRDlcQOrecbexbTQ?=
 =?us-ascii?Q?Rgu6/F0f7Vj1kX+mDpXKggIH1StRxJNmTuAnNWu4dySoCVHY4QzjFWkp1PJy?=
 =?us-ascii?Q?y7T/iuTa+dbOf0gGwpb4hgdThg8ti0URFySVSgbFrWcMDHalcpD6yNfnmXaF?=
 =?us-ascii?Q?YlhE2f4FL+d5RwTlEpP9lfJhjVYoIHItMO2E+7byTnqaiScFEgCaEf0kg0mt?=
 =?us-ascii?Q?44RuSa9L2sE3JDHZFH9gyySduYDKs/ICbPVOtxn6VWlZGJxXMLCmA79QrJ2Y?=
 =?us-ascii?Q?j8u4H1a7Kgf90wKjaD+LWxIrkAr4w2VQ66gJFTPgUUnalYBd76+n/WpLS9/M?=
 =?us-ascii?Q?d+NO78qA7MZ85fGqmIrWSexlI9bvU9WanjkPGhKGEuWZgxy9ddonF9XpCNwJ?=
 =?us-ascii?Q?XDhcKuVGkyFGXsqgxvoyMEeQZ/jJGmIM4UC13k8kP7aK6FDWJCcXZiBEvB/a?=
 =?us-ascii?Q?4HrDi98BFhJS0XU5PyXnIRmjfbG7wz9n1hvGcM3aCOM2gN/3oCsFLlJaIhdF?=
 =?us-ascii?Q?kRJgwbRkBZzT1u7WeU/RCw21Pve2uBxrZCDFnWsxWFSVRoU3xccKWJl5y/a1?=
 =?us-ascii?Q?Gb0kD5sFFhUR+5uTjET1XFNpHeX2nkLXEwl/pZNdp9cJowy8Nj8aBJxXF1YT?=
 =?us-ascii?Q?fFG3nmBri+Ip+5548B9eIpxHjz2cUcWLIuORP/U38cTAwDvAdSMI1OCNfs5c?=
 =?us-ascii?Q?+dyE7+48FKArXKz/6msKPf0pFjx8eCV6dbIS1ZTY?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2b64579-2ea2-4092-c54a-08dac2416cb0
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 10:59:08.0720
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cCRtx/uO/1ZD7zjzAzX0lyLav2fW2mzeAJOWCX1PtpvGCvDEDxMUvij2uaDcOymYxL7pnpXAcm9/deUjZaHuZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8515
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Add runtime pm support to manage the lpuart clock.

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 drivers/tty/serial/fsl_lpuart.c | 60 +++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 474943cb06b2..e678a7aaf7e4 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -19,6 +19,7 @@
 #include <linux/of_device.h>
 #include <linux/of_dma.h>
 #include <linux/pinctrl/consumer.h>
+#include <linux/pm_runtime.h>
 #include <linux/serial_core.h>
 #include <linux/slab.h>
 #include <linux/tty_flip.h>
@@ -235,6 +236,7 @@
 
 /* Rx DMA timeout in ms, which is used to calculate Rx ring buffer size */
 #define DMA_RX_TIMEOUT		(10)
+#define UART_AUTOSUSPEND_TIMEOUT	3000
 
 #define DRIVER_NAME	"fsl-lpuart"
 #define DEV_NAME	"ttyLP"
@@ -795,6 +797,20 @@ static void lpuart32_start_tx(struct uart_port *port)
 	}
 }
 
+static void
+lpuart_uart_pm(struct uart_port *port, unsigned int state, unsigned int oldstate)
+{
+	switch (state) {
+	case UART_PM_STATE_OFF:
+		pm_runtime_mark_last_busy(port->dev);
+		pm_runtime_put_autosuspend(port->dev);
+		break;
+	default:
+		pm_runtime_get_sync(port->dev);
+		break;
+	}
+}
+
 /* return TIOCSER_TEMT when transmitter is not busy */
 static unsigned int lpuart_tx_empty(struct uart_port *port)
 {
@@ -2243,6 +2259,7 @@ static const struct uart_ops lpuart_pops = {
 	.startup	= lpuart_startup,
 	.shutdown	= lpuart_shutdown,
 	.set_termios	= lpuart_set_termios,
+	.pm		= lpuart_uart_pm,
 	.type		= lpuart_type,
 	.request_port	= lpuart_request_port,
 	.release_port	= lpuart_release_port,
@@ -2267,6 +2284,7 @@ static const struct uart_ops lpuart32_pops = {
 	.startup	= lpuart32_startup,
 	.shutdown	= lpuart32_shutdown,
 	.set_termios	= lpuart32_set_termios,
+	.pm		= lpuart_uart_pm,
 	.type		= lpuart_type,
 	.request_port	= lpuart_request_port,
 	.release_port	= lpuart_release_port,
@@ -2747,6 +2765,11 @@ static int lpuart_probe(struct platform_device *pdev)
 		handler = lpuart_int;
 	}
 
+	pm_runtime_use_autosuspend(&pdev->dev);
+	pm_runtime_set_autosuspend_delay(&pdev->dev, UART_AUTOSUSPEND_TIMEOUT);
+	pm_runtime_set_active(&pdev->dev);
+	pm_runtime_enable(&pdev->dev);
+
 	ret = lpuart_global_reset(sport);
 	if (ret)
 		goto failed_reset;
@@ -2771,6 +2794,9 @@ static int lpuart_probe(struct platform_device *pdev)
 failed_attach_port:
 failed_get_rs485:
 failed_reset:
+	pm_runtime_disable(&pdev->dev);
+	pm_runtime_set_suspended(&pdev->dev);
+	pm_runtime_dont_use_autosuspend(&pdev->dev);
 	lpuart_disable_clks(sport);
 	return ret;
 }
@@ -2789,9 +2815,30 @@ static int lpuart_remove(struct platform_device *pdev)
 	if (sport->dma_rx_chan)
 		dma_release_channel(sport->dma_rx_chan);
 
+	pm_runtime_disable(&pdev->dev);
+	pm_runtime_set_suspended(&pdev->dev);
+	pm_runtime_dont_use_autosuspend(&pdev->dev);
 	return 0;
 }
 
+static int __maybe_unused lpuart_runtime_suspend(struct device *dev)
+{
+	struct platform_device *pdev = to_platform_device(dev);
+	struct lpuart_port *sport = platform_get_drvdata(pdev);
+
+	lpuart_disable_clks(sport);
+
+	return 0;
+};
+
+static int __maybe_unused lpuart_runtime_resume(struct device *dev)
+{
+	struct platform_device *pdev = to_platform_device(dev);
+	struct lpuart_port *sport = platform_get_drvdata(pdev);
+
+	return lpuart_enable_clks(sport);
+};
+
 static void serial_lpuart_enable_wakeup(struct lpuart_port *sport, bool on)
 {
 	unsigned int val, baud;
@@ -2937,6 +2984,10 @@ static int __maybe_unused lpuart_suspend(struct device *dev)
 			sport->dma_tx_in_progress = false;
 			dmaengine_terminate_all(sport->dma_tx_chan);
 		}
+	} else if (pm_runtime_active(sport->port.dev)) {
+		lpuart_disable_clks(sport);
+		pm_runtime_disable(sport->port.dev);
+		pm_runtime_set_suspended(sport->port.dev);
 	}
 
 	return 0;
@@ -2971,12 +3022,19 @@ static void lpuart_console_fixup(struct lpuart_port *sport)
 static int __maybe_unused lpuart_resume(struct device *dev)
 {
 	struct lpuart_port *sport = dev_get_drvdata(dev);
+	int ret;
 
 	if (lpuart_uport_is_active(sport)) {
 		if (lpuart_is_32(sport))
 			lpuart32_hw_setup(sport);
 		else
 			lpuart_hw_setup(sport);
+	} else if (pm_runtime_active(sport->port.dev)) {
+		ret = lpuart_enable_clks(sport);
+		if (ret)
+			return ret;
+		pm_runtime_set_active(sport->port.dev);
+		pm_runtime_enable(sport->port.dev);
 	}
 
 	lpuart_console_fixup(sport);
@@ -2986,6 +3044,8 @@ static int __maybe_unused lpuart_resume(struct device *dev)
 }
 
 static const struct dev_pm_ops lpuart_pm_ops = {
+	SET_RUNTIME_PM_OPS(lpuart_runtime_suspend,
+			   lpuart_runtime_resume, NULL)
 	SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(lpuart_suspend_noirq,
 				      lpuart_resume_noirq)
 	SET_SYSTEM_SLEEP_PM_OPS(lpuart_suspend, lpuart_resume)
-- 
2.17.1