Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Nov 2022 13:33:55 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Joey Gouly <joey.gouly@arm.com>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Lennart Poettering <lennart@poettering.net>,
        Zbigniew =?utf-8?Q?J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Kees Cook <keescook@chromium.org>,
        Szabolcs Nagy <szabolcs.nagy@arm.com>,
        Jeremy Linton <jeremy.linton@arm.com>,
        Topi Miettinen <toiwoton@gmail.com>, linux-mm@kvack.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-abi-devel@lists.sourceforge.net, nd@arm.com, shuah@kernel.org
Subject: Re: [PATCH v1 2/2] kselftest: vm: add tests for
 memory-deny-write-execute
Message-ID: <Y2usQ6HjvwDEisCY@sirena.org.uk>
References: <20221026150457.36957-1-joey.gouly@arm.com>
 <20221026150457.36957-3-joey.gouly@arm.com>
 <Y1wLVsg8VN26xI7j@sirena.org.uk>
 <20221108173303.GA53007@e124191.cambridge.arm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="PkmQYXH0bfQF8a57"
Content-Disposition: inline
In-Reply-To: <20221108173303.GA53007@e124191.cambridge.arm.com>
Precedence: bulk


--PkmQYXH0bfQF8a57
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Nov 08, 2022 at 05:33:03PM +0000, Joey Gouly wrote:
> On Fri, Oct 28, 2022 at 06:03:18PM +0100, Mark Brown wrote:
> > On Wed, Oct 26, 2022 at 04:04:57PM +0100, Joey Gouly wrote:

> > > +#ifdef __aarch64__
> > > +#define PROT_BTI      0x10            /* BTI guarded page */
> > > +#endif

> > We should get this from the kernel headers shouldn't we?  We generally
> > rely on things getting pulled in from there rather than locally
> > defining.

> I believe the mman.h included is from the toolchain, not the kernel's uapi headers.
> The toolchain I was using didn't have PROT_BTI defined in its mman.h

I'd expect that whatever we're doing in the build process ought to be
overriding the default headers provided by the toolchain, that's kind of
the point here...

--PkmQYXH0bfQF8a57
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmNrrEIACgkQJNaLcl1U
h9Dd2Qf+JstBgiUB9xskBNs/qV0yCbAwDcm1yxj1hcr7EBTB6UpqUs0dFMDc7viS
tGVkyALj5WpqjA7o5D8zc+LMhA5cYPNZwNwuXm0DBcHp51LrlC9REsBLihDvOLDh
S+wOnXfoajkP5Ujt2yRcwPufZ7tQ5z/SZJcy9LhffgLy/fC9cYiYviLakrw1P3Ua
6nm3muwCUaXteqgQHzduoJe7DXTOmROICv1r6yHSIwLHMIELEFAA89rHgIwpGqH/
UvqiB/v35R63DufGRHFedDk01tG5ZGe7wm7P9+1jlDVSECMJGI4l2MZyfn/iEekW
+FVctvLpNpeb4nlV98EwvIx+OtnM+Q==
=hO+N
-----END PGP SIGNATURE-----

--PkmQYXH0bfQF8a57--