Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp600190rwb; Wed, 9 Nov 2022 06:35:52 -0800 (PST) X-Google-Smtp-Source: AMsMyM4SQUriLFgP4P/xnJw34Vxdf8YSiCIJE8JnuS6LVwT6E1ZNFZOvhSpxSRWB4ArcUJ4CcjOE X-Received: by 2002:a63:e153:0:b0:439:2fa3:74d1 with SMTP id h19-20020a63e153000000b004392fa374d1mr51708616pgk.85.1668004552429; Wed, 09 Nov 2022 06:35:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668004552; cv=none; d=google.com; s=arc-20160816; b=ae1ys2MVydLpXXWwIAP51Pz5IrH23r/5FKN4FiSnm/oKjDYgCYjHmZjL39tfe71AMj ypCXkJj+rVEKLiCl3CWv+SpvRVfoBHlYoyItoyeGsYBnBa1hJGosN8Lf2/Gl/BpRFPIU TJJfmShaWRrp5LW1GBA9ymDQwFH0u9qcZ3P0gxk2JtpaMDZVsLvyBsAhZUk/tLJa7uON kyV4fuA+ymvquUa+hSH2N8sSkPAvd/ejFztdiCvuQMDAXevJKePHiPfLHodAW+WUzkMs VBiaNnBGvvlLNf3ti+HBwO1jv7PHONKrlN42CzWq6HSLbfZTMVeGV4XWCn/XhlpzUy/M JaHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kmb1PgdM1vKbHe+pvE1TUg+WAWhRGtaq0V4EptGhabg=; b=DxMg58HCNjDHRilIhV1oUL4yeiQT6DdmVowZGZzNPYbJ27hUx9krdLlU7X0vLzkWxU iuCSWoWjOXIJQxwB8sbo4tEMaQd5Tr1PhblDoe+mZYMiidmyZmwNmED/wAdu6PbvIJhH Tvkk5jNOMF19rmNSJFuw4/aQOLu9uQoZ4+PJMlgd2L5M8V3YZ6HIqvDH1oQvbczrv/LW w60DlcxoMEU4AHjQEQaWB48MxHrTIGSQelyWnf0hCmp0HTeoSl0x4Hp051r//AWaPoPL ZVZk/Ke5MIAQkZ8aDGg/5AhpUYxs8cnb0Yx7jNX1wNyJQ6USpBWqqpwcUCy8jRfEaz/B BzNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mt9IqnLe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c5-20020a634e05000000b0045fcb8a8ae7si18952340pgb.231.2022.11.09.06.35.40; Wed, 09 Nov 2022 06:35:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mt9IqnLe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231127AbiKIOS1 (ORCPT + 93 others); Wed, 9 Nov 2022 09:18:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230519AbiKIOSY (ORCPT ); Wed, 9 Nov 2022 09:18:24 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64AC5186C3 for ; Wed, 9 Nov 2022 06:18:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0E9ACB81EF2 for ; Wed, 9 Nov 2022 14:18:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22E1DC433C1; Wed, 9 Nov 2022 14:18:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1668003498; bh=GlHtbsXNpec5UMsRv71sb8jBMCuQn8cZcypfmUe0w0g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mt9IqnLeCTQZrOpxt/UkzKTMGOPLF7UIfhpglwTA+qXhza8T8h+t9vC1n5IjSmPdc 8llXXdBXcgvaSKGqnKiffeJyy1kh23tSHmhNpod9kPNQQVzKVAqp+kXJQGy1ddOQu+ FHe0ZOSNshtlY08m5zTRrs1z/nQziBx8nxEbO3iE= Date: Wed, 9 Nov 2022 15:18:14 +0100 From: Greg KH To: Osama Muhammad Cc: linux-kernel@vger.kernel.org, Samuel Thibault Subject: Re: [PATCH] Accessiblity: speakup_bns: specifying the default driver parameters among the module params Message-ID: References: <20221022185600.3989-1-osmtendev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221022185600.3989-1-osmtendev@gmail.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 22, 2022 at 11:56:00PM +0500, Osama Muhammad wrote: > This is an enhancement which allows to specify the default driver > parameters among the module parameters. > > Adding a default variables to the speakup_bns module > allows to easily set that at boot, rather than > setting the sys variables after boot. > More details can be found here: > https://github.com/linux-speakup/speakup/issues/7 > > Signed-off-by: Osama Muhammad > > Reviewed-by: Samuel Thibault Please do not put a blank line between these here. And is this a v2 patch? I have a bunch of patches from you, but I can't tell which ones is the latest ones, and which to drop. Can you send these all as a patch series so that I know the order in which to apply them, and to be sure that I have the latest versions? I'll drop all of your pending patches from my review queue now. thanks, greg k-h