Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <TYCP286MB232348AC39E6F4966FA9494BCA3D9@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
 <Y2uu5Q7mLzS0w9VR@kroah.com>
In-Reply-To: <Y2uu5Q7mLzS0w9VR@kroah.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 9 Nov 2022 16:36:13 +0200
Message-ID: <CAHp75VdUrjjFqR-AzRs+fB4ruFqhES7k7Qommu7c=E5F8Oa80g@mail.gmail.com>
Subject: Re: [RFC PATCH] acpi: make remove callback of acpi driver void
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Dawei Li <set_pte_at@outlook.com>, rafael@kernel.org,
        u.kleine-koenig@pengutronix.de, dvhart@infradead.org,
        andy@infradead.org, lenb@kernel.org, arnd@arndb.de,
        peterhuewe@gmx.de, kys@microsoft.com, kronos.it@gmail.com,
        dmitry.torokhov@gmail.com, bleung@chromium.org,
        sujith.thomas@intel.com, vithampi@vmware.com, lee@kernel.org,
        wim@linux-watchdog.org, jgross@suse.com, davem@davemloft.net,
        linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Nov 9, 2022 at 3:45 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Nov 06, 2022 at 10:57:53PM +0800, Dawei Li wrote:
> > For bus-based driver, device removal is implemented as:
> > 1 device_remove()->
> > 2   bus->remove()->
> > 3     driver->remove()
> >
> > Driver core needs _no_ inform from callee(bus driver) about the
> > result of remove callback. In that case,
> > commit <fc7a6209d571> ("bus: Make remove callback return void")

Also please read Submitting Patches on how to provide a commit
reference in the message body.

> > forces struct bus_type::remove() be void-returned.
> >
> > Now we have the situation that both 1 & 2 of calling chain are
> > void-returned, so it does _not_ make much sense for 3(driver->remove)
> > to return non-void to its caller.
> >
> > So the basic idea behind this change is making remove() callback of
> > any bus-based driver to be void-returned.
> >
> > This change itself, is for device drivers based on acpi-bus.


-- 
With Best Regards,
Andy Shevchenko