Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp778738rwb; Wed, 9 Nov 2022 08:30:49 -0800 (PST) X-Google-Smtp-Source: AMsMyM7YJDvDp8pEhQ6OFw5gzsk+qD7sME9aEgwVO1dfLS564XHHE0gw7XZzxMjafVMEtH8b2eKy X-Received: by 2002:a63:1e47:0:b0:43c:261f:f773 with SMTP id p7-20020a631e47000000b0043c261ff773mr53079678pgm.1.1668011449338; Wed, 09 Nov 2022 08:30:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668011449; cv=none; d=google.com; s=arc-20160816; b=OnG+mcPza849ejMPFy/23uCZwJNgGwSqxvR/rBI8Nc6iVd+rxSX8aoEG4MMcu/gWLb DeLQdDLteVDiuieJAUx6MUZ7hQ9p7TpbAa4MDA6lzM2vOLSuepHyisJwLZu3wNfp6kU/ i0jlZ9sbRDZ0D4TJBU41f+fDaRPrBwGyrGVNCWTeCiMLyBlsuVO5YiQeug+lgLmp0Nyz TtvWXFbO0+pR5EwYzyLd1/3bWPSafAT/w7Q8gVJKahQXiX87BUHpmwNkxrdgVmul7VHJ ngS8uyPfLcCXuDGO0gvSN5FW4kLpLSPCrj4oJKZ992T0mmdxF7jtYUoeX2KXCQJHs+Jz dQuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sk2rRztWdJEYKEIMTq5A+Go4tOahbOq/6iV58v2FweA=; b=Aa2YcBlExJq9TYH+lFSA6/Z9lwIxPWyHwWf6y5TmAFaTwZ+KAHs0sVEQDN6pI7h3UX fPDKTk3Xx3b0ew6Qjugs3xkzwS7TAbF7WS5uwwYwRLGFKc8qeKz31lA0DFcOrFf7++6x Z0u9M0FLtpf44FBk/seg24rzshtCGNgR5+AL1F8al75K3jSV+Fk6uo3r5QCw0da9J+0t ldSY9lCL/zPbtrmc/9llBqrKY1j2ZJUb/tNGXWaJKAODLMK/Xov21WJ1N0XrVvcTj/vz U009O9ogmYRfWipay2jgp8sqo7/gmputqcEvoGsqop3GvIxh8xU+sFKbAEguLlN9UPDS LLmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=T+N+TL4R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v190-20020a6389c7000000b00460c55062f0si16533718pgd.434.2022.11.09.08.30.36; Wed, 09 Nov 2022 08:30:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=T+N+TL4R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229733AbiKIPxr (ORCPT + 92 others); Wed, 9 Nov 2022 10:53:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229714AbiKIPxq (ORCPT ); Wed, 9 Nov 2022 10:53:46 -0500 Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E886E0A for ; Wed, 9 Nov 2022 07:53:40 -0800 (PST) Received: by mail-qv1-xf36.google.com with SMTP id ml12so12573196qvb.0 for ; Wed, 09 Nov 2022 07:53:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sk2rRztWdJEYKEIMTq5A+Go4tOahbOq/6iV58v2FweA=; b=T+N+TL4RWsLhyuBSFtNrfgXKzUzVxDn6urT2Vlc2kkdGVPRzCfvFzEeWrIm6V+dlHt KOFeR0bRP75lWMjIKUVbMohw+OImYxCZ3Y4DMrPzPU76FwhFQoClQUiZZ4/wi8l6yGz6 OvMy0I7n2Z/PMVyzqILHLM+e4IcFnlPG3XwchiOoxD4V15joIbbCZSIlQTxkTdcABKzI 8+r/KJfbjuCK1q4mpLEZyXeph+FPyVJztyiczmZBcI7OU1AqqhKEKvG6rw5LFFNBZj1g 7SA2+SBFTCSsPqayJZkcSTyBPg2wdxLtwlrSCdLQxfI/zElX3iKwww5481ZtCVEQEU1/ xiOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sk2rRztWdJEYKEIMTq5A+Go4tOahbOq/6iV58v2FweA=; b=aQ44DbPCj+tDdnCqVxzv1muRGoslZw69uYOEMoXO3HWa/jkLTXNJDA74cvyB6CFesy Iss5hlK0wKUKpRlD9aeWGn0AYsS4tYZ5+SzAB6dQcEysX8/SsqrP58/lwcz/IIvrzbsK gpBEZ/Au6PJ22tBqCl2pFQgs+7/Wv917qcJloHeEv43xpEz9hxaxhntH0NmjqdcMg6ZR /b/UdTojToMbAPNa1nRaCkVNhrfvlvuv0IgMsQgRC3pfHgDY2GE7R1pGbMTI6TfAo+Jg m5vuHssFxfR0dBP7YB++EhpF4hA42RbQyJS0+8uYNnR/oDPY6Fk2+QTcxVRLdLjLaS3N Ywpw== X-Gm-Message-State: ACrzQf1w8A3uLCm0FjmHEQiCBLXlG6nmQVH511tqFbyVMt69lQfvU4Yk BgHzFwjePmkC+WNhfrPr2K02/w== X-Received: by 2002:a05:6214:da7:b0:4bb:d8a2:cc2f with SMTP id h7-20020a0562140da700b004bbd8a2cc2fmr52846832qvh.119.1668009189021; Wed, 09 Nov 2022 07:53:09 -0800 (PST) Received: from localhost (2603-7000-0c01-2716-3663-3884-f85a-44bb.res6.spectrum.com. [2603:7000:c01:2716:3663:3884:f85a:44bb]) by smtp.gmail.com with ESMTPSA id u127-20020a379285000000b006faeecef56fsm5629435qkd.68.2022.11.09.07.53.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 07:53:08 -0800 (PST) Date: Wed, 9 Nov 2022 10:53:12 -0500 From: Johannes Weiner To: Linus Torvalds Cc: Hugh Dickins , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nadav Amit , Will Deacon , Aneesh Kumar , Nick Piggin , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Peter Zijlstra , Gerald Schaefer Subject: Re: [PATCH 4/4] mm: delay page_remove_rmap() until after the TLB has been flushed Message-ID: References: <20221108194139.57604-4-torvalds@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221108194139.57604-4-torvalds@linux-foundation.org> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All 4 patches look good to me from an MM and cgroup point of view. And with the pte still locked over rmap, we can continue with the removal of the cgroup-specific locking and rely on native MM synchronization, which is great as well. Thanks, Johannes