Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <482c6af5-0b55-0e9d-0b1f-d22b9546f062@amd.com>
Date:   Wed, 9 Nov 2022 20:58:50 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v1 1/1] pinctrl: Put space between type and data in
 compound literal
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Linus Walleij <linus.walleij@linaro.org>
References: <20221109152356.39868-1-andriy.shevchenko@linux.intel.com>
Content-Language: en-US
From:   Basavaraj Natikar <bnatikar@amd.com>
In-Reply-To: <20221109152356.39868-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1RUbHduS3FUZElxMDNPaWNPYkNDbjQreWFmK25JQmZyZVNWWldHYXJrb25q?=
 =?utf-8?B?WlFUdXI5UnFOSjdnSXVkSld4QmVxN3Y1dXhobWVIU1FaZmlibUZ5WmJwTnpQ?=
 =?utf-8?B?L21rTWsvN0pHdU1JVjFDOWd4OVUzeWJZcFd2alJLTmYraXgvelMrVlFjREgr?=
 =?utf-8?B?S3I2NHBobDBoNHNsU3J6Q0xXMmJiSFJVa25hZjhQSHBBcFhZMHk2QTZCeU53?=
 =?utf-8?B?OFN5VURXRkVRTHBZcDVKK2RSay91dE41MmRSUDRZeHlJcGhMQmh0OFpwM1d1?=
 =?utf-8?B?ckxZTEs5ZFpRdHdkQ3ZLMUwwbVlWVlVWWDluQnFhempIcUtqb09VbkhDUW9n?=
 =?utf-8?B?dVljSUNNVDU5UHV0OXNYWHgwS1hjUGNaanNlSEd2OEJ5L2ppTTVoVCszamFy?=
 =?utf-8?B?ZXFSY2RLelpua1hKbk1wZDhQL3hobWRtanAyZVRGeXJBZm5vTmttbzFPa2ox?=
 =?utf-8?B?ZVVYemp1dnQzbjJzK21RZFJ4emtlYzI3MFdGWnVZZlhBd0JWWDlhT1JsSDla?=
 =?utf-8?B?SC93emxmZ2ppSko4ZnAwWjZBYXZndmRoWno1M0U4d0JOcm13NXl4VjBJcFBZ?=
 =?utf-8?B?OGo1ajZEbU9jei81ZzFWTnJBQ1lvSWl5WkRwN3drcytsYmRKdkFSc3V5VVNx?=
 =?utf-8?B?Z0tyV01ieWdqWHlRckVYbW44eUF1RWI5YWl5MGk4TDRDcGRBRHVjMksydTFS?=
 =?utf-8?B?c2FFWVNEbWlGdVNadlRIRVUxSUNibUx1V2RtQkU3QnZGQUt4dk9FY0xaOTBp?=
 =?utf-8?B?cjZmNHpKRWYvTE9HcnJqNFZ3OXNtWVlVdU13V2dCL2lyRmtyZE9Fa0czbUxt?=
 =?utf-8?B?UURwNTlBd1NvaVl6cFQxaDc4RGNRaFZvRXg1ZS9tS2puN1VSeXgrRlVwVlRN?=
 =?utf-8?B?dTBlTk0vUFBmYzdmbUpyN0cyUnBUV2VJYm96Q1pDZnN1dUI1LzFXaXkwSi8w?=
 =?utf-8?B?cGdPa3dZRXc3SnovQkR6OSt6cTZsUnF1dlZ0T01zaXUwRDE3MEhjbW5Xck53?=
 =?utf-8?B?UWVyVFZlZ2UwTUMxYVlMYkdFdlJGRHhlZFI3aTYxVWFqcWZvdk9FeVZpSkdz?=
 =?utf-8?B?dUFpRUUrVGdIbzFIMDB5YmVCSWJEb0JFRUd3RGh5bGRYOUNkdTZKUHFsT3FE?=
 =?utf-8?B?SGhDSlFsVW9xTWpINitpTHdybFhiaFZkWjBMODRvRTFqWGpTVnJkaWFOVXQw?=
 =?utf-8?B?NGVGNHJLTVNvN3lrbWZQZlo2YjZPS2NQOE1EYVphWldjTEhLRkM0VHNwNFN0?=
 =?utf-8?B?R2RKcjMvcnVONGtKUExidXFqUTlESTBocys2d1VOK1V6ZlQwR0dxR3hjVTh1?=
 =?utf-8?B?ZVRadGxmcU4remMvanova3AxQ3YvOHFOKzRkYTJwU0NEbHZZTjlpU2NmYlhM?=
 =?utf-8?B?ZUgyd0diakhrT0hMNVpTTjZiUVJpSGVtekt5UytGckw0RGJWbzhOQ2lzM0NG?=
 =?utf-8?B?aFZSd2oyVGlqYnQ1aENHWVUwRmZaWUZiQlpHU0hNeTZqeVFvNG02UVBjNmJB?=
 =?utf-8?B?cXZIV2VDeVp1L3RGWER2ekdZZSt6bUFIVDA5N1R1SE5iSlFVeE9VL0RqMk5Y?=
 =?utf-8?B?SzFFQ2V0YVBxczNDek03TTJRUmdKVGRGWUR0NHl3WCt0M0RaWGZQWkE3VzV1?=
 =?utf-8?B?YVhJUmhiWWwrY0xxeUE0bS85emtQZ3pFcmxRTy9wZkZ2ZHZXYmdqd2gxZjNV?=
 =?utf-8?B?bUNnM21pT3hsRmo2amtNZUI5NDBNdC9BKzd3M0lpZllScWxhRyt5cGZNZ1Z4?=
 =?utf-8?B?QmFNMkVJdnJiTUZvaGJkcllLUWIyVGI2dWx1V1NqMkk4Rk5FQkV6UVJyQmNL?=
 =?utf-8?B?d2dRTGJxOThRYzRKYkVEc0pNUzJIM3JITUwybmJ2K1pIcHRCVlBrSlNoZ3dW?=
 =?utf-8?B?bE5vS21wUWl6TEIxR28xQmhHTTQzWkpaSWcvaDRXWDhzV2RmZmR5YWIvY2lw?=
 =?utf-8?B?cGFXK1ZmTnltbFo2dlVDU1FVTGNHNHVEcmRPNEV4Z1NTU1lXeTdSUnVld2FE?=
 =?utf-8?B?THFNWFQyZ1ExY1lRVTRXRkVSK0lSNkowWGwrVzVTTCs2akg2MmltemZHVjRB?=
 =?utf-8?B?alk4SDhLSkNHcjNzUG1LWmRxa010cThVQmdTaGhHaTNJaTg1OElGeG50SzV1?=
 =?utf-8?Q?McFobSM30CLOqsP/W/fJVriE3?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35ac3343-61b4-4f73-d752-08dac267208d
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5040.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 15:29:02.4474
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Yj3WyO35/BwsrL1Apomn209+ztx+Yen6dpqg1vkzxRcFa8wimjFudKc6cuqb0LjXsn4B5cGzALhtLHYNMksK7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6345
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/9/2022 8:53 PM, Andy Shevchenko wrote:
> It's slightly better to read when compound literal data and type
> are separated by a space.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> It also standard practice in the kernel:
>
> $ git grep -l '(struct [^()]\+) {' | wc -l
> 1384
>
> $ git grep -l '(struct [^()]\+){' | wc -l
> 306
>
>  include/linux/pinctrl/pinctrl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h
> index 487117ccb1bc..f6ff2590657d 100644
> --- a/include/linux/pinctrl/pinctrl.h
> +++ b/include/linux/pinctrl/pinctrl.h
> @@ -40,7 +40,7 @@ struct pingroup {
>  
>  /* Convenience macro to define a single named or anonymous pingroup */
>  #define PINCTRL_PINGROUP(_name, _pins, _npins)	\
> -(struct pingroup){				\
> +(struct pingroup) {				\
>  	.name = _name,				\
>  	.pins = _pins,				\
>  	.npins = _npins,			\

Looks good to me

Reviewed-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>

Thanks,
--
Basavaraj