Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6cab73d3-4d56-8069-f0f1-d47346c7bd15@linux.intel.com>
Date:   Wed, 9 Nov 2022 07:37:30 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.2
Subject: Re: [PATCH v17 2/3] virt: Add TDX guest driver
Content-Language: en-US
From:   Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@linux.intel.com>
To:     Wander Lairson Costa <wander@redhat.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        Shuah Khan <shuah@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Kai Huang <kai.huang@intel.com>,
        Isaku Yamahata <isaku.yamahata@gmail.com>,
        marcelo.cerri@canonical.com, tim.gardner@canonical.com,
        khalid.elmously@canonical.com, philip.cox@canonical.com,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-doc@vger.kernel.org
References: <20221104032355.227814-1-sathyanarayanan.kuppuswamy@linux.intel.com>
 <20221104032355.227814-3-sathyanarayanan.kuppuswamy@linux.intel.com>
 <20221109142431.ffkhouuxewjajp6g@fedora>
 <ccbbb331-80c5-75bf-cd5d-82748ad63a60@linux.intel.com>
In-Reply-To: <ccbbb331-80c5-75bf-cd5d-82748ad63a60@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/9/22 7:36 AM, Sathyanarayanan Kuppuswamy wrote:
> TDG.MR.TDCALL expects reportdata and tdreport buffers to be size aligned. So,
> allocating them together with sizeof(struct tdx report req) will not work. We
> can get around this by allocating a slightly larger buffer size. However, because
> it is not a time-critical path, I believe that allocating two separate buffers
> for input/output is simpler.

I mean't TDG.MR.REPORT TDCALL.

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer