Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221109160904.183147-1-mpfj@newflow.co.uk> <20221109160904.183147-4-mpfj@newflow.co.uk>
 <2af9a47e-acc4-d2f1-8fc9-281385d18d51@linaro.org>
In-Reply-To: <2af9a47e-acc4-d2f1-8fc9-281385d18d51@linaro.org>
From:   Mark Jackson <mpfj@newflow.co.uk>
Date:   Wed, 9 Nov 2022 16:45:08 +0000
Message-ID: <CAAbcLfjR7JZ_W+JoAJ02_4eiVQPZj--=C1-uLjPvRGQYC1dNGw@mail.gmail.com>
Subject: Re: [PATCH 3/5] ARM: dts: nanobone: Enable I2C temperature sensor
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     =?UTF-8?Q?Beno=C3=AEt_Cousson?= <bcousson@baylibre.com>,
        Tony Lindgren <tony@atomide.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 9 Nov 2022 at 16:23, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 09/11/2022 17:09, Mark Jackson wrote:
> > The NanoBone platform supports a temperature sensor on the I2C bus.
> >
> > Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
> > ---
> >  arch/arm/boot/dts/am335x-nano.dts | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/am335x-nano.dts b/arch/arm/boot/dts/am335x-nano.dts
> > index cecc2afaeff4..2be831927af6 100644
> > --- a/arch/arm/boot/dts/am335x-nano.dts
> > +++ b/arch/arm/boot/dts/am335x-nano.dts
> > @@ -212,6 +212,11 @@ &uart5 {
> >       status = "okay";
> >  };
> >
> > +temperature-sensor@48 {
> > +     compatible = "lm75";
> > +     reg = <0x48>;
> > +};
>
> This should not work - you put the node in some random place.

Ah yes, that should be within the I2C block.
I'll fix that.

Cheers
Mark J.