Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Elliott, Robert (Servers)" <elliott@hpe.com>
To:     Zhen Lei <thunder.leizhen@huawei.com>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Frederic Weisbecker <frederic@kernel.org>,
        "Neeraj Upadhyay" <quic_neeraju@quicinc.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v6 1/2] rcu: Add RCU stall diagnosis information
Thread-Topic: [PATCH v6 1/2] rcu: Add RCU stall diagnosis information
Thread-Index: AQHY9B8WepNC0ic5WUOW0S7L17lcwq42zGXg
Date:   Wed, 9 Nov 2022 16:55:45 +0000
Message-ID: <MW5PR84MB18423CA291ABCD3DCCE3D416AB3E9@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <20221109093739.187-1-thunder.leizhen@huawei.com>
 <20221109093739.187-2-thunder.leizhen@huawei.com>
In-Reply-To: <20221109093739.187-2-thunder.leizhen@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?09Hb/4SrmG3ep3VeqwGcrKO5iB3Uorhi2CJimf0GmnPTjXOdPERYA2+bcCqD?=
 =?us-ascii?Q?2yKp8DAQaWYRze1jsPTIXWBYNWHGA9QJflmBWN2xoXBSvza0Su0KrRih2ugk?=
 =?us-ascii?Q?8w/gTfHqzpVIVTO01E+Gir5yrEc27TdozPW6IVdhoyRt8bHub9PKY1M9Y5WH?=
 =?us-ascii?Q?rVEHbQw4pb9XpDBrd8LXyLePChl9qyXtcGaoi2Bh1AUq4P9hj3ypDHTYG6/v?=
 =?us-ascii?Q?NKDCsX8MJF2b8uzx9VXX6CfIU5jK1hEckybJdOdgSycMByTiG4w6sfSV5o7+?=
 =?us-ascii?Q?Mk44w58dcw/0sNS5TNLgLHsUnxFceVaxk0Nagw/U0dIV5Zm0Sw/l3X/CBMLc?=
 =?us-ascii?Q?soDUEtYJcUZSmnRfHhcRCUYZ8OtgJOsc0WUMw4kPvI+rLtnZVUyu8jcngtTJ?=
 =?us-ascii?Q?81MJW6Hueu7teYoncjd1us3uR42zoYQbBBochpQQjtHfcMMLPQyc3hBKWWVj?=
 =?us-ascii?Q?NLrrClSZaLr5IcqmqeJyCyHjXA9OE1TK5b9DoVZ3RSCZr3pJ+PycxIZc6q74?=
 =?us-ascii?Q?cQ6NhndHItJax2RKF38ze3ZuDIDIXK+HjlFepMiCAbFKOHl5JYiZbifFp888?=
 =?us-ascii?Q?yMNIKudmoAGeB49HNuaTS3B8psacM2HrRtBceqJ+XpYpaI5XMNFncbq2GlI5?=
 =?us-ascii?Q?N7PbVO30Lsxs8eKpeJqEBqL+NZYg0GTcogSHRAIr9QfR3au5zN/Cp/XrdCLx?=
 =?us-ascii?Q?4Zy8VUYRwmJH6TGxf03W6qo4qCIw7XVC+53JGC7XmNzgwv7suED/n6JbmnNa?=
 =?us-ascii?Q?O2NYBYYu7g15oDqKkrRL/KYSRtVI5p3RF212quVXmd9B3F7u8/gPvFgyhOgP?=
 =?us-ascii?Q?A29muGmPumY2o8Us8QKzFXmIUdqFHVyQLjZESxw4pZp/sAmUjOdorAonbNdA?=
 =?us-ascii?Q?DpQpTNhBRE+SDNmYsNoQG6scu3nwXrrrouBTiXYrzusNqztQq713Xn/oj4/R?=
 =?us-ascii?Q?ggHu8OYjDSR9GZj6Kgrs0mSFgqsxmqn4dbk0u/4A9oWEgi90FZNsooNjYPtY?=
 =?us-ascii?Q?4sHCQNvon9Bu0CrCngw6PyeNb096Q3newl1S7sTSyOLQ84JdWi8R3WRIUp5s?=
 =?us-ascii?Q?rK3Dt4fFNL4b/etT6KK4HR0bkp7dt9cU9GjDpA96TdWomoVqx5D6/PzDk99q?=
 =?us-ascii?Q?JsVFB1qwLdbbltvG0DwSfMC4VgWPoM0IcLEaP7UN1mHEoxMz7idGM1zM923I?=
 =?us-ascii?Q?nNzolyW2gZ3C0jQTMQeUzIUUkkFYJzuLlvn57yBx/k7qovz0OfjZ7Erce2ho?=
 =?us-ascii?Q?goJnYBxepM2A6RjqM48kTEq/IoygQSW3nZfBD0X76sRbAT3GVDwmOnhni6yC?=
 =?us-ascii?Q?wZ7VEwl5Q3A3ef/I3PSrQ92DgriVqM5y0jHZ+mDMgDSDLXxnFSfmyWNyUdDf?=
 =?us-ascii?Q?gEeHj9ZL9M09Y4bilc5EPFMeG92GozV52g0sf8Q3e1VveK8RCJzTSaQomZal?=
 =?us-ascii?Q?S1NQjGwVDr80zc2ATG/BV3Uy6ZZAm9m0NN1llVBnRhS14TEYnNFMEbRD/sll?=
 =?us-ascii?Q?c9WI6fAa9f3citNwuyB2hKlmLl3U5r/z/nx/vloUrHsWQZHE8+Me3emV2hCl?=
 =?us-ascii?Q?PzmFKW/tIXrjjBA/uek=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fc19540-c7ef-4912-1f60-08dac2733ee3
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 16:55:45.8289
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SM5bBlMlUVbTHQCpLEYm/jftMLo87iM2X5WoYPZMV/pysX7TYvolxPJyRuagNvAg
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR84MB1578
X-OriginatorOrg: hpe.com
X-Proofpoint-ORIG-GUID: z_tCc3DipiwOie03yKXrOf-wUF8Wxe1K
X-Proofpoint-GUID: z_tCc3DipiwOie03yKXrOf-wUF8Wxe1K
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-09_06,2022-11-09_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0
 bulkscore=0 mlxlogscore=999 impostorscore=0 adultscore=0 clxscore=1015
 priorityscore=1501 suspectscore=0 lowpriorityscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2211090128
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> b/Documentation/admin-guide/kernel-parameters.txt
> index a465d5242774af8..2729f3ad11d108b 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -5082,6 +5082,12 @@
>  			rcupdate.rcu_cpu_stall_timeout to be used (after
>  			conversion from seconds to milliseconds).
>=20
> +	rcupdate.rcu_cpu_stall_cputime=3D [KNL]
> +			Provide statistics on the cputime and count of
> +			interrupts and tasks during the sampling period. For
> +			multiple continuous RCU stalls, all sampling periods
> +			begin at half of the first RCU stall timeout.

This description should start with:
    "In kernels built with CONFIG_RCU_CPU_STALL_TIME=3Dy, "

Also, that parameter name seems like it contains a time value, but
it's really just treated as zero vs. anything else. Consider renaming
it to rcu_cpu_stall_cputime_en or describing the values in the
description ("0 disables, all other values enable").

> diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
> +struct rcu_snap_record {
> +	unsigned long	gp_seq;		/* Track rdp->gp_seq counter */
> +	u64		cputime_irq;	/* Accumulated cputime of hard irqs */
> +	u64		cputime_softirq;/* Accumulated cputime of soft irqs */
> +	u64		cputime_system; /* Accumulated cputime of kernel tasks
> */
> +	unsigned long	nr_hardirqs;	/* Accumulated number of hard irqs */
> +	unsigned int	nr_softirqs;	/* Accumulated number of soft irqs */

That should be "unsigned long" to match the other patch


> diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h
> +static void print_cpu_stat_info(int cpu)
> +{
...
> +	pr_err("         hardirqs   softirqs   csw/system\n");
> +	pr_err(" number: %8ld %10d %12lld\n",
> +		kstat_cpu_irqs_sum(cpu) - rsrp->nr_hardirqs,
> +		kstat_cpu_softirqs_sum(cpu) - rsrp->nr_softirqs,
> +		nr_context_switches_cpu(cpu) - rsrp->nr_csw);
> +	pr_err("cputime: %8lld %10lld %12lld   =3D=3D> %lld(ms)\n",

Those should all start with "\t" to match other related prints.