Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp949344rwb; Wed, 9 Nov 2022 10:36:17 -0800 (PST) X-Google-Smtp-Source: AMsMyM4AzFJcuF6YN4zb7KgvbAN4UGX1qX6PkxoXIA2evJ4qcMJL0zArouqoDRbCOumj40cv13QV X-Received: by 2002:a05:6402:3806:b0:450:bad8:8cd5 with SMTP id es6-20020a056402380600b00450bad88cd5mr62381018edb.305.1668018977353; Wed, 09 Nov 2022 10:36:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668018977; cv=none; d=google.com; s=arc-20160816; b=CxtsJ5mcU0XoPiJgVhGdYDwfuKRjWPFQubTaHEdUWctq6Vw8A2vbPmiF0mPL0V8o7b meLFQqzcyNYm+49vqaf7yzUg++tjVoYUOzhiGUDsuc97kC8wua13GhDTP2bhrwV8L9mE yEIiXSluOCX7C9Ty5UqlcuiXE989m4rBGn+AZFVGozRRskx5eYzdca2CqjIptSitgxDc hRnQJPTBqS93W2no+RlAnMVaVEohRwOarpV9tdYiQsA5HVH9eoSWPqBjMrQyfJKxYDun SQAPzCLpTaimap6HpmDgk+3kiSSu3JfWt7tciETa+7oyy5NLYt+OmazVJTTr1/7KmaUL LC/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=AQG2RkQE2K4jN3DTLcKCj+n7FIQpSRuiWYNx9YKVzEk=; b=RUfYQQhobBUxAgEQyRqmG4ZJzzhSiYleVdkE0JjVV3f8UNmLtFzm+UQ64Xc3raWaRe wrdhBIIOKYCPRa2DGvJADDWpHgrxoe5wMCEyjZYdhJWvrmReDcLmyaKCO0jsO7PUEA5b pjcaBUvl09ViVWqO8k0XyWsItsk923cc4MHuHB39BWIA9Jv3mG9I+qhVOIBJQs8UdrF7 652LYodkEF3dB9+E8EQk/Qf5bY06SlD8l9bBDfHMzslrAUappl+5jDyYCYp/OYbzRDUw fF44v4nVJbmcrpSTyi+vSDRrSR6I74+tMCtpyonbwFPNdokMTSZBNuBbVjoPh++EKbsg 3giA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=VwYD9hP+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p11-20020a056402500b00b00463d163df67si14953208eda.430.2022.11.09.10.35.52; Wed, 09 Nov 2022 10:36:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=VwYD9hP+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229551AbiKISTn (ORCPT + 93 others); Wed, 9 Nov 2022 13:19:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbiKISTl (ORCPT ); Wed, 9 Nov 2022 13:19:41 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CB2627DDA; Wed, 9 Nov 2022 10:19:40 -0800 (PST) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2A9GDbFf026232; Wed, 9 Nov 2022 18:19:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=AQG2RkQE2K4jN3DTLcKCj+n7FIQpSRuiWYNx9YKVzEk=; b=VwYD9hP+R7W/LVy/bW3uIx72vxxarFykVLa0KkG2gl4mp+etoUrJDcbbvjDMkPLjE3e0 K6bDQ9oxtepOWYnoiVb++hk8FIJnc2XRwrC87LxlLT8XYGRdxRgLQmcHFP2GnsUcnd7f eKpXrGCQRM6Se+AA/KA5owsI3OlUP9qTUhFexCppHPApIS5JOJUy0+nv1mO8g05BMvDe zHDhQx5IDRXekJAN72Scb8BneDwWNBq99sumju7oDzi1m+iYIV4s55pJFvXO/yH9vFEk tvIpFRzjLhaWSvBMqN0CSP6OM4kHJvnFqVX5QM3s4muMieqH/L4yWhaZQDoubFrTi/km Pw== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3kr6b424k4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Nov 2022 18:19:32 +0000 Received: from nasanex01b.na.qualcomm.com (corens_vlan604_snip.qualcomm.com [10.53.140.1]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2A9IJVNN028161 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 9 Nov 2022 18:19:31 GMT Received: from [10.110.39.13] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Wed, 9 Nov 2022 10:19:31 -0800 Message-ID: <8c1072a0-338e-7bf4-2d78-c59954cf8164@quicinc.com> Date: Wed, 9 Nov 2022 10:19:30 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3 3/4] arm64: dts: qcom: Add base QDU1000/QRU1000 DTSIs Content-Language: en-US To: Konrad Dybcio , Trilok Soni , Krzysztof Kozlowski , Andy Gross , "Bjorn Andersson" , Rob Herring , "Krzysztof Kozlowski" CC: , , References: <20221026200429.162212-1-quic_molvera@quicinc.com> <20221026200429.162212-4-quic_molvera@quicinc.com> <9eaaf256-8de2-ddc9-ac95-aed9b0670f5e@linaro.org> <4832b716-6caf-cf72-1c7e-f21a0670cbaa@quicinc.com> <5109d728-ebea-21ca-3ee1-15710dfd6f1b@quicinc.com> <23a0dc6b-b704-c094-96dc-cf2c083ef55e@somainline.org> From: Melody Olvera In-Reply-To: <23a0dc6b-b704-c094-96dc-cf2c083ef55e@somainline.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: r83aBRtG6KiPbIgypLlXK0PCW43atpnV X-Proofpoint-ORIG-GUID: r83aBRtG6KiPbIgypLlXK0PCW43atpnV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-09_06,2022-11-09_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 phishscore=0 adultscore=0 spamscore=0 clxscore=1011 suspectscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211090138 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/4/2022 2:32 AM, Konrad Dybcio wrote: > > On 04/11/2022 05:05, Trilok Soni wrote: >> + Adding Konrad, Bjorn is already there in this email >> >> On 11/3/2022 2:13 PM, Melody Olvera wrote: >>> >>> >>> On 11/2/2022 9:24 AM, Krzysztof Kozlowski wrote: >>>> On 31/10/2022 17:49, Melody Olvera wrote: >>>>> >>>>> On 10/27/2022 8:21 AM, Krzysztof Kozlowski wrote: >>>>>> On 26/10/2022 16:04, Melody Olvera wrote: >>>>>>> Add the base DTSI files for QDU1000 and QRU1000 SoCs, including base >>>>>>> descriptions of CPUs, GCC, RPMHCC, QUP, TLMM, and interrupt-controller >>>>>>> to boot to shell with console on these SoCs. >>>>>>> >>>>>>> Signed-off-by: Melody Olvera >>>>>>> --- >>>>>>>   arch/arm64/boot/dts/qcom/qdu1000.dtsi | 1406 +++++++++++++++++++++++++ >>>>>> Please use scripts/get_maintainers.pl to get a list of necessary people >>>>>> and lists to CC.  It might happen, that command when run on an older >>>>>> kernel, gives you outdated entries.  Therefore please be sure you base >>>>>> your patches on recent Linux kernel. >>>>> Sure thing; we talked about this on a different patch. >>>>>>> arch/arm64/boot/dts/qcom/qru1000.dtsi |   27 + >>>>>>>   2 files changed, 1433 insertions(+) >>>>>>>   create mode 100644 arch/arm64/boot/dts/qcom/qdu1000.dtsi >>>>>>>   create mode 100644 arch/arm64/boot/dts/qcom/qru1000.dtsi >>>>>>> >>>>>>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi >>>>>>> new file mode 100644 >>>>>>> index 000000000000..76474106e931 >>>>>>> --- /dev/null >>>>>>> +++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi >>>>>>> @@ -0,0 +1,1406 @@ >>>>>>> +// SPDX-License-Identifier: BSD-3-Clause >>>>>>> +/* >>>>>>> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. >>>>>>> + */ >>>>>> (...) >>>>>> >>>>>>> + >>>>>>> +    soc: soc@0 { >>>>>>> +        #address-cells = <2>; >>>>>>> +        #size-cells = <2>; >>>>>>> +        ranges = <0 0 0 0 0x10 0>; >>>>>>> +        dma-ranges = <0 0 0 0 0x10 0>; >>>>>>> +        compatible = "simple-bus"; >>>>>>> + >>>>>>> +        gcc: clock-controller@80000 { >>>>>>> +            compatible = "qcom,gcc-qdu1000", "syscon"; >>>>>>> +            reg = <0x0 0x80000 0x0 0x1f4200>; >>>>>>> +            #clock-cells = <1>; >>>>>>> +            #reset-cells = <1>; >>>>>>> +            #power-domain-cells = <1>; >>>>>>> +            clocks = <&rpmhcc RPMH_CXO_CLK>, <&sleep_clk>; >>>>>>> +            clock-names = "bi_tcxo", "sleep_clk"; >>>>>>> +        }; >>>>>>> + >>>>>>> +        gpi_dma0: dma-controller@900000  { >>>>>>> +            compatible = "qcom,sm6350-gpi-dma"; >>>>>> You should add here a specific compatible as well. Same in other places. >>>>>> All places. I had impression we talked about this few times, so I don't >>>>>> know what is missing on your side. >>>>>> >>>>>> This must be: >>>>>> "qcom,qdu1000-gpi-dma", "qcom,sm6350-gpi-dma" >>>>> Got it. I talked to Stephan and he said either your suggestion or just using >>>>> preexisting compatibles would be ok. I thought it might be cleaner to not >>>>> have the qdu compats, but I'm fine either way. > > We use specific compats so that if it turns out this specific SoC (or rather the > > bundled firmware) has some peculiar bugs, we can retroactively only apply them > > to that specific SoC by adding the compatible somewhere in .c code if need be. Ah that makes plenty sense. > > >>>>>>> +            #dma-cells = <3>; >>>>>>> +            reg = <0x0 0x900000 0x0 0x60000>; >>>>>>> +            interrupts = , >>>>>>> +                     , >>>>>>> +                     , >>>>>>> +                     , >>>>>>> +                     , >>>>>>> +                     , >>>>>>> +                     , >>>>>>> +                     , >>>>>>> +                     , >>>>>>> +                     , >>>>>>> +                     , >>>>>>> +                     ; >>>>>>> +            dma-channels = <12>; >>>>>>> +            dma-channel-mask = <0x3f>; >>>>>>> +            iommus = <&apps_smmu 0xf6 0x0>; >>>>>>> +        }; >>>>>>> + >>>>>> (...) >>>>>> >>>>>> >>>>>>> + >>>>>>> +        tlmm: pinctrl@f000000 { >>>>>>> +            compatible = "qcom,qdu1000-tlmm"; >>>>>>> +            reg = <0x0 0xf000000 0x0 0x1000000>; >>>>>>> +            interrupts = ; >>>>>>> +            gpio-controller; >>>>>>> +            #gpio-cells = <2>; >>>>>>> +            interrupt-controller; >>>>>>> +            #interrupt-cells = <2>; >>>>>>> +            gpio-ranges = <&tlmm 0 0 151>; >>>>>>> +            wakeup-parent = <&pdc>; >>>>>>> + >>>>>>> +            qup_uart0_default: qup-uart0-default-state { >>>>>>> +                pins = "gpio6", "gpio7", "gpio8", "gpio9"; >>>>>>> +                function = "qup00"; >>>>>>> +            }; >>>>>>> + >>>>>>> +            qup_i2c1_data_clk: qup-i2c1-data-clk-state { >>>>>>> +                pins = "gpio10", "gpio11"; >>>>>>> +                function = "qup01"; >>>>>>> +                drive-strength = <2>; >>>>>> Can we have some generic agreement where to put drive-strengths and bias? >>>>>> >>>>>> See also: >>>>>> https://lore.kernel.org/linux-devicetree/20221026200357.391635-2-krzysztof.kozlowski@linaro.org/ >>>>>> >>>>>> https://lore.kernel.org/lkml/CAD=FV=VUL4GmjaibAMhKNdpEso_Hg_R=XeMaqah1LSj_9-Ce4Q@mail.gmail.com/ > > I agree with Doug on having 'generic' drive-strength. Moreover, maybe even adding some property like > > bias-type = would be cool to make it more flexible so that we could trim off > > A LOT of repeated lines (remember, most boards are more or less copies of the reference design for a > > given platform like QRD or CRD) going forward. Huh so if I understand this correctly, like a generic QRD/CRD file which has the bias for specific pins? That's a neat idea. I will say it kinda seems like this is a larger conversation happening here. Does it make sense to submit a next version with these pins as they are or wait until this larger conversation concludes? > > >>>>> Not sure how much two-sense I have for the conversation at large, but generally I agree with Doug's >>>>> point in the first paragraph. Pulls for this soc are consistent across boards so I don't think it makes >>>>> sense to move them to the board files here. I vote that these stay here. >>>> I would be great if Konrad and Bjorn shared their opinion on this... but >>>> wait, you did not Cc all maintainers... Eh. >>> I'm not sure why this is being brought up again; we've already discussed this here >>> https://lore.kernel.org/all/9707bf67-1b22-8a77-7193-fc909b4f49de@quicinc.com/ >>> Would you like to discuss this issue here, on the next version, or not at all? >>> >>> On a side note, I'm uncomfortable with how our continued interactions are going >>> and do not believe this to be conductive to continued collaboration. I would ask that >>> we keep our correspondence polite and professional moving forward. >> >> I have added Konrad and Bjorn is already there on the thread. Our understanding is that CCing maintainers comment is for next patch series after this one. > > BTW: you can feed git send-email with --cc-cmd='./scripts/get_maintainer.pl --norolestats' and > > it'll pick the right people for you (most of the time, anyway). Sounds good; thanks for the help! Thanks, Melody > > >> >> Bjorn, please check and comment on above? If requires we should start writing the guidelines for MSM boards since lot of comments are based on the experience or knowledge in the community Vs caught by tools - so it is easy to be missed by developers submitting new boards. Thoughts? > > Big yes! Some of the points should probably even be raised wrt the DT spec itself, such as property order. > > > Konrad > >> >> ---Trilok Soni >> >>