Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp984345rwb; Wed, 9 Nov 2022 11:05:51 -0800 (PST) X-Google-Smtp-Source: AMsMyM4qgX5e6LhsHD0PtmBnDugRyGCF17UoTCGtXLUTjclfw23YQIP4pv+GE9utWY+QgVTHb9gA X-Received: by 2002:a17:90a:d24d:b0:213:d3e4:677a with SMTP id o13-20020a17090ad24d00b00213d3e4677amr54803369pjw.101.1668020751364; Wed, 09 Nov 2022 11:05:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668020751; cv=none; d=google.com; s=arc-20160816; b=RZ97j6y2vgRboMW26Ys5iv1m/wLjYLbI7wmv6AMKVeEnY4F4zPbf3Rxbm+jJrXa7N7 GKX+CjRso7ivsp7p5TXEMWyzwXEox6vn7oLMiGWlFR4BGQwRPkMVSzS2Zgd/d1rtZlH2 fqJT2ggSpcDZsStjjq63Koffkor8QadofoWkhBwMAmHTEtj3Qi+yvSO3fyjRTXY9NrhF rIkFU1SSt2aXXKYXX1LIZRYD4B88cbdxadCbSlELhm9NX3nEV9qf38J8yAMQHplI1Wsb 9216ohEFU52lxzKBs97tT2RczFMsC8O6PZtGDG39Q8i1gVBqGancdV3CEayTc3n7Y5si IqKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vl4XLzQcuo+aRGSViP/GXiLaL/UL9EneA2APr6j3A8A=; b=JYOh6FimDt0ZGmZcQrpVBMY6yUwz5sNYjuZNRvYJOc32F1YBzoFAQBonzqeBCxIWG8 oL5N6Ngx6TxUlTJ1UMCcS9g9eka/8GNhNXPKyaCY8yWSnXdTZlBGsxo815dkwtgn/iP/ OsfAlxwG75EN59IH0ujWtfIQ4Z+BfLqd/hP/PKqDGb05HsT3dqNZl8Q42DaY0MPmqIp/ WHYjAjqpEmhDbRH8P2+meeQy5NmDyKKSftgEkfwQaH8y6eLYpIEJ5FWWEJ9jZo/etmd2 d6L9z0orKFPs1qHlV9ZeDQQJYMS5wfaZkgow1sV4cNy35ypu+liSVcHDLU+MJzfhSYzu xOZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aDq7gFkV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lp15-20020a17090b4a8f00b0021414ac5caasi2505078pjb.124.2022.11.09.11.05.36; Wed, 09 Nov 2022 11:05:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aDq7gFkV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230244AbiKISUk (ORCPT + 92 others); Wed, 9 Nov 2022 13:20:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbiKISUi (ORCPT ); Wed, 9 Nov 2022 13:20:38 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2F7324F17; Wed, 9 Nov 2022 10:20:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2CCF961C28; Wed, 9 Nov 2022 18:20:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF291C433C1; Wed, 9 Nov 2022 18:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668018036; bh=lHGIXa/gzMZc3tKmxe07xLxCc5ENdiRStUxmf+RJ76E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aDq7gFkVLaBFz3piUo2ROtjM7vxyTK0VgBb5MXkNJgRAbmWlBmTQAiI41f+1Fq2qu hkBF5vneS+6G0CgV0oggBnfm/bAMNfaMfflzjPZ8cCLyMC+11/bbC0LaTWC8z9KShf KEvyGPmr1uvvOjajknE8coL4wgOAepw9wtS7ip9S9Ed8mf7iJ/Z8fkvVZbYim3DyHw /CjzIqaQe8NMx0OCe2GRwOsKL4SZ42DEtNbTPZSJ03z7K5ixHbjnvnlvVElMzKTUAE hQKRXQgFBEbHSRD6K2dYHJ/IssE5VQhMrtpOw/7P2lXAzoDqsuMLK67aCu4bO3UtAn f/7fnsVKFTauA== Date: Wed, 9 Nov 2022 20:20:31 +0200 From: Leon Romanovsky To: Ivan Vecera Cc: netdev@vger.kernel.org, sassmann@redhat.com, Jacob Keller , Patryk Piotrowski , SlawomirX Laba , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "moderated list:INTEL ETHERNET DRIVERS" , open list Subject: Re: [PATCH net] iavf: Do not restart Tx queues after reset task failure Message-ID: References: <20221108102502.2147389-1-ivecera@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221108102502.2147389-1-ivecera@redhat.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 08, 2022 at 11:25:02AM +0100, Ivan Vecera wrote: > After commit aa626da947e9 ("iavf: Detach device during reset task") > the device is detached during reset task and re-attached at its end. > The problem occurs when reset task fails because Tx queues are > restarted during device re-attach and this leads later to a crash. <...> > + if (netif_running(netdev)) { > + /* Close device to ensure that Tx queues will not be started > + * during netif_device_attach() at the end of the reset task. > + */ > + rtnl_lock(); > + dev_close(netdev); > + rtnl_unlock(); > + } Sorry for my naive question, I see this pattern a lot (including RDMA), so curious. Everyone checks netif_running() outside of rtnl_lock, while dev_close() changes state bit __LINK_STATE_START. Shouldn't rtnl_lock() placed before netif_running()? Thanks > + > dev_err(&adapter->pdev->dev, "failed to allocate resources during reinit\n"); > reset_finish: > rtnl_lock(); > -- > 2.37.4 >