Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Keller, Jacob E" <jacob.e.keller@intel.com>
To:     Leon Romanovsky <leon@kernel.org>, ivecera <ivecera@redhat.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "sassmann@redhat.com" <sassmann@redhat.com>,
        "Piotrowski, Patryk" <patryk.piotrowski@intel.com>,
        SlawomirX Laba <slawomirx.laba@intel.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net] iavf: Do not restart Tx queues after reset task
 failure
Thread-Topic: [PATCH net] iavf: Do not restart Tx queues after reset task
 failure
Thread-Index: AQHY81xt1U/+TsWFeEauMLnzqEhDea426S2AgAAeHmA=
Date:   Wed, 9 Nov 2022 20:11:55 +0000
Message-ID: <CO1PR11MB508996B0D00B5FE6187AF085D63E9@CO1PR11MB5089.namprd11.prod.outlook.com>
References: <20221108102502.2147389-1-ivecera@redhat.com>
 <Y2vvbwkvAIOdtZaA@unreal>
In-Reply-To: <Y2vvbwkvAIOdtZaA@unreal>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fnlHVcN8eV/46759UB55KbjxiUhtmbui3ygUDNpvaOqEAUjWCb7W/dCCHjD6?=
 =?us-ascii?Q?gPy0PWHgWBXnArf61/ECzpR+ySnl7HA8aunnhR3YQJ+/zosYlylPpQPXqVlR?=
 =?us-ascii?Q?s9tZfqkKCmHaQ2pYYZyDPnBjgc0hgIuGqSWnVdeWwPHt4X0oU8Z9hppddpAY?=
 =?us-ascii?Q?uQN2n8wqAbNSX+eYLRiUloXpLQME3mU7v6mwRS8yPC6DfsqMAbFxi70flVdr?=
 =?us-ascii?Q?MSe2Ls7bfg6kyxahpALhvL3GA5Idm1Yp/pP2ilWolhBJn02Q+ITH1ZvuJZcI?=
 =?us-ascii?Q?1AjcQO7kd01e6cm6JKs08SCxRCUnlfkEwKiCBDh5qpsLKSKI6MiQcRtFmJ2U?=
 =?us-ascii?Q?PKkum9yCFItiqOwp5k1sFmuQmSu+GwHq8c79sySWtZ8EvlcgB/r/seTPKpn6?=
 =?us-ascii?Q?kATobN4L9/NnEUDvMgfTLYqXTU4kfiLXXQfvIDjdkkJvL6Az9Ar6s8cTHZeo?=
 =?us-ascii?Q?NUqflxug2ihGTGGrLpl9N/aZSnv7B24W2djdG+u1bMLomGGjV89L7m1hEnaY?=
 =?us-ascii?Q?V05/1DaBNjzo0JdMGpp+EY55M9ny79T8Nan2Do2GyB6S26BEIMk15V1iwjc3?=
 =?us-ascii?Q?fxjIUk4O4Jb0IxG2SbKknic7OOGFEB0RIx8roY10OkAfhCDv5Eu9/eomTJWk?=
 =?us-ascii?Q?lalZbX1oCS2s7RIMARE6kpXEcGsmLrtGnAazwvQAuPj/4WD6qmY7W5ukK5bt?=
 =?us-ascii?Q?JrXvxeWbm137EE4y7m3CX2ZEiOdUhRuJ0nvXHTNnsThtTDTeS9C9HxpjVkfL?=
 =?us-ascii?Q?sHi56NuiVwMb1N+qmYQh+uDNkDxWFOC/rj+hkV9/+kkhXgJl7pgjEn1x7/Jx?=
 =?us-ascii?Q?nTOao0VSTRlCt5llqiHINKxG9osLWj8MH5lmMCM0oP3lz/4KCVUeYw+cAGOx?=
 =?us-ascii?Q?iVoY8Boy4PfY0HnW3ny5PPQgUpGwdvhdvUMnDCNmymgdShwn2toSCpNVBIYG?=
 =?us-ascii?Q?jwUp9JWSO4aDJ5yTia+MZEjB84zoeJ6HDAHicYj/lKApImt85waNV5prE7LD?=
 =?us-ascii?Q?vys2bhYjG7rgD7HLyQQPJdc24HOMiVXH6kLf0RcILZm8V9PHCxed5/1OfxMH?=
 =?us-ascii?Q?oxjlVwnrM+Mg66oS8HFmuLOvJVFCIFeX3A08Od8fhcewOhWepTPtFntv/e6b?=
 =?us-ascii?Q?hPwDuiackpF7KSB5VW4ckfo6GdqmjVP4oyT2qACTV4u2FtpqpiHOjnIIsTeA?=
 =?us-ascii?Q?Icyf26Kv5KbiLk/3ORKIQd5BBC9OVaAWsjf/HNKD6cMNxzKDepA5uLK5cYR/?=
 =?us-ascii?Q?3rT7ATelZBsdrEoyyXcr3p00uJ5G+M6TH8LNMgHHoeyeHySiYuONb2vdFVZA?=
 =?us-ascii?Q?bXG2FvEhV24glq2v/zIU0WjWSHFR5FRi/humhqn5ym+A1N8PBKthNI++DVjE?=
 =?us-ascii?Q?jVDCqvdcpZ+13T1DC0hyClrzNanmlldARGSnA7ej9Vr4HMXlmVsRIHVHEWyt?=
 =?us-ascii?Q?s4YfMX3a4+pXz1uv6BEwVC1zBgx5oPYPvJpg7MBu1kkF56bgNlrSdImHHgip?=
 =?us-ascii?Q?I1s4HwPCa47DCueZU/RvRCHzGGjmSKCm/ufvX8yEKBNcIisFOYpRcAlanune?=
 =?us-ascii?Q?0JibIdw+8UB4T1/Wz9b8QpTQNjC8egptHY+oU0l57C5gvxkQJ1+VHGMHq/bo?=
 =?us-ascii?Q?yg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 50dd5b19-9b41-41ad-f98e-08dac28ea648
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 20:11:55.6666
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZyBrWLB8B6oAiryiHnwuOAoQVFtZ9H+dMeJka8dd4m4G60izxl6B45QX9dWbM+x56pikXuIcPsc95aeAbMsSHXUiCCBpVEgojhrKVSSmmLQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6162
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Leon Romanovsky <leon@kernel.org>
> Sent: Wednesday, November 9, 2022 10:21 AM
> To: ivecera <ivecera@redhat.com>
> Cc: netdev@vger.kernel.org; sassmann@redhat.com; Keller, Jacob E
> <jacob.e.keller@intel.com>; Piotrowski, Patryk <patryk.piotrowski@intel.c=
om>;
> SlawomirX Laba <slawomirx.laba@intel.com>; Brandeburg, Jesse
> <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>; moderated list:INTEL ETHERNET DRIVERS <intel-
> wired-lan@lists.osuosl.org>; open list <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH net] iavf: Do not restart Tx queues after reset task =
failure
>=20
> On Tue, Nov 08, 2022 at 11:25:02AM +0100, Ivan Vecera wrote:
> > After commit aa626da947e9 ("iavf: Detach device during reset task")
> > the device is detached during reset task and re-attached at its end.
> > The problem occurs when reset task fails because Tx queues are
> > restarted during device re-attach and this leads later to a crash.
>=20
> <...>
>=20
> > +	if (netif_running(netdev)) {
> > +		/* Close device to ensure that Tx queues will not be started
> > +		 * during netif_device_attach() at the end of the reset task.
> > +		 */
> > +		rtnl_lock();
> > +		dev_close(netdev);
> > +		rtnl_unlock();
> > +	}
>=20
> Sorry for my naive question, I see this pattern a lot (including RDMA),
> so curious. Everyone checks netif_running() outside of rtnl_lock, while
> dev_close() changes state bit __LINK_STATE_START. Shouldn't rtnl_lock()
> placed before netif_running()?

Yes I think you're right. A ton of people check it without the lock but I t=
hink thats not strictly safe. Is dev_close safe to call when netif_running =
is false? Why not just remove the check and always call dev_close then.

Thanks,
Jake

>=20
> Thanks
>=20
> > +
> >  	dev_err(&adapter->pdev->dev, "failed to allocate resources during
> reinit\n");
> >  reset_finish:
> >  	rtnl_lock();
> > --
> > 2.37.4
> >