Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1142712rwb; Wed, 9 Nov 2022 13:31:35 -0800 (PST) X-Google-Smtp-Source: AMsMyM6G2Uc/atwsNWf0DLebPcU6gf+zWDBdPU7pQ1rJNBVIZpJrhzl2w/sFXlHhmXgtv+z3gnAc X-Received: by 2002:a17:90b:4c50:b0:213:ba14:c7f3 with SMTP id np16-20020a17090b4c5000b00213ba14c7f3mr61236102pjb.43.1668029495055; Wed, 09 Nov 2022 13:31:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668029495; cv=none; d=google.com; s=arc-20160816; b=ZSmn8B6dXoo/VyRAWnDsmJ2psU1oJ8tm3ZHnbWQMaPPvbV45+bmmigGUJVtlmcd/kz mevG1uxH+qfsoqD/mM9NrenE8WzbWlgXPn/mWA08bWPDS0spbN6bYmv32oCOFoTopiul +n8QiaXR8FFxEJV0z0tDR6+QrMw9jQ4fRC1FsbjNJjumUah9okWTfdQjdhIcsKIaegP0 g1qqXukrs8zpau/lnQI/bNWi8uvcV3TtJEVN0o59/bIsQ7jzzhhN6F9GM5JKZ45VqcD5 TAWOVpH63LWR6b7K6KgweFTTDL9LSCEiKTGgxDzmaPUd5yOMLWecJDV89LBfgxW+wrsD Oqzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=c2Wy125HjX2W7gqEInmUWaHL+2Vak7X60gZ/uKVxsSs=; b=aXoW35utFhetRFGJW0JFGXpMx2K3BOxARe5zogzwfu36HEJ1HXx5ep1WtXURox2WKw uDfl/qKBI/d3NtnYoY9yfybPqjA83m/tq4uewRr2Oc7TTuLkqcb8Gw9Nj/ZFllsTeH00 74vVCuNpFdPIZrFmDD4xaLNXczOe2Hr4MSbtwVOTUAyD0UYtyXY3ct7ynrd8Fbczdq9W mYXkiHe7wvYDtJumfnJyHBguwPyCzmTgZhyMAInNu4SnoTLfrW6shdEoOTi9N3c42nBO 0iF+/sGdfZjhbY/yUkb7lKUhioq2sHDTxToh3iZwdOA0aiJ6OMNpstIVXvm34mIwu6gQ oqlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=yTyMtQVI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w8-20020a63f508000000b00453d2790c49si21829744pgh.11.2022.11.09.13.31.23; Wed, 09 Nov 2022 13:31:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=yTyMtQVI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231638AbiKIVRn (ORCPT + 92 others); Wed, 9 Nov 2022 16:17:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbiKIVRm (ORCPT ); Wed, 9 Nov 2022 16:17:42 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3A5431221; Wed, 9 Nov 2022 13:17:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=c2Wy125HjX2W7gqEInmUWaHL+2Vak7X60gZ/uKVxsSs=; b=yTyMtQVIIuXac7UW27SjuG9FjG FaNaEfZ1TQyT856V2r9PHoNMTj1OFga3j6sCeGL5vpTaladSMUcaUqlEh7FhPpGzmcgViQIE+XamI 57plJW0OSYsmvdILQmQY1Q/fNcPb2WEGHDp6RnEVFTvXds//du5ABC2lJNjVOqyXX1A704rNcdiHM aHhVDPBY7FMDBohK5yGY1VIjFtEWemGGKAC1JVcG84zgDMzQiZempRpkBc4NYYMUhbJvIIxVGGvfi XKzZ06LfYfF7ex2aqalbXQBI14ZikP4rfNEIAEAQmmt1pv0oSTTKxu6qp2CS1l45ct8nuw+AyhJWK KjxiEKAg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ossRG-00HMpa-89; Wed, 09 Nov 2022 21:16:50 +0000 Date: Wed, 9 Nov 2022 13:16:50 -0800 From: Luis Chamberlain To: Kees Cook Cc: Jann Horn , Greg KH , Linus Torvalds , Seth Jenkins , Andy Lutomirski , Petr Mladek , Andrew Morton , tangmeng , "Guilherme G. Piccoli" , Tiezhu Yang , Sebastian Andrzej Siewior , "Eric W. Biederman" , Arnd Bergmann , Marco Elver , Dmitry Vyukov , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Vincenzo Frascino , David Gow , "Paul E. McKenney" , Jonathan Corbet , Baolin Wang , "Jason A. Donenfeld" , Eric Biggers , Huang Ying , Anton Vorontsov , Mauro Carvalho Chehab , Laurent Dufour , Rob Herring , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH next v2 0/6] exit: Put an upper limit on how often we can oops Message-ID: References: <20221109194404.gonna.558-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221109194404.gonna.558-kees@kernel.org> Sender: Luis Chamberlain X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 09, 2022 at 12:00:43PM -0800, Kees Cook wrote: > Hi, > > This builds on Jann's v1 patch[1]. Changes in v2: > - move sysctl into kernel/exit.c (where it belongs) > - expand Documentation slightly > > New stuff in v2: > - expose oops_count to sysfs > - consolidate panic_on_warn usage > - introduce warn_limit > - expose warn_count to sysfs > > [1] https://lore.kernel.org/lkml/20221107201317.324457-1-jannh@google.com > > Jann Horn (1): > exit: Put an upper limit on how often we can oops > > Kees Cook (5): > panic: Separate sysctl logic from CONFIG_SMP > exit: Expose "oops_count" to sysfs > panic: Consolidate open-coded panic_on_warn checks > panic: Introduce warn_limit > panic: Expose "warn_count" to sysfs For all: Reviewed-by: Luis Chamberlain Luis