Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934343AbXHGVOZ (ORCPT ); Tue, 7 Aug 2007 17:14:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S935775AbXHGUyo (ORCPT ); Tue, 7 Aug 2007 16:54:44 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:59632 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935768AbXHGUym (ORCPT ); Tue, 7 Aug 2007 16:54:42 -0400 Date: Tue, 7 Aug 2007 13:47:43 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Latchesar Ionkov , Mariusz Kozlowski , Eric Van Hensbergen Subject: [2.6.22.2 review 53/84] fs: 9p/conv.c error path fix Message-ID: <20070807204743.GC23028@kroah.com> References: <20070807204034.882009319@mini.kroah.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="fs-9p-conv.c-error-path-fix.patch" In-Reply-To: <20070807204157.GA23028@kroah.com> User-Agent: Mutt/1.5.15 (2007-04-06) X-Bad-Reply: References and In-Reply-To but no 'Re:' in Subject. Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 827 Lines: 32 From: Mariusz Kozlowski When buf_check_overflow() returns != 0 we will hit kfree(ERR_PTR(err)) and it will not be happy about it. Signed-off-by: Mariusz Kozlowski Cc: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- fs/9p/conv.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/9p/conv.c +++ b/fs/9p/conv.c @@ -742,6 +742,7 @@ struct v9fs_fcall *v9fs_create_twrite(u3 if (err) { kfree(fc); fc = ERR_PTR(err); + goto error; } if (buf_check_overflow(bufp)) { -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/