Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ad35b9b1-447e-c65e-a083-13a8e36c8a5a@oracle.com>
Date:   Wed, 9 Nov 2022 16:12:24 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com,
        tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com,
        hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com,
        sourabhjain@linux.ibm.com, konrad.wilk@oracle.com,
        boris.ostrovsky@oracle.com
References: <20221031193604.28779-1-eric.devolder@oracle.com>
 <20221031193604.28779-8-eric.devolder@oracle.com> <Y2A4TqyOaPYBu4Hk@zn.tnic>
 <1c11a429-b5a9-fb55-fbef-b49e760e2d1e@oracle.com> <Y2I3zQ9ZU+C9Kgf7@zn.tnic>
 <cd820d8a-7ce9-c32f-fc84-bbf20dd7d6e5@oracle.com> <Y2wcJOehWcG7w5c4@zn.tnic>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <Y2wcJOehWcG7w5c4@zn.tnic>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUVVc0tORDhubjB4RVM2eGNOQWtTNmtYZDQrSEEzSWZpL1Ftc1NmcWV3cG5i?=
 =?utf-8?B?dTIybEZJRkdBc1dvanVFQVkrTDAveXl0anRCNVFQeWh6Ry95eHlydHlIaktD?=
 =?utf-8?B?THlaMldqMzl1dWltVWNZSnNsaktQVW9BeENibDNGNjFpNVR6WUhxV0JybCt1?=
 =?utf-8?B?M09zdi81TzVCcHdzWFJNb0VFZXpxalFSTDlHNkw3bU1DVXdhb2ZkcmRLTWVn?=
 =?utf-8?B?TloxY0NpUEEzYVR0NWhWSkhmY2NpMHVTbklrYmtVUlpBZUJSWGd5U3l3dS8y?=
 =?utf-8?B?eHd2OHE0TWhLV3MvMW0ybldOOWNuenNWNXc4U0VGVXhSb1ZtaFlUU2lhenlq?=
 =?utf-8?B?REtXUmMwbFpKa2pJbWNVUXN3dm5pa0R2cGVUS3hGbWFvQUFMTHExaVNud0JT?=
 =?utf-8?B?ak9YOUN4RWUvektKa0hUTFFxWlFMdkc1cmhLQ1lNQVZ2ckx4cndoVGZjdlZn?=
 =?utf-8?B?MDNxUWQ2UXRZdFFuVXhUYzFhNmdrVVRiSEpLMEJQRkpGZkY3RDA0SFJEM1Vz?=
 =?utf-8?B?bU13Ty9IVzdXdVlWdTdXMnNjc1hVZmJFWTdvTzlieW9oMnI1NjZDWlZHOTJn?=
 =?utf-8?B?bkR5LzdoZXBUbVdHN29wVTVhQ0ZVS0dvSmgyalk4bFUxM1ljRzVoa3pjUk5J?=
 =?utf-8?B?aktjS05YSzJNek5nb2s5ZkpOVEtMbElUSWVtdzJibU14bVRhOWMvcDZsRFRH?=
 =?utf-8?B?UjdxN0Z3VEF2NVZ3WjQzTkwza1JPMUxjT1RkcTNrTnV1Y0lQRVJBRjJ3SWpK?=
 =?utf-8?B?RzBQb1dDMTErUkRrYWpMUFRMMEQwanJnUlNFRXI3YWRTdGR1NkJxaGRKSjNU?=
 =?utf-8?B?MC9YVW4wdG10WHVzTVQzSS80V3dXTmN3WHpyVUJRYTRVK2JOaWVOekZVVWNw?=
 =?utf-8?B?YzNpVUdCUENBYWJVcWFWRHFISW9QYXpVQ1Y0RVJpbllybXVwUk5yRGtQU0Qw?=
 =?utf-8?B?L2kzNitkcE4va2dXa1A3Um5CODdwekozQ25VOHFXb1VDQnJrT0pTcHI2dHEx?=
 =?utf-8?B?YlRLTVJCb2RyYlpBOFh4UitaWXhWRlVpanJFOElXSHErcmN1aUVQSWUzWklP?=
 =?utf-8?B?OXBSNjNZZStyNG1rYndoNy96bkcraHlWWTRwVGE3TWtaU1E1QkUrcktBOWVi?=
 =?utf-8?B?Y2JNOG9YVjQ3V1IwaEFmUjlKWTd2alJxWGE4TzBMelBtMDBzZ3FjczJUYTZ4?=
 =?utf-8?B?b1FSa2ZMNTNvcXJFWmoyMjNZclB1NFF1QVh4Rk83ajhGSElwaFRodllRaXJX?=
 =?utf-8?B?T25tQ1MvV09JU293bm52QnRkU2hHYmhTOFEwTWVDcnY2MjFEVzBrSnNaTkIy?=
 =?utf-8?B?RnNoTFVaek1naDV0Vnh1d0lrTUpIMTlXOHZXNmFCUGZJako5M3JGeW5na0NO?=
 =?utf-8?B?NFQwNmhpMy9UeDYrUFZiWXlEODdnbm5GL0IzVUcweG1ucmR0S2Fsb0hNcTAv?=
 =?utf-8?B?RFkrb0RtaFZzYi9oZHNPOXc0VHYxSVNidjFQZUU1R254cGtIenBwQjRQRlZT?=
 =?utf-8?B?R3RZSlE5RXdWQjB6RHNjVS9jaC8vN0FIMVdEVTZwMktEQ2FqU0dYNEJMNjdG?=
 =?utf-8?B?RzhtZWZVSERlS1dtV3hSUjl6Q0VHaTJMRjduWlYxaUE5ZVd6NHhTY0sycWdh?=
 =?utf-8?B?clU1L1AxNUtoeFNocGI0ZkViTzBhZkhKVkdKVkpnOEhZMkY4NTlGc3kwanhw?=
 =?utf-8?B?TVNVeDd2Q1J1QzkyL0xyZldiNDd4dDRzT0FldFhrLzc5d0NKbHFJaE4vL2No?=
 =?utf-8?B?OU80aElUSU13anl4NDFEQnc3ZUZ3YUVyMWM3THNSWFNkYlJYOGpHMnQ4a2U0?=
 =?utf-8?B?dTJkMEF0QVVibkhHM2lUTlN4QnU1OFJ4NkUxR1R5dDZZYmlSVmdhbkd4cVhQ?=
 =?utf-8?B?cDEzQ1hpbEJaajF4di9RWkphYzAwdmhJV0k2MFRHcW1TeWw1cjRCbk9HR1lN?=
 =?utf-8?B?bTVQRWcrYVEvdTBjY1M3SnAvQVpVY0lUd0JvZVZndE5MOW1LdGFaT3E5anNS?=
 =?utf-8?B?VktWQTV4bnJsNHVkcGZGbkNFOGxjM21XOHlKTy9CTkpnWENuTlFQR1ArSTNx?=
 =?utf-8?B?V2xOVE1UMzg4TzkvNXM3Rnc1M0thSkVzWFZqVFh1VXlNY2Y5dG4xdHR3dHg3?=
 =?utf-8?B?RE1Yb1V3a1JTS1lhTTBDdGJEdVpoS040SU1EK0toczZyS25YUVRvdEhYbDVR?=
 =?utf-8?Q?KWdU8g6TGDNwhQADWJuhrrQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eace3ca2-926a-41f7-845c-08dac29f7f18
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 22:12:31.6747
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D2BP7VeI1nbKhXHSiGcBqAfXPr2Jt/SQokDdFk9GUGmgoXpKnuQcw5p8nlyFfT2STjpPhIX3ZY0Fxlk8CgvZnk+RnwKziKPcc9tOXfmbAXQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5384
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-09_06,2022-11-09_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0
 malwarescore=0 mlxlogscore=999 mlxscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211090167
X-Proofpoint-GUID: bnZA7_hMqn4uiQg5JdQpQxSdNvoeA-Mu
X-Proofpoint-ORIG-GUID: bnZA7_hMqn4uiQg5JdQpQxSdNvoeA-Mu
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/9/22 15:31, Borislav Petkov wrote:
> On Wed, Nov 09, 2022 at 09:48:33AM -0600, Eric DeVolder wrote:
>> ...
>> which then defaults HOTPLUG_CPU to on and thus this code/ifdef in question.
> 
> defconfig can sometimes lag reality. In this case, the majority of
> machines have SMP=y because the majority of machines out there are,
> well, multicore.
> 
>> So at this point, I'm still not sure if you want the ifdef line:
>>   - removed altogether
>>   - transitioned to CRASH_HOTPLUG
>>   - leave as is
> 
> So let's think out loud:
> 
> * the majority of machines will have CONFIG_HOTPLUG_CPU=y because
> they're SMP machines and we want the elfcorehdr updates to happen when
> CPUs get offlined or onlined.
> 
> CONFIG_MEMORY_HOTPLUG is most likely going to be =n on the majority of
> machines out there.
> 
> (Note how the deciding factor for all this is what would make sense on
> the prevailing majority of machines out there.)
> 
> And memory hotplug will be off for the simple reason that not so many
> machines have memory hotplug hardware capability.
> 
> Which then means, IMHO, this functionality should be separate: have a
> CPU hotplug callback and a memory hotplug callback.
> 
> And you kinda do that in
> 
> Subject: [PATCH v13 3/7] crash: add generic infrastructure for crash hotplug support
> 
> but then this all calls into a single handle_hotplug_event() and that
> hp_action doesn't really matter.
> 
> It is used in the call to
> 
>    arch_crash_handle_hotplug_event(image, hp_action);
> 
> but that hp_action argument is unused in the x86 version. >
> IOW, you can do this callback regardless whether it is a CPU or memory
> hotplug event.
> 
> So thinking about it, a single CONFIG_CRASH_HOTPLUG which unifies those
> CPU and memory hotplug callback functionality makes most sense to me.
> Because you don't really differentiate between the two in the callback
> actions.
> 
> Anyway, this is how I see it from here. I could very well be missing an
> aspect, of course.
> 
> Thx.
> 
OK, I'll put in CRASH_HOTPLUG! Expect v14 soon!
Thank you!
eric