Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <affc2b90-9410-1757-d9e7-6dfe2a3e5be9@intel.com>
Date:   Wed, 9 Nov 2022 15:10:36 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH 10/14] platform/x86/intel/ifs: Add metadata validation
Content-Language: en-US
To:     Jithu Joseph <jithu.joseph@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221021203413.1220137-11-jithu.joseph@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221021203413.1220137-11-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3ZCdnhYdWg4b2FGR2VFWFROQVY4Sk9FL0o4ZTFWQlJzZGlsU2hOT24zM3JN?=
 =?utf-8?B?YnprT0s2ZUswVTZrb09mc3pFNnZwTkFvaVF0L2o5ZmdWNUpjVlpUT0NUd0w3?=
 =?utf-8?B?Q0szQk5Nbm5seDRjY1BuQ1hRZEY2a3FIeFBxb3ZZYkMzajFxMmhXTUwvNFV6?=
 =?utf-8?B?M3VmSE5Tazd3NDVhYW1hR3ZVUnFXM3VVNE1tVWJub09nQjNhbU9BZnd1cjB4?=
 =?utf-8?B?WG8vRG8zbjFjYkNQV3E3R280NkoxOWoxR2xGaGQ1cUdiWm1LdTNKVXd3RzdM?=
 =?utf-8?B?L1pKY1h3NTdDZmthRzhCL0hvVUpSRkhZWDNGdjE1KzcwU1ZYc040bkZIOW1q?=
 =?utf-8?B?OXpPT0tkUUxlSzIwU2hKN0xjUUlyQ05rSGdESUh4VjVMcjFvOFZhTjFSNkpt?=
 =?utf-8?B?YnBHWVppbjRxSmM0RHRvUllGaUVqdFlFTGVZN2JSL1FlV0QwR1o1K0xGWXBL?=
 =?utf-8?B?ZDBoM3NZR2FZUS9qK3ROTVBuRkowaHQwaE5JOWdnTWErVm1QS0N1M3BlZ1p4?=
 =?utf-8?B?Zk9jaWdxM0prRHJ0MFh6ZTlXT29vU3BqWlc1Y1F1WTh5VHluZUZzRVRpU2Yw?=
 =?utf-8?B?eVVBc0RHK0pYL01Uc0dnUVlORUNZZkpZNXNkaFV1eHFOSjVUekZTTTVobW9i?=
 =?utf-8?B?enVMcFRvWHFOL1VuZnJWTWp6SnJ0dURrRUJpdDU0Z29KYnBPRGNLbGQ2cU5O?=
 =?utf-8?B?alBoV1FLVE5IdHUrSkVlZkptYWEvdFF2cXcvMVROT3kvMElnNHNJckpFWW1V?=
 =?utf-8?B?VVpIQW1LaTc5WCtsRlU0YkIyWWZjYnYrSXZJVkxqczdRamc0a21XNjZBR2Iw?=
 =?utf-8?B?VmlMRkJYVXE3UG9pQmRjLzY4MWNSOGZkM0dxRi9nSUd0TmhzdmM1TTdOeUVG?=
 =?utf-8?B?K1VGYThmZFphb0RHKzk5dnBsNkJjL1BkMTd3OXBFazd3ZjMwVmlhQ1RJU3R0?=
 =?utf-8?B?cS81eGQxYVUvaHFmTldMd1dtNk1GWXZqMzliRkJ0eWx2SEtHM0FXREJtNExC?=
 =?utf-8?B?ZWs4N2Vkc2s1cWhudmNwY0twL0dkUzROZU5QZ01McXd5eENIdVVyZUU0MWhS?=
 =?utf-8?B?b3JhMy9LaEpZOUNvMTRpeGhhbW9GZ1Urby95TGdva2xwVFNjYlhMcXVJYXBs?=
 =?utf-8?B?aHhJNUp1THpvbTJJcHA0M0twK3laaVkwQ2RtTUtBYjg3dWtaRkJSbTFRWEZ1?=
 =?utf-8?B?WWdzaGoycXcyWFNVZWRsUWFmZXdiQjNLRjBqZTk0REI0OXppOCs1VlNvQ3Mx?=
 =?utf-8?B?d3RHUHpGY3VUQjdMdVNEM1JqUHoxOVRFWW9kdmZTZ1drSG1ZM1BtaVRIMUl2?=
 =?utf-8?B?UEZacEIydEt6elFweGxnU2ZDeGd5cTNua0FaT0RVOWRqaTR1OHFUMGdyOG1R?=
 =?utf-8?B?eWZvZ2xaR1dMTm1VZFNCVnVXd2tRMFlLNXRYM05FRzVjS3AwdWFReUdkckhQ?=
 =?utf-8?B?bDJLQW5jTW13eE1mMnRoL0FpR242YXp4ZXRoNU54SXNnM1AyV0VKbHhCcVFa?=
 =?utf-8?B?dEVsam1DMzlMWE1wdmszMXh1SHZYODNidVBuYUluZXkyUVlOTmpMREhSOEp0?=
 =?utf-8?B?OFNBaEs2NmhDVlNDSDJoczBjMHBDelJrbno4VnVmUzRqWVlPd0l5b3I2RU1t?=
 =?utf-8?B?U3VuamRSUU0xUE1GVzVyV1pHWnNRSGUzTXA5REhuVGpjRXlsKzdRQTBwK2th?=
 =?utf-8?B?bkpqVmhOZ2p0SldrbkJGemkvUm1maVJ4bFFBZEMrZmVaenc3dm5OLzQ4MlVa?=
 =?utf-8?B?QTFwRS9QUnE2ZDc5dFFXbE93NStvTnBOL0RlL3RsSWphSWJZTXcxWml2WWNr?=
 =?utf-8?B?TExjTDF2VzlvVU1YaW0zWlpRR2M5NmxhVG5DUmhwS0daRk5IN2h0SGo2WmU0?=
 =?utf-8?B?aFFaQmRrcTE4V2pGOHg0OGVwblJNQklyMUVIdDhSM1h1cXhZTUdVbENkWDVr?=
 =?utf-8?B?U1NBT0VySEN3MXUzamhDcEhKanZFMk1DM09Vdk00WThKK2JlM2JZVmsxVWFP?=
 =?utf-8?B?dXpCQTE1QlA1L0JFUU1McW5PSFdaTkQ3eGxBNTFvSy9PbGh6YThXUG8zcnF1?=
 =?utf-8?B?TWJEZXpmekNEdEFNS0NST09IZmVpbEgwQkpZZHAxUGZyRS9Hd2J5cmwyRDU4?=
 =?utf-8?B?REJ5K0lrWUpiZXljNWNjSmFXVGhCRW1rYnh5UGxUQjBLeUNvSThSN0Y3anZH?=
 =?utf-8?B?YlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cfd63b77-e678-4812-a401-08dac2a79d60
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 23:10:38.3123
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JZ5P5AyK4WAe95ldkxIyutXrEAZlA5+X3SVBBYcbNmF3f5k78g+DqsMWLtCzTj97qFh6u4sqX5DIFDEIWTHmkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6140
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/21/2022 1:34 PM, Jithu Joseph wrote:
> The data portion of IFS test image file contains a meta-data
> structure in addition to test data and hashes.
> 
> Introduce the layout of this meta_data structure and validate
> the sanity of certain fields of the new-image before loading.
> 
> Tweak references to IFS test image chunks to reflect the updated
> layout of the test image.
> 

Can you provide some more information on the updated layout of the 
metadata structure?

Some parts of validate_ifs_metadata() like the ifs_test_image_ptr 
calculation would be easier to follow with that.