Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a0f6723b-ecfa-ba5b-5779-c7326cd31a86@intel.com>
Date:   Wed, 9 Nov 2022 15:15:37 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v2 10/14] platform/x86/intel/ifs: Add metadata validation
Content-Language: en-US
To:     Jithu Joseph <jithu.joseph@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-11-jithu.joseph@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221107225323.2733518-11-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2Rid2l4TmlQUFR6dUxVcUgxQ2tFaTYzVXl2OEZ0Q3hFMndMQjhPRWVPKzdu?=
 =?utf-8?B?ZVNzQXVEY0xtSlJqbEVNVVhpSUZSOEljMjYzZXpJaDQ0cjBlVmltTlJKRWFR?=
 =?utf-8?B?OU9jZ2lqMWZhVE83UzVhR1Z1OUpFc2F4YjM5Ky9zT1MwQkNOYkVLMG43RzJs?=
 =?utf-8?B?ZE05ZGZ6YjVvOHNwMFFDell0Z3huUEV2WVdxWE01ZlNHa05FVlAzTnhxaW15?=
 =?utf-8?B?K1V5VWxFdnpvWFFQclViVjdkdTJEaDh5WW43eHJXVmJQV3ZTWldBSFdLN2xW?=
 =?utf-8?B?OFV1RDRaYlhZUXlpOHN4czd0SjBlMWt1SXhpQnN6Z3luOUU0bWxINlRxSHpL?=
 =?utf-8?B?ZlNqa20zYUkwalk1SkFCK29Vek83NlgzUzVKUHFqU1dPWWRwTHVYc29jUWpy?=
 =?utf-8?B?WFI3Q0pZeUhIM21xUUhEMjdaSE1zQ1NVa2IzYitVc1c1VmVTVWRKNGgzM0ZY?=
 =?utf-8?B?T0lTdkEyT3FoeG9vUmxMMkE1U1d4WkFtTWVRMi9TL0xITVVpSTczc1FrWW9Q?=
 =?utf-8?B?UitoUnF6WDZ3aU1nY3B1NUZBUkJaSmVkUDNmOWhxcnJ2VW1GOU84bGhUZjN5?=
 =?utf-8?B?UDB0RFI3cjVQWGQvdmRjZjBBUzRxajNmMkRsL01IS050NnYvMS9tQ3VVSnRK?=
 =?utf-8?B?c3FzcWVvZzJDcFllS3F1VTFObWhmN0t2VE1BREs1UEFJYzk3Nm1FMFBlMXVy?=
 =?utf-8?B?M1NkcURNZWtuazlpZWtodWlhQk9mckJQN0QxM3l5QllQZGFjOFVldzVQQThK?=
 =?utf-8?B?TUpPWkttZkNJTTFJWHVRb0E2N082SXhhOUFsZXVqUGtEVU80SVNOTWxXWjZO?=
 =?utf-8?B?aGJQdm4raEZPaGhIczRNV002STdOWHl6RG1ncXJBK1RQMFIzY2tLSjYxcEJB?=
 =?utf-8?B?RTM3ai9YZ003R3M5QndVMmI0Q25zZmRJb2JESHZLbFpMUENTdTFlUkRGRUpl?=
 =?utf-8?B?cmhOaHJkVmJWZzBzQ2ZUR1NCUVg4a1JDTXJWdkN0Z3hpMU9XSXhEaGpEZHVT?=
 =?utf-8?B?SUFXV1J3SkV1ZXJEdEhISVN5MlcxNDV0cy9TbUVFSSt3aUxkS3p1eFlGMnp4?=
 =?utf-8?B?cVVDbWdGZkRCUWhYaHFpRUhxTTdXNFQrSEdnb3V5UGoyQ09IQ05pSk1vYm9n?=
 =?utf-8?B?ZTBwd1FQQVFyQmFwQ2xjMmF0RG1sVEwvU1B0UzZHdnZJSlRIVVFOWjg4LzNP?=
 =?utf-8?B?TVFSZ2ZEMWRkL2l4U011Vk1qSjBmaS8vRC8xSW5HODRlUFdGR1ptdys4UTBC?=
 =?utf-8?B?eXZlMFdzUnVjV3JPSmR5WVJhQjN3dUxINXNqSzY1ditROHNkY0NzK095eDdF?=
 =?utf-8?B?RGo1Mk1PU1RlVTlsdjhvSkxLcmg3T1FwN0NBTU9ldWxxVFl6bEJ5ay9RdVVU?=
 =?utf-8?B?cm5JSzI3bm1LUmpKdHM5MXJPU2ZINmp3eE1DOVYwQ2djZ3poeGZoZHFraW91?=
 =?utf-8?B?ejFrY3RJVnc1Znk4VGlSSlRBY1hFS1VZWmhGNE1Sa1dHOG8rcTFqazZrR3Y2?=
 =?utf-8?B?cmxWQ0t4ekpka0NGSmgxOXBrZDNjZlBtTUd0Sk1rS25mUlZzUzlzSlNkNGRB?=
 =?utf-8?B?NUJicVprYndTcVRra0x2OHU4a2twald6TUhZZ0NHUEVqYWRFYXZhUzhHVHBF?=
 =?utf-8?B?bldZNEJLOWFCNUxWYWVLQWtrczdzbUVPN2VzUTkvaVljN3BValpyMDFVdmJs?=
 =?utf-8?B?YVpmZlBNbE9qaHB2MWlWclZJQlh0MkxwTFVhSGdxQ1U5OXJnRVR3YUxOZElN?=
 =?utf-8?B?MW5CZjZlOUx0cVF6cUYreUx3RHFqR0NIRktnUGJMZ0UvZlZHVCtsdG4rTDBy?=
 =?utf-8?B?bXpnNm1RMlQ5WXlsOUlOeWZ3RjZZY2NXZUZGUDYrb05HVUMrY0FlNGpUamxn?=
 =?utf-8?B?SW5vRnEvazdDQTZtUkFRUUhwaFBqQVYyNjZVRko1RlhvWWkrNGgwdDZ1V3Ju?=
 =?utf-8?B?VHZmZUpyTC8zVEdUS2xiZGZtek1PM0cwQlZZWkxMMVkwM3JvVS9xNjFqTzlR?=
 =?utf-8?B?RS9hQVhCYit0UTV3VXZVTEE0azZvVEtsb1ZOa05PMVJVWTNpQjlnVjFSaW5G?=
 =?utf-8?B?RjI1ZHFzRkJ4RlZ3WVVTaGE2SnhwcVpkSTVLLy9hZWcxbjR1Wm5tbWRydERk?=
 =?utf-8?B?dEtpclBZcURBU1ZJRTZzT1hxUnVuKzJsSStFKzI0YW9aVUhrRzB5cFp6TjJo?=
 =?utf-8?B?TWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 714b2e5d-0e2a-4587-711d-08dac2a850a9
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 23:15:39.5547
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t7kCJWShXJUQQfzER9sXnipKNLonQL8kkDT193HKXPeQMc8XHlo+jTc2dnNX03t3em5d/6/rH9KgmFVuZiSd3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4652
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Jithu, I replied to the prior version of the series by mistake. 
Duplicating that comment over here.

On 11/7/2022 2:53 PM, Jithu Joseph wrote:
> The data portion of IFS test image file contains a metadata
> region containing possibly multiple metadata structures in
> addition to test data and hashes.
> 
> Introduce the layout of this meta_data structure and validate
> the sanity of certain fields of the new image before loading.
> 
> Tweak references to IFS test image chunks to reflect the updated
> layout of the test image.
> 

Can you provide some more information on the updated layout of the 
metadata structure?

Some parts of validate_ifs_metadata() like the ifs_test_image_ptr 
calculation would be easier to follow with that.