Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1826887b-dfad-30a2-16dd-412e5556cc84@intel.com>
Date:   Wed, 9 Nov 2022 15:46:07 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v2 12/14] platform/x86/intel/ifs: Add current_batch sysfs
 entry
Content-Language: en-US
To:     Jithu Joseph <jithu.joseph@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-13-jithu.joseph@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221107225323.2733518-13-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NG1qU0VoZVFYcEZQam5icjc3b3ZLZHlmUWFSV3F4VWNrZTMvNFpyZEJ1cU5Q?=
 =?utf-8?B?d3A1ZU5PMVh3Z3dab3FTQmEyNStsZTJoYUNneUNIdENRM1E1WFhqNFJLWjFm?=
 =?utf-8?B?TmRzNzBGS21idGYrNzlzZVgvSzdnR0o3Wm5aS1MvbUdEekF2VUtYdGxZVVRp?=
 =?utf-8?B?Y3dya2N3SWxnR2QyRGlFMlVySTJ2MWV3dXBXWEN3b29pMEg1a1d6VWJZWlRG?=
 =?utf-8?B?VEkzSlBBV215NlYyMUptaDhNM1RyVU1xQ3BxU3ljWWpoSHZpR0pvR3UrMWNQ?=
 =?utf-8?B?blNQeURxR1VnYnZZQ3k0cjdXbXk2WHo2aWZmZDBZQlZYcGpCc2VONU42amNW?=
 =?utf-8?B?T2JuL1lKdGF6NU93bXZndzNIdWYxVVZUL3ZIRk5DSmZXMzdvUTlsaENQenF2?=
 =?utf-8?B?b2ZNZFVONnRMSXUxdnpqeE0wM1hIcXZWR3F1SnBaWHMzS2xpeXVkdGE1WVV5?=
 =?utf-8?B?NktjRGUzWnhudWFBKytyZUE1THNvNFRFTVJ5U3VoNFBtaVhvOWxCYnFpWWRM?=
 =?utf-8?B?L0E0aUNiZXJEa2lUN0J2WDd6TkhuQmd5WSswMmlJUlJFeGFzWmU5eWhLMmtx?=
 =?utf-8?B?Q2lyT2IzT1Y3YWxveWZQNEovNmdlb2RBY0drZjAzeUVoem42SHRySzFRWXlX?=
 =?utf-8?B?eE5FV3BQVmRUWFQrZXBtTU5kZXkxck5lYXh3TURrZkc5TzB4QmlWZGdZWk5z?=
 =?utf-8?B?cXp4SEQyeWpHUzYwb3FJcGh5Z2JEbXN1c3ZiNTQ0cnlJSnpFYVp3RGhMbVM5?=
 =?utf-8?B?SkdUZVdQeWNKL3hTMDZYam5oNEpsZGMzM2NBTlplV1BKdEtPV0FzS2h5OEl5?=
 =?utf-8?B?TTJ0NDhBMFNBVDI5R21RMVNyRjZteEpIbWp5TXlQNzJJWCsrRmJ3TjA3ZnBG?=
 =?utf-8?B?bXJicHYwZFZrNDhOeEZZYjZBQ2JuOW1ucHVkWXJwUjJMcCs0QlE4TlJaa3FD?=
 =?utf-8?B?L1QxdHpmOHdHUXJJRkJrSHEwRXVxYkpGdnRiMFZEdE8xenFucUtVSEg5Qjds?=
 =?utf-8?B?SzNDSjloTEhROHlsaDVFQVZHY1FuSmZ6dHo5UTl0WnpORGVhL01lNXdhRWZo?=
 =?utf-8?B?bWxnemt0VVdIYkFuQkNkeDcrOGRkcnNIK01BaGtNcnpmYjFySS9EZzA4L29v?=
 =?utf-8?B?Sm8ybWtpZVRNMzFpVkpqTnAxeDF6Yk1ORGdvemsvODlWTmJ6U0d0ZHVXUHdF?=
 =?utf-8?B?R1J5VXhDd01DTmNCYm5FaUVDRXVEVlVyS0gvem9nbmRuYmNBdWtRNE1VM1Fx?=
 =?utf-8?B?YTNjZS9SL3pmOXJOZFUzVFF3aW5Qd1V3WDUvaVB0Z2p1dWNCWjNoNUlZN2hN?=
 =?utf-8?B?NlNCNUNRYSsxUXNVYlJVZGZsZ1FwYTJMSCtaL2hXaHJvVXg2K0hmWncxY25G?=
 =?utf-8?B?cmRrTW5uSWo3ckZKUHptR2RhV1k3dDFoeEN0bTIyNHBqM2syVDNvWWJOaHk4?=
 =?utf-8?B?MHBHQWVTcnFtM1VHeUJNTlFWcFNmMlRqYm5HUHZDWHZtZEZRYU5XUWEzTjJN?=
 =?utf-8?B?U2NmYm5zcW0waEJXdXdjVjd1SzUvbk1PM2wrcjN4Z1d5VXlGQXVwTHJockRv?=
 =?utf-8?B?aGdpOHV6bVdXcG5pV2dkSisxUm9hR1hERDAwNVdnc054NkhqeFRTM0tXbHdW?=
 =?utf-8?B?UjFlMmF4ejlsd3cxVitxVVNTZkE1UUNJZ1dRd2U2cjd6VnhINDNwUDhDb0FW?=
 =?utf-8?B?dzM2MmFOdE53TG9lU0RyQ2NJVHdZVnZ0ZUlkKy9EZXQ3d3pubnFFR25EdWcw?=
 =?utf-8?B?TjF5T2NDL0E1dmJKTDlMN2NkdHNNMDRhTWNYT2NINHhITUtzWWNWTWlMOVB3?=
 =?utf-8?B?UFRFZDBrZXcyK1ppR0REcXlIOXd4SXNqVzNJck9peUpwdmh6b2VLYnRkdTJv?=
 =?utf-8?B?SEZSOEY4S2F1VlE3dzFUNGNRUk9qTkIvaFhNVFZ3ZHhvZElaZ2dyaURSOC9t?=
 =?utf-8?B?MmVsM1lWZEdIQytBMEFLWVBtZVpXWU5LU3c3SHdlUjJlTVhMN0Q1ZmtaRThW?=
 =?utf-8?B?Q29RaTNzS1lDL0Nya2tTQlJJZWE1bnVzdTJVcmdDQlRXTmdNc2Y5Q3VWazJW?=
 =?utf-8?B?SEFGN2ZrSUhNdzlHazNmT242aW5ORFVJUnFYZTFweUI0cHZkMVlCM043WmRU?=
 =?utf-8?B?Sk1GZHJKYkFtcnlYdXZTRXAzQWZGWmZMU2l5S1k0YnpyM0VCeHBGTmVRNTZ3?=
 =?utf-8?B?VEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b1cbf56-a03e-4b6b-731b-08dac2ac938a
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 23:46:09.3865
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4ZOsvq53ORa5MCl4iP+SwlspfnF8ot3h6S/HFu2Ntu+QBsZQGDfeRBYeRcVY+1w0Jle2DfPHUnwESCHKapGdQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6230
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/7/2022 2:53 PM, Jithu Joseph wrote:
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
> ---
>   drivers/platform/x86/intel/ifs/ifs.h     | 23 ++++++++++----
>   drivers/platform/x86/intel/ifs/core.c    |  1 +
>   drivers/platform/x86/intel/ifs/load.c    | 18 +++++++----
>   drivers/platform/x86/intel/ifs/runtest.c | 10 ++++---
>   drivers/platform/x86/intel/ifs/sysfs.c   | 38 ++++++++++++++++++++++++
>   5 files changed, 74 insertions(+), 16 deletions(-)
> 

Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>

A Nit below.

> +static ssize_t current_batch_store(struct device *dev,
> +				   struct device_attribute *attr,
> +				   const char *buf, size_t count)
> +{
> +	struct ifs_data *ifsd = ifs_get_data(dev);
> +	int cur_batch;
> +	int rc;
> +
> +	rc = kstrtouint(buf, 0, &cur_batch);

Should this be kstrtoint() since cur_batch is defined as int? Or maybe 
it might be better to define cur_batch as unsigned int to avoid the 
negative input?

> +	if (rc < 0 || cur_batch > 0xff)
> +		return -EINVAL;
> +
> +	if (down_interruptible(&ifs_sem))
> +		return -EINTR;
> +
> +	ifsd->cur_batch = cur_batch;
> +


Sohil