Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <503ba3e8-f060-002d-846a-8dec7e84c83b@intel.com>
Date:   Wed, 9 Nov 2022 15:55:04 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v2 13/14] Documentation/ABI: Update IFS ABI doc
Content-Language: en-US
To:     Jithu Joseph <jithu.joseph@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-14-jithu.joseph@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221107225323.2733518-14-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bStneE55VEVNYnd4VFdkRC9VVGxlNTJveFJHV2R2a1RIR2lIVG01ODFlcEk5?=
 =?utf-8?B?dzlCcjNxbitWeTBKUm1UYUJTUTlPMzVhTE5tYnZWTGMreDJUVHRkV0lYTnUy?=
 =?utf-8?B?VFVTTC9RRGtYVFQvK2dIQ0VIdjY5L0ZKcGswUjQ4ZHI5NC9oWFRIQTlwSzJa?=
 =?utf-8?B?NUtDNnNQZjd2RVdzNlZSVTlqd0xkVmdUcTdEK1F4U3BkLzJaWURxYXo5T0du?=
 =?utf-8?B?T1RxWW1Yb3ZPanJlcXNUUklTa3dGdG42Y29yNWhkUmg1STFQemVzMHNLZzA3?=
 =?utf-8?B?cnJUd3ZzdmJLaTJ4anppVFcvaTZ5MVR4MS9Fa2VKWS9pMTludG9MQ05BRmd1?=
 =?utf-8?B?WkVBaXZqd3pJbDlBeG0wOCs2K3BLU294Ym1tK0pnUXFBVzhHQW5HVVpraTRj?=
 =?utf-8?B?REVEN2lscU9QajdKRm5nRE1mOTB4SFFLSno3ajJiWng4U0ZaUVJyZENCZktp?=
 =?utf-8?B?aTdLdWl4RmpleFdZVzJqY3JraitFODJlZlNRckpHSlRiRGQ1b2NhYlhRWDYy?=
 =?utf-8?B?eW1BVms5ZGExeHYvUzRsY1Z4Yk1ZaUkvLzFONGpyWDRLU0RRWGdlVWtXU3BS?=
 =?utf-8?B?cU5PVlNGSTVGNmsvUVBEeXlhMFNqdk9UdFRkQjJMdG10ejNvZURaS2F5NUNS?=
 =?utf-8?B?WldqM254QWRCeTZVMXRkRE0zeTFiRElycUh4QWhFYkcrZWtSbUtYVm5zaWww?=
 =?utf-8?B?eU04YTBFRmk3a3hVUDNFVEFjNytUcDFTZkdQM3EvRk50YWhxajVTc29rNEE2?=
 =?utf-8?B?bWVYK3VXU1VvOURENEJ6WjhyamRGYzZBRm5zTmdUcXBza1BtUTdUUXpVVnZU?=
 =?utf-8?B?bkRudHFnMjF5a2x1N1Z1NUJPOGxDam9ZbWxVTGxVUk9lOGFjVnlWWjVyNEE1?=
 =?utf-8?B?UnZpOUxGQjdRamxRbGtQSjgwWjdXeE4zaHFKM0wzNG9WaXJraWxybnQ5U0hF?=
 =?utf-8?B?ZVRodW1zRndHZTRZcXlka2FZenhsUlNsTlYxVmFBNVVzc3FJVWFkbWdzVkc4?=
 =?utf-8?B?VzFZb2syeGRIVmJYdm9ZWVFsTU9lSCtsQWlNeDhvYXNKTkc0M05UZ3pZSXdP?=
 =?utf-8?B?NEgzMFdZcUJydnFPeXp5NEhCSml3R3dVbmYvNEN0M0d3LzRKOFpoRlFwVFRR?=
 =?utf-8?B?VldCWnlMVEcyTWVyZi82VWxKYzlwQzRSdldqSklBY3R5V3ZxaHMzRTdrSTBV?=
 =?utf-8?B?UkdhUUZ5RGVxRm5IZWExSE91VW1tdUlqRDNJa2UvSEphYWtibDlTMzB4NkdD?=
 =?utf-8?B?emMwOElveTRhUlFNRzNOcGN4cm1Sek93bXJZZG5uUjJZQjdIZ3lNMlVFREV2?=
 =?utf-8?B?b0gyaWo5UkIrY2Z1SEFrcTlXVENuTDFjUWgxQlREZ3Ywell2M25IZ2t0cndk?=
 =?utf-8?B?UjU3VnhrN0dtSEtiVFdxcVJaTGNicmZtSjJtVHhZTlhHTllPSHF0eXo0NXln?=
 =?utf-8?B?a3h2Zmh1WEhzTHhCWDFMaGp1OTY2ZXlZSGh3M1FEUWN2YmRsdTdZWVhKSDJU?=
 =?utf-8?B?WDRjeXE0VmIwQmtUY3NFZnM3QXNxNzJLTVh0UnlqTlNvSmhjMEN2QzBQWGZ2?=
 =?utf-8?B?aCtqZFJBeDA3VHM4ekxxTlkxRzc3dVFqVE1zQ051b1BMVVVOVjN2RkdYUmw4?=
 =?utf-8?B?NklMMGdzZzU4clhYWEpBWFVsMlNkd1gwUWdPdlJmRVJiMUQ1WHZ6QmkvSkpl?=
 =?utf-8?B?ZHcrQmhranBLSmV6WlRhK3dMSmN4U0NhVkc3c2JxR3NneEJrajhqaktJaVlv?=
 =?utf-8?B?bEFvS1Bsb0g5cFFxaGM3Vkg0RHVoTFNvRTdSY3lnWUpKcTVIcm0yQnRLVWpv?=
 =?utf-8?B?a3ZtZlBQRkRHVmRQMzJnVWs1YWFTYTFvUTYwRm0xcThubElDdUVEczUweXNY?=
 =?utf-8?B?bGhsdGNnNVh1eVRYZDkrQTd2ajVHa0FWV3U3WnVYcnVGWWVCaVcraEFnUWdS?=
 =?utf-8?B?UVVyQ0VPck93OGRieUNlbVNDNkllQUUwcEhzQTBYSk55dnc4cWJHVGpZaEN1?=
 =?utf-8?B?NVB6dVBSQ0xOUWZRUHZKSGgxaXk0U2pvYXJmQk9pbDVzbHFRcnB1RzRKbmVq?=
 =?utf-8?B?OFJHSjN0bVRad3BYVlc4U25wRHA2TGZyZjFrZEVmLzlqR0hwZjlEZ3BaUlpG?=
 =?utf-8?B?OGF0ZDNud0xkNENVMk95RVEyVnhNM012c1d5UGdybXJJd281SjVMMWtpM0VW?=
 =?utf-8?B?U3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 126cbaf9-8067-402f-3be4-08dac2add403
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 23:55:07.0646
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0oAfKGB51VAekMX19UKuXnFkmZNX+7/J6tJZfJqAEWTTMmSbWdAEza6M52ulYKPtp4bfWyrAmdj9hRR8esigyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6330
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/7/2022 2:53 PM, Jithu Joseph wrote:
> Remove reload documentation and add current_batch documentation.
> Update the kernel version and date for all the entries.
> 
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>

Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>

A clarification below.

>   
> -What:		/sys/devices/virtual/misc/intel_ifs_<N>/reload
> -Date:		April 21 2022
> -KernelVersion:	5.19
> +What:		/sys/devices/virtual/misc/intel_ifs_<N>/current_batch
> +Date:		Sept 30 2022
> +KernelVersion:	6.2
>   Contact:	"Jithu Joseph" <jithu.joseph@intel.com>
> -Description:	Write "1" (or "y" or "Y") to reload the IFS image from
> -		/lib/firmware/intel/ifs/ff-mm-ss.scan.
> +Description:	Write a number less than or equal to 0xff to load an IFS test image.

Can the number start from 0 or is it expected to start from 1? It might 
be useful to mention that if there is a constraint.

> +		The number written treated as the 2 digit suffix in the following file name:
> +		/lib/firmware/intel/ifs_<N>/ff-mm-ss-02x.scan
> +		Reading the file will provide the suffix of the currently loaded IFS test image.

Sohil