Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e5bd10cd-eb86-3a70-a0fe-21ba49b5ab25@oracle.com>
Date:   Wed, 9 Nov 2022 16:11:19 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH 1/3] mm,hugetlb: use folio fields in second tail page
To:     Hugh Dickins <hughd@google.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        "Kirill A. Shutemov" <kirill@shutemov.name>,
        Matthew Wilcox <willy@infradead.org>,
        David Hildenbrand <david@redhat.com>,
        Vlastimil Babka <vbabka@suse.cz>, Peter Xu <peterx@redhat.com>,
        Yang Shi <shy828301@gmail.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Naoya Horiguchi <naoya.horiguchi@linux.dev>,
        Mina Almasry <almasrymina@google.com>,
        James Houghton <jthoughton@google.com>,
        Zach O'Keefe <zokeefe@google.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
References: <5f52de70-975-e94f-f141-543765736181@google.com>
 <3818cc9a-9999-d064-d778-9c94c5911e6@google.com>
 <5bd8a365-e2c5-a721-1257-81ec4ae0c626@oracle.com>
 <3934b34-ae2f-2119-9a68-33e51e909795@google.com>
Content-Language: en-US
From:   Sidhartha Kumar <sidhartha.kumar@oracle.com>
In-Reply-To: <3934b34-ae2f-2119-9a68-33e51e909795@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejJ4NEhsV1M2bm1TUi9IaDRQRmhmenNONDNpRklPeDlkM25NaXowYThZaVdU?=
 =?utf-8?B?WDJDYngrWkQxSE5kYlA0ZFMrMWsrbWF0R0hwaWF4cW1NWlZhc1JYWTFuQndU?=
 =?utf-8?B?Rkp3TmxGcGhwa1EzWjRRcEZRWktPWDlzVGZoTEdyU0szWFkwUEo2WUpLbmZ3?=
 =?utf-8?B?a3Ftc3pxY3pjVVI0UlJkbDRhRFhaYjc5WXZxdkNkUHBTVmhJN1FUaElYdEd3?=
 =?utf-8?B?byswVy93aFZYMjloOXNrSWpRa3c3Q3FXZkV4aGhXdW81N1lPZWRBZXA2ZDla?=
 =?utf-8?B?M1V3N21waVF1bGx2cmwvK1JFTE5sVkc3TWI3UjRoOHBhZTBoOWdXeTRUNDIw?=
 =?utf-8?B?SkQyUFlXRmd5b2dVVWhsSGxkRHpETzBWKzFmSjB0NFZBOTFpRnQrVTJVdDlZ?=
 =?utf-8?B?bGlnTGIxczJlU3diRi8rL0Vsckc1RmZjU0xWUTBUVy85UnlRbkduS3VWcVpJ?=
 =?utf-8?B?am4wMzk0ME9zSmhTelkwQnFVT0tpVTRyNDZWT0cxUUsyamxFWFRIK2NzeTNM?=
 =?utf-8?B?OHNPSVBnaHhpVFlWNEN4Z1NFb2VJREE5RCt3eU0wQzZxdVYreGUwcExIdlho?=
 =?utf-8?B?NEJ6WnJXMVRkUkFzOTMySFFWN2RwNTlCVlRCWW5JdzcyTnhTeUFLbGw0UEtq?=
 =?utf-8?B?VHpBUTNnb0IrMXF0b0l5SE1zQTRoZE9tUUFIUENXZUxKUE5XU29JWU81NVl6?=
 =?utf-8?B?OUI3MzRBYVgzYy9rdnpGc3VMOGZ6Z2hzVHVLaXpkUjBpcStFeDRJeEFyd1Vm?=
 =?utf-8?B?LzVBcmd1YzVxT1RkbVlkRHNmSVpRck9TcUMwUWx3b21acGlacm1STVMwTWE5?=
 =?utf-8?B?YzlwWnRnclVzRUg1Y1RmMDFGK0hmYUQzQ1NxZG4wYXBsalFpVjVXTnhlV3Yy?=
 =?utf-8?B?UW44RjlWTWNRQTNzRTRranlBcWtvRWlIa1NqWFdqRXRoM21EMzVhY010Mnk5?=
 =?utf-8?B?czZXMDAxSnFpWGhOVFF0RzB0eDVBakZSMWhzN1ExbUNIcm43ZSt1YXVCSUh0?=
 =?utf-8?B?MUxTeHFZaE9MZlhFa0xHUlo0bWY5L3JrK0xxRWpvTnVrRXVIdEhqLzAxK05J?=
 =?utf-8?B?dGhYOFNWUlZpRFM5VDR3bXVDOFhwQVFtWjZ0N1hGSXd3UGJmNVpVTXRFZ0NW?=
 =?utf-8?B?TS9MZkd2L2ZYNzFWM09iR1ladGl4ZnJhQUQrYUZhWkNQbkwzY2pzQUF0WDZq?=
 =?utf-8?B?U3M4WGJUUk93NXowWjd3WkIxbVB2enkzR2ZaTncvWUhQZWNKQzlRUkJydzBs?=
 =?utf-8?B?RUF5ckFNckVPRzFBd2xZaWJRY3VUS001QkN4bVcycWJHTW1qV2RQWGlkTW1m?=
 =?utf-8?B?QmxraDA4aFRHNmUzRENnbk5BK1RZK2ZqenZscmtWbXMwM0hXYUY2UFlqS2V6?=
 =?utf-8?B?V1hsVnFXMjVGQU5zYWo3T3M1eWtUTGFmRWdxN01MZmxKWFNCVVpEcXlHdHh3?=
 =?utf-8?B?ZGozNUIySnRXUjAreFVTNVVyV01qSmFXS1FhRmZOeFU1UlRBWUczSHhVRWkx?=
 =?utf-8?B?N2NTWExWQW5kMUpQbksybVgrUCtmbzRiNUh5VUpvQkU1MStpZ0VmZjRqU2Ev?=
 =?utf-8?B?M2FjZGwvUXdwQ0RZT1lqY1E0UDA1bnBPbkFBbnpXWGY4c1duSm9FVlk1d0N6?=
 =?utf-8?B?Rk5QZnNKUXBBMTNHMUhvRWlnZzV4aFpsSkg5WXMza2xTdktpQ1lMNkc4Qzdj?=
 =?utf-8?B?U0V0d3JYMmtwSzlyYWluK29NL1hDL1Q3TXpQcFdnRjVmUkhQSzVVdkVzYjA0?=
 =?utf-8?B?bXkrRjExMFJHdGJJUEpsM0p3K2tiaGpiUEdMenJhbVQxUmJsVDBXcStnZGFv?=
 =?utf-8?B?VGY3eEVKdGhKbzJsdFJ6OWxDVHMvNU5mZklIRDE3Z2c1aFBJUFBYMGdoUVZW?=
 =?utf-8?B?YVZHUDBVendoMnRIOGNpa0FJeURsVzJINHlFK1BSWkhFVGlnek5takRYR3ZQ?=
 =?utf-8?B?a3drL3Z4VWxWdGhjQTNvMFptaDZFK0N0SWhTWjhpMnlwaFViRVJLQzMwRHlQ?=
 =?utf-8?B?d2U0bVJJWmRtNi9TMmE4a2x3R3pqWUtqcUdGK2tUV0xmdnFZQ28vNy9tK0cz?=
 =?utf-8?B?aHppZjhVSHZUSWhZRC95QXFmWDU4NXpobWFkVy9aRFlxem5mZG1HY3RvNStF?=
 =?utf-8?B?ZlFCbVNRNDljblJrS3dkamhtV3VIRnpwVVNWSmcyM0UzU0J1WEIxNVlqaytY?=
 =?utf-8?B?TXc9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 672f638b-fef9-4e83-42a9-08dac2b019a4
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5113.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 00:11:23.3916
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q6BO/F+UJ9fGpo8MF1DF/HaXTXUuSqj7BLb1DQnwPhFBFP3KALIzvTPQ/E7Qlmpc6phpN2kDymvMDhZg7y0IAa+EhrRA57fr0yign84MCNk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4837
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-09_06,2022-11-09_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 spamscore=0
 adultscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211090181
X-Proofpoint-GUID: adsQygpsUqanpMpvoNbSViSsQtW7pPBj
X-Proofpoint-ORIG-GUID: adsQygpsUqanpMpvoNbSViSsQtW7pPBj
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/3/22 9:29 PM, Hugh Dickins wrote:
> On Thu, 3 Nov 2022, Sidhartha Kumar wrote:
>> On 11/2/22 6:48 PM, Hugh Dickins wrote:
> ...
>>> Undo "mm: add private field of first tail to struct page and struct
>>> folio"'s recent addition of private_1 to the folio tail: instead add
>>> hugetlb_subpool, hugetlb_cgroup, hugetlb_cgroup_rsvd, hugetlb_hwpoison
>>> to a second tail page of the folio: THP has long been using several
>>> fields of that tail, so make better use of it for hugetlb too.
>>> This is not how a generic folio should be declared in future,
>>> but it is an effective transitional way to make use of it.
> ...
>>> @@ -260,13 +267,16 @@ struct page {
>>>     *    to find how many references there are to this folio.
>>>     * @memcg_data: Memory Control Group data.
>>>     * @_flags_1: For large folios, additional page flags.
>>> - * @__head: Points to the folio.  Do not use.
>>> + * @_head_1: Points to the folio.  Do not use.
>> Changes to my original patch set look good, this seems to be a cleaner
>> implementation.
> Thanks a lot, Sidhartha, I'm glad to hear that it works for you too.
>
> I expect that it will be done differently in the future: maybe generalizing
> the additional fields to further "private"s as you did, letting different
> subsystems accessorize them differently; or removing them completely from
> struct folio, letting subsystems declare their own struct folio containers.
> I don't know how that will end up, but this for now seems good and clear.
>
>> Should the usage of page_1 and page_2 also be documented here?
> You must have something interesting in mind to document about them,
> but I cannot guess what! They are for field alignment, not for use.
> (page_2 to help when/if someone needs to add another pageful.)
>
> Do you mean that I should copy the
> 	/* private: the union with struct page is transitional */
> comment from above the original "struct page page;" line I copied?
> Or give all three of them a few underscores to imply not for use?

I think the underscores with a comment about not for use could be helpful.

Thanks,

Sidhartha Kumar

> Thanks,
> Hugh