Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Nov 2022 16:23:48 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Rong Tao <rtoax@foxmail.com>
Cc:     Rong Tao <rongtao@cestc.cn>, wuchi <wuchi.zero@gmail.com>,
        linux-kernel@vger.kernel.org (open list), linux-mm@kvack.org,
        Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH] radix tree test suite: Fix uninitialized variable
 compilation warning
Message-Id: <20221109162348.3dbde3a7942c303af012276c@linux-foundation.org>
In-Reply-To: <tencent_DF74099967595DCEA93CBDC28D062026180A@qq.com>
References: <tencent_DF74099967595DCEA93CBDC28D062026180A@qq.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed,  9 Nov 2022 22:34:25 +0800 Rong Tao <rtoax@foxmail.com> wrote:

> [PATCH] radix tree test suite: Fix uninitialized variable compilation warning

This is not the test suite.

> We need to set an initial value for offset to eliminate compilation
> warning.
> 
> How to reproduce warning:
> 
> $ make -C tools/testing/radix-tree
> radix-tree.c: In function ‘radix_tree_tag_clear’:
> radix-tree.c:1046:17: warning: ‘offset’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>  1046 |                 node_tag_clear(root, parent, tag, offset);
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> ...
>
> --- a/lib/radix-tree.c
> +++ b/lib/radix-tree.c
> @@ -1029,7 +1029,7 @@ void *radix_tree_tag_clear(struct radix_tree_root *root,
>  {
>  	struct radix_tree_node *node, *parent;
>  	unsigned long maxindex;
> -	int offset;
> +	int offset = 0;
>  
>  	radix_tree_load_root(root, &node, &maxindex);
>  	if (index > maxindex)

Are we sure this isn't actually a bug?  What happens if the tree is empty?