Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221103180120.752659-1-evgreen@chromium.org> <20221103105558.v4.7.Ifff11e11797a1bde0297577ecb2f7ebb3f9e2b04@changeid>
 <202211041135.EAC889BA08@keescook>
In-Reply-To: <202211041135.EAC889BA08@keescook>
From:   Evan Green <evgreen@chromium.org>
Date:   Wed, 9 Nov 2022 16:29:35 -0800
Message-ID: <CAE=gft5Tw-iX8M1zWc419X-mwYTYvxZJiKxR9Q1He9dY7A3C5w@mail.gmail.com>
Subject: Re: [PATCH v4 07/11] PM: hibernate: Add kernel-based encryption
To:     Kees Cook <keescook@chromium.org>
Cc:     linux-kernel@vger.kernel.org, corbet@lwn.net,
        linux-pm@vger.kernel.org, rjw@rjwysocki.net, gwendal@chromium.org,
        apronin@chromium.org, Pavel Machek <pavel@ucw.cz>,
        Matthew Garrett <mgarrett@aurora.tech>,
        linux-integrity@vger.kernel.org, jejb@linux.ibm.com,
        zohar@linux.ibm.com, dlunev@google.com,
        Eric Biggers <ebiggers@kernel.org>,
        Ben Boeckel <me@benboeckel.net>, jarkko@kernel.org,
        Len Brown <len.brown@intel.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 4, 2022 at 11:38 AM Kees Cook <keescook@chromium.org> wrote:
>
> On Thu, Nov 03, 2022 at 11:01:15AM -0700, Evan Green wrote:
> > [...]
> > +config ENCRYPTED_HIBERNATION
> > +     bool "Encryption support for userspace snapshots"
> > +     depends on HIBERNATION_SNAPSHOT_DEV
> > +     depends on CRYPTO_AEAD2=y
> > +     default n
>
> "default n" is the, err, default, so this line can be left out.
>
> If someone more familiar with the crypto pieces can review the rest,
> that would be good. :)

Eric and I emailed briefly about it a couple weeks ago, he said he
would try to take a look when he could. I'm optimistic.

-Evan

>
> --
> Kees Cook