Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6b98f0ef-8529-43eb-1774-ba81c0bb0839@intel.com>
Date:   Wed, 9 Nov 2022 17:22:54 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2 10/14] platform/x86/intel/ifs: Add metadata validation
Content-Language: en-US
To:     Sohil Mehta <sohil.mehta@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-11-jithu.joseph@intel.com>
 <a0f6723b-ecfa-ba5b-5779-c7326cd31a86@intel.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <a0f6723b-ecfa-ba5b-5779-c7326cd31a86@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEF0YXlSTC9YdE1UeHFaR2NPUHhNbFBSMlM5U01OdXQ5RUtLS21CWTlXMTVV?=
 =?utf-8?B?N1RMYjJDZTZaaHd5dXBKNUIrZEtVUzZ3QXhlYWgvcFkvRWp0OGlXYkFxcDhy?=
 =?utf-8?B?T1E4d3c0MGltUk5peVYySDZSVVJDc1lWSHpaYXRBYU5SbDZ6QUdsS2t3bzRR?=
 =?utf-8?B?aGJ6UzZVcTJkZCs1TytXTUIzYjl3UDhwMjg1SVBKOTd4Tmw1TmRPRWtkM1N4?=
 =?utf-8?B?NVRXMnVSTFAzRW13NlhTTEN4Z0daWForM3dYZjRMdFVyMzBkNWNPODk2SUFt?=
 =?utf-8?B?OEg4UC9SY2dmZkFrbVlPZDFBajZWN2NHQWJkK2tuZDdKRVMvUFlDS2c4MXlu?=
 =?utf-8?B?M1NDTDRuMERlVjZiRDdNRHFibkFhMWhiWHBMMTJERUpoWkNCOS9nekxDZ0xU?=
 =?utf-8?B?OHpiRjdNQ1o3TzRBbjBkZjNkanZHQXM4WGFLTzZJM21jbDh2djk1REJDc3lR?=
 =?utf-8?B?Q1pWSDZaZlVXdmc3ZFVpTksxdFlRSm95Mkw5czFXTVlNWVJORVAxQ2JaL1ZI?=
 =?utf-8?B?M1FaWU5QdkdBR1doQVZpNHRaWVBMKzRDRGFGOU82TmxVZjc2bHFCOGxmQXhp?=
 =?utf-8?B?cFMrenp4ejBNdmZVMjFqMjZ5V1JBRnZ5TWJsdy8vS1VnczYxSGthc2xJOFY5?=
 =?utf-8?B?b0RoUUlUbGJ3YmdYVEpzV0NpV2V3V0lKaDdPYVZETHBDUzlvSklWVnZGeVl4?=
 =?utf-8?B?ZnNKTUl2OFhZcTZuOFpLdXZENFhyb3VENjdweEsrYnhsTXIvRlRpVUVBMjhw?=
 =?utf-8?B?VnlIQkdFcnoxMFIxMWlaZmVHazFPUUN6cS9LSnR2NHlUcmxoQmFCM2R3RGZu?=
 =?utf-8?B?SmtINy94djh5RTQ4R3ZPOXdHTmZMQ3czT1U3czNTYWIyL1g0ZEExWnFaTnBk?=
 =?utf-8?B?QnBxNWpXb05wN241UnowbjkzWHZTSUJSeVdJVFdYdWROLzRETlJHN2l3VXk0?=
 =?utf-8?B?cXV2Rnd3YzV1ZGgwd3FyTmhhRjhsdzFZZDlsTk5pVGhzbkRtUjBiTDA4Yklz?=
 =?utf-8?B?aFZDSXVBTXMxOVl1czhIWGFEVTRqa3FCbWdtcmpHYlBFcEZtRFQzRkd5b2NY?=
 =?utf-8?B?NGFiYUFlRjE3RzcybmRvdC83RFZCUlZwREhqN0pGTHEvNTBYYkh0ZDBKREZX?=
 =?utf-8?B?OVBmSG5jNWFralVYS2RHVVIrOWxuZTZoZEV6UytlNmkzQTc1cCs0djVUVURl?=
 =?utf-8?B?dmNNRzZVWm0xbTNlQW5TZDViY0I0cHZEejhDZGJZdERzaUEyK2NiNDgzMk5p?=
 =?utf-8?B?UVNBSHkxM0MxOFdxbUpQeFIyMnZ3bEZjcHhJZSt2ZFNFYWp4LzRtSmowZFZ3?=
 =?utf-8?B?UGkrUmtyNzdUQ3J6ajBJcE9seDRBckMxZzlCQ2VVR3hWSWpCaXpJeFMreUdu?=
 =?utf-8?B?WGJSUHI2NzA1VlZiUTJRdjJjeFI2eDkvZldPZGc4RTdJL2dHaG9wLzQ2Mlhj?=
 =?utf-8?B?SS9QVVpXWUlKT1h4cWdqeTRYZWxPekw3ZEJISzk3NW5nM2I0UThpTFhmS2FP?=
 =?utf-8?B?SjdyZzNCQ3hSRVpJN1hmbnkxVXlLOTZTb2doa3BFMmRzSFM2anQ5WDBWMXJ4?=
 =?utf-8?B?cnEwMWhUS3NyNVlSY01qS0lWYi90ZStqZ3I4SFRuWDlnMENjTm11VDZObDRU?=
 =?utf-8?B?dTk1Wk01TjFzQlpWT1hTdUt5VkM2NHBTQUxUSXpRZHYwY09iQ0M0UVlFcFpk?=
 =?utf-8?B?ckJ3Sjd1UDFocDlHRUZReVZObVNtK2twRDR3OUdjbXBRV3phQXFQbmMwc216?=
 =?utf-8?B?VVd3K0pOYkNoRWV6R0FHd1dOdGxoYmxYZ3lDeTlnRzBIR1gvSjg4L2lTM2tP?=
 =?utf-8?B?cmUzVzVkMitlSUJBdTlLQno3SGVtNjh0M3B4VGFhNzVTYm83cXJCQWhXK3hQ?=
 =?utf-8?B?MDNndVM3RnRKUzNKVzlqUFFCU0F4VWFmS09JZEZ1VkNaSE5JZ0RHd0RlajBz?=
 =?utf-8?B?WW45clpzTWNoeE5Dallrc1FHMHNib2ZTdHRrOUlGSlAyL1B3Wk5aT1ZXWXB6?=
 =?utf-8?B?T2ZiUjN6QmJ4b21Zb3pKZjZvUi8yblVIZjV1dHNLY3BBRzY3Y3QzYWxPUU5G?=
 =?utf-8?B?ZWp6azcwSUc2K0prcHU3bXlRL2JtNVNMbk9BWVRXWHVVRkNnM2JONmhmbWNY?=
 =?utf-8?B?WnVpRS8zdnpIR1l0UFlvWmZiZ2IrR1ViWFYyTUtzQ0tFTUZqRlhnQjBjZ1c1?=
 =?utf-8?B?c3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f06c3393-f5d6-46b4-11ae-08dac2ba19ed
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 01:22:58.2737
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /X7e3sSoI89SjGXL8DL3viVH0D0evBZ6GY/IIIbtnqZAkAJPqSoys46ZLBpzm3wC29FMDiaEz5bp4VOfmuHwmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6083
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/9/2022 3:15 PM, Sohil Mehta wrote:
> Jithu, I replied to the prior version of the series by mistake. Duplicating that comment over here.
> 
> On 11/7/2022 2:53 PM, Jithu Joseph wrote:
>> The data portion of IFS test image file contains a metadata
>> region containing possibly multiple metadata structures in
>> addition to test data and hashes.
>>
>> Introduce the layout of this meta_data structure and validate
>> the sanity of certain fields of the new image before loading.
>>
>> Tweak references to IFS test image chunks to reflect the updated
>> layout of the test image.
>>
> 
> Can you provide some more information on the updated layout of the metadata structure?
> 

Here is the layout of the metadata section in an IFS test image.
Test Data (chunks) follow the struct meta_data  defined in load.c

    IFS Metadata layout
   +----------------------+  0
   |META_TYPE_IFS (=1)    |
   +----------------------+
   |meta_size             |
   +----------------------+
   |test type             |
   +----------------------+
   |fusa info             |
   +----------------------+
   |total images          |
   +----------------------+
   |current image#        |
   +----------------------+
   |total chunks          |
   +----------------------+
   |starting chunk        |
   +----------------------+
   |size per chunk        |
   +----------------------+
   |chunks per stride     |
   +----------------------+
   |Reserved[54]          |
   +----------------------+ 256
   |                      |
   |                      |
   |                      |
   |                      |
   |Test Data/Chunks      |
   |                      |
   |                      |
   |                      |
   |                      |
   +----------------------+  meta_size
   |   META_TYPE_END (=0) |
   +----------------------+  meta_size + 4
   |   size of end (=8)   |
   |                      |
   +----------------------+  meta_size + 8


Jithu