Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <382ef16e-5013-c226-2601-309be952f1fe@intel.com>
Date:   Wed, 9 Nov 2022 17:16:28 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2 13/14] Documentation/ABI: Update IFS ABI doc
Content-Language: en-US
To:     Sohil Mehta <sohil.mehta@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-14-jithu.joseph@intel.com>
 <503ba3e8-f060-002d-846a-8dec7e84c83b@intel.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <503ba3e8-f060-002d-846a-8dec7e84c83b@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDZ6aFhCM0NBckViNytjVmhqWVdDS2xQT3FxSyt2RitGSlJPdTVLWDg3RmZN?=
 =?utf-8?B?dVpMREZyL3RYeW9GSEpPYjZFL3VGSlZRb2lJTDk0YWllbVBKaHBQWm5maWgz?=
 =?utf-8?B?REtUbFhhYU03bUtYSm03M3ZqNmVhZ1Qrc2J3UDNZbEZHQUdFN2tHSjZXS3B0?=
 =?utf-8?B?VFBSMFEzcDFadVJYKzk4WmpsNnNic2xHTFJidmd1TzI5WW5SUmxCYW5VUEZK?=
 =?utf-8?B?dllxV1NaVDJwTkVKWXQyNUlpQ2VjTUN5QkJ6Q1JicDBxb05ORWNTNGxFcUxS?=
 =?utf-8?B?L1llVGVmbjI0MUVsTUI2ZXNhQjg2bFhtQ2oyRDFQc1ZWRmhQd0JkOFNDd0pm?=
 =?utf-8?B?bWxqVGlJRVg4N2lBL0taQVlTR3FOWFgrRkptUVNpclp6UEVUZnJBOFljSWFR?=
 =?utf-8?B?UndYNkJ3VmR5M0tVRlc2VU0zMU9NZXZQM2RQbFpKa1dBRzAyWUVvS1ZmS2Jw?=
 =?utf-8?B?SEI1V0crQW92WUNwWnlWK054ZWEybFdzbDdsaU42UWU4NmFORUQzSHM3YUpP?=
 =?utf-8?B?OWovVlJZdDJEMllBZ2o5VFlIN1BrSEVPVTVPS3Z6a0M1bG1ZVWZjc3c3aWJ1?=
 =?utf-8?B?dHZqNFI0b3FGYXFMa2JrajYxTFArNndzWnM1VU8xQXZGTXNxcGxXQm5ZL2t0?=
 =?utf-8?B?c09kU3p5OHlHVTh6TzhIVTdjVkYzc1dTYmY3T1lTMTl1TjJEVzJJMmtyWTJJ?=
 =?utf-8?B?c3RFVWNsVWFBd0UzSnJYTW5oRFdaSWtFemo1WE5pTmduMGx4VkROT0JmckJy?=
 =?utf-8?B?d25ET1hxRTdVRkhjTU9BMHZQZHZMY1FENEExZUNoaktHVFFtMEs4UldlUWQ4?=
 =?utf-8?B?cHdrSjhlcGJNeVhrV3ZOQTJuWUdVTnFzR1BKZEFHNnJ0Z0dPeXhFdkowRXBx?=
 =?utf-8?B?ODN2NGF2aUFaM1dMVHpzVUpid1huQmw1OUxYWlhZVW0rdmg4am1QdkRzSG41?=
 =?utf-8?B?YzNjWFpPKzUralMxWEpGd1V3K1VVY0hBeE85SFJpZmltNzFMandzR1JCc25L?=
 =?utf-8?B?dTl1M2JuTjYvdStEKzBJVTRzeklLczFKMDVZMFN2eGxjWTNBQzc4dGNlcTF0?=
 =?utf-8?B?T0pGQWR0RkJSOGduZGRlMnFxYlU4QnRKWEN1WENoeFhlcE1hTW5uTzhoeGMy?=
 =?utf-8?B?N1ZOWjdqZ1EvY09tbjk5WDAyMS8zZ3NLVzN0QXdUeTBHRThYa2M1emc3M0hj?=
 =?utf-8?B?cGhoMHBaVkFBblpGMGdUZzVvZlpheVpYUlBnd0JFZldUenFTbCtTMmpmS3ZZ?=
 =?utf-8?B?UzY2My8wdlE1dlEya09FRmlUSkRrdGZEWHZLd005VnY2U1RsdGlOYXl2NzBG?=
 =?utf-8?B?MDZDUDZFNWtHbGRVNUVvSXc3TDZ1Mm9rTDd5SURLQzVxM1hzVlVhZ3ROdFdW?=
 =?utf-8?B?c2ZweVFLekdYckwzUkJieG16NEFGb3haU1FLT0w1QWN0QkVpSnNDdWZLdGtH?=
 =?utf-8?B?L3hPTWVrQUtVcEZ4by8vdXF1NUxsbTFtL2VlZ21yL1ZJeGxVSXFnalhXSXVa?=
 =?utf-8?B?MGhzTE1WY1BrV1A1OEd2b0I0dUJ3c3NOZDNsdUd3WkdCQS82bGJVc25HQTJn?=
 =?utf-8?B?VW80YkxrdWxIQlc0WHdJWHdMTGMra2U4SFpveEY5NGNxNG9DNS8wdEhESjhh?=
 =?utf-8?B?TGVaZk5mcW1zTjlNQ2REQmdjdk1vbXhGVVlhbzh2SkVFaGJNdnBxQU8vSzJW?=
 =?utf-8?B?TnhHemFJQ0F6Mis4TzRmS0hibXU1bldDRERFV0piYzVENnZBYmgxRmxIMEZq?=
 =?utf-8?B?b0hSSTVNMDJmU21pRjd3VlRoZlpNZ3YzckEvZHJ2SFVjbStLSUFuQVFtME55?=
 =?utf-8?B?YTZFTDI0ek9IQUVNZi9DK0FFUlpBQ3UwODF3LzE1MCtiQWVROVpXMzB6dStC?=
 =?utf-8?B?SnFJSVk3bFNzN2o0U0pmemFrbXEzaUZjaDNsWU9WQmR6N2RhVzFOWklkVTBk?=
 =?utf-8?B?RGkyTko2MWhLRGt4TUVXVy9xM0hyeG0xd1JFdjBTK0U0WkJBbHdaRHYyczh6?=
 =?utf-8?B?cUhsOHE4UGpQUTc0R0dROHYwN0xWWVJ4aFczdHd6SWNmWUJFbEtJcEI1djhJ?=
 =?utf-8?B?NDlVSHgxMlp1TUREbGE5cGVTcFdvNXFNWVY1dWlxL051NnZIN3RMSWJsV3RV?=
 =?utf-8?B?N0EyZ3dFY0Y2UmFMMTdsK3BpNlorOEZmYXFHRXR6empUUlBSaCsya1pZMExU?=
 =?utf-8?B?WFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ca900b7e-3ae1-4a1e-b820-08dac2b93394
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 01:16:32.0375
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0sBhr7JV7neDt50fmVfB7gbob1Vk19RB39Rtzi5pygLFYRxdNb0+ktmtb9awfBo6NXsQvv01ru7pYNDlIqGDZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5820
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/9/2022 3:55 PM, Sohil Mehta wrote:

> 
> A clarification below.
> 
>>   -What:        /sys/devices/virtual/misc/intel_ifs_<N>/reload
>> -Date:        April 21 2022
>> -KernelVersion:    5.19
>> +What:        /sys/devices/virtual/misc/intel_ifs_<N>/current_batch
>> +Date:        Sept 30 2022
>> +KernelVersion:    6.2
>>   Contact:    "Jithu Joseph" <jithu.joseph@intel.com>
>> -Description:    Write "1" (or "y" or "Y") to reload the IFS image from
>> -        /lib/firmware/intel/ifs/ff-mm-ss.scan.
>> +Description:    Write a number less than or equal to 0xff to load an IFS test image.
> 
> Can the number start from 0 or is it expected to start from 1? It might be useful to mention that if there is a constraint.

The driver currently doesn't do any enforcement on if the input starts at 0 / 1. If user writes 0 and if 
the corresponding file it looks for (ff-mm-ss-00.<test_type>) is present, it would load it otherwise it would
return error-code ENOENT (returned by request_firmware_direct())

> 
>> +        The number written treated as the 2 digit suffix in the following file name:
>> +        /lib/firmware/intel/ifs_<N>/ff-mm-ss-02x.scan
>> +        Reading the file will provide the suffix of the currently loaded IFS test image.


Jithu