Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937399AbXHGV0j (ORCPT ); Tue, 7 Aug 2007 17:26:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S935856AbXHGU45 (ORCPT ); Tue, 7 Aug 2007 16:56:57 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:59944 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935852AbXHGU4z (ORCPT ); Tue, 7 Aug 2007 16:56:55 -0400 Date: Tue, 7 Aug 2007 13:49:13 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org, torvalds@linux-foundation.org Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, thomas@tungstengraphics.com, jesper.juhl@gmail.com, alanh@tungstengraphics.com Subject: [2.6.22.2 review 74/84] cr_backlight_probe() allocates too little storage for struct cr_panel Message-ID: <20070807204913.GX23028@kroah.com> References: <20070807204034.882009319@mini.kroah.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="cr_backlight_probe-allocates-too-little-storage-for-struct-cr_panel.patch" In-Reply-To: <20070807204157.GA23028@kroah.com> User-Agent: Mutt/1.5.15 (2007-04-06) X-Bad-Reply: References and In-Reply-To but no 'Re:' in Subject. Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1075 Lines: 34 From: Jesper Juhl The Coverity checker noticed that we allocate too little storage for "struct cr_panel *crp" in cr_backlight_probe(). Signed-off-by: Jesper Juhl Cc: Thomas Hellstrom Cc: Alan Hourihane Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- drivers/video/backlight/cr_bllcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/video/backlight/cr_bllcd.c +++ b/drivers/video/backlight/cr_bllcd.c @@ -174,7 +174,7 @@ static int cr_backlight_probe(struct pla struct cr_panel *crp; u8 dev_en; - crp = kzalloc(sizeof(crp), GFP_KERNEL); + crp = kzalloc(sizeof(*crp), GFP_KERNEL); if (crp == NULL) return -ENOMEM; -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/