Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966369AbXHGV3w (ORCPT ); Tue, 7 Aug 2007 17:29:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965147AbXHGU6G (ORCPT ); Tue, 7 Aug 2007 16:58:06 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:37644 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753242AbXHGU6E (ORCPT ); Tue, 7 Aug 2007 16:58:04 -0400 Date: Tue, 7 Aug 2007 13:49:33 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org, YOSHIFUJI Hideaki Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk Subject: [2.6.22.2 review 80/84] sysfs: release mutex when kmalloc() failed in sysfs_open_file(). Message-ID: <20070807204933.GD23028@kroah.com> References: <20070807204034.882009319@mini.kroah.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="sysfs-release-mutex-when-kmalloc-failed-in-sysfs_open_file.patch" In-Reply-To: <20070807204157.GA23028@kroah.com> User-Agent: Mutt/1.5.15 (2007-04-06) X-Bad-Reply: References and In-Reply-To but no 'Re:' in Subject. Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 771 Lines: 29 From: YOSHIFUJI Hideaki Signed-off-by: Greg Kroah-Hartman --- fs/sysfs/file.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c @@ -283,6 +283,7 @@ static int sysfs_open_file(struct inode mutex_lock(&inode->i_mutex); if (!(set = inode->i_private)) { if (!(set = inode->i_private = kmalloc(sizeof(struct sysfs_buffer_collection), GFP_KERNEL))) { + mutex_unlock(&inode->i_mutex); error = -ENOMEM; goto Done; } else { -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/