Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp113841rwb; Wed, 9 Nov 2022 21:04:44 -0800 (PST) X-Google-Smtp-Source: AMsMyM5ymQWzknh+ckVg2BbN3V9OPevO63/ZlVRfNzP8L4yRmItNfC+y7hQMKQcOath2d1s2gsTa X-Received: by 2002:a05:6402:27cb:b0:463:6346:40f with SMTP id c11-20020a05640227cb00b004636346040fmr1662785ede.420.1668056684040; Wed, 09 Nov 2022 21:04:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668056684; cv=none; d=google.com; s=arc-20160816; b=I3ANYvHyaXbudpWYT6FFyxbfURsN2YJIiM81qouSzdpLIBDpBn8WSx/x/VIpogV9iQ XlyHZ3QwyBYl6Z+PyD3/u/JJpKZtWw4hXSkPNOvitYFdaYrPfK7wBfNi99JRbPzeM8Z7 KD76tAONHZ4rYGUTT5SPi5pXP6Mc1iJ3EP2a3HLw5tWfwTD93bltP9J3clvTLaFnXfMF 565UrUr2ra6zJ55NULSvGDJwMSmWRFVKeIvxS1VsJLi2ZhAdxqgtyIjryLmL66kzAjOW +UFKb4YbVtGr/LjVIYxPIXFD7tj2wXAFs8A/c8DM89HmVOpoXSHza36PpXldrVq1tpoT d1RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qahc/OEJv9l/mG+aZHuyYNKbJOQinUkMTYXdNij93nY=; b=sJBEtaKT+cLovBL/0XXzEePaq6rfAkHo6v5+G5vJjlMQR8qsfrOJ0SXI1SukCH2gis l+9Wc/MACPXJ7Orem5U51D8p28dHklwIf0gywOR41KwUQBhAn00rN6mtBd0G/CO2Kxpb KTbRlZ5oC1GRqIZ8+pV/18VxwLtr4EiLubm8gWQ/MMBYWrHerSV19VxQLYuNWGttjRlO ndYaL/tdnsqQHtWYpX3k/QVIFsl1FaCzivxJfpGyZ7++Nyh5rVFUOVPH0suzurod8D8p 2NCVF2FWZ+O6ust2L9u1exeqZgiVrCZPXI/EITARobD4QWPVlfS8FKz8JJNvgzUUbFCX zqSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=H3rKGqs0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oz10-20020a1709077d8a00b00792e39c31dcsi15876219ejc.988.2022.11.09.21.04.21; Wed, 09 Nov 2022 21:04:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=H3rKGqs0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231966AbiKJElR (ORCPT + 92 others); Wed, 9 Nov 2022 23:41:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230323AbiKJElN (ORCPT ); Wed, 9 Nov 2022 23:41:13 -0500 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28469252B4 for ; Wed, 9 Nov 2022 20:41:11 -0800 (PST) Received: from letrec.thunk.org ([12.139.153.3]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 2AA4eDSA015823 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 9 Nov 2022 23:40:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1668055221; bh=qahc/OEJv9l/mG+aZHuyYNKbJOQinUkMTYXdNij93nY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=H3rKGqs0uCOsyfC9KYcBFj5CT1PnOFkol1Da9cLF93kcK4GjWwIb4VNfWJdesVNEg Cdr9oSbhuRVO8ki8qwPUuKnBpCxQJsfpFkddNmkJJ+9d+C1uC/z2KZlpFGAe8ek/sS kZ3npSqLafM+NPI4uSE2a5ppEmJuC0I7Hpo5Ov8C5WTOFXTpBpvT5OHsepFbSe3VVW IiPKzfvHAVUhHpZX0J833tJat9qVPGbbHQ4s4IEHM85S9VYCUuNRCQ6oE5o2SZbSm2 F58yi2GCow4Dq7RALHQ7lJ3aOoxRkYTHqz9N25O+TJ/F0ft0CiTT+/V6Zc/hML1stF tjRfXross+zlw== Received: by letrec.thunk.org (Postfix, from userid 15806) id 38BDE8C01E8; Wed, 9 Nov 2022 23:40:13 -0500 (EST) Date: Wed, 9 Nov 2022 23:40:13 -0500 From: "Theodore Ts'o" To: Aaro Koskinen Cc: Linus Torvalds , Paul Cercueil , vbabka@suse.cz, 42.hyeyoo@gmail.com, akpm@linux-foundation.org, catalin.marinas@arm.com, cl@linux.com, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, penberg@kernel.org, rientjes@google.com, rkovhaev@gmail.com, roman.gushchin@linux.dev, willy@infradead.org Subject: Re: Deprecating and removing SLOB Message-ID: References: <20221109234832.GE307514@darkstar.musicnaut.iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221109234832.GE307514@darkstar.musicnaut.iki.fi> X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2022 at 01:48:32AM +0200, Aaro Koskinen wrote: > > Some of the reported SLOB issues have been actually real driver bugs, > that go unnoticed when SLUB/SLAB are used (unless perhaps debug stuff > is enabled). I'm not saying kernel should keep SLOB, but it's good at > failing early when there is a bug. See e.g. commit 120ee599b5bf ("staging: > octeon-usb: prevent memory corruption") Out of curiosity, are these bugs that would have been found using KASAN or some of the other kernel sanitizers and/or other debugging tools we have at our disposal? - Ted