Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Nov 2022 08:07:18 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Mika Westerberg <mika.westerberg@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-pwm@vger.kernel.org, Andy Shevchenko <andy@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 1/6] pwm: Add a stub for devm_pwmchip_add()
Message-ID: <20221110070718.bqpam7h3hjf2hkip@pengutronix.de>
References: <20221108142226.63161-1-andriy.shevchenko@linux.intel.com>
 <20221108142226.63161-2-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="hbekflahz2byd2ag"
Content-Disposition: inline
In-Reply-To: <20221108142226.63161-2-andriy.shevchenko@linux.intel.com>
Precedence: bulk


--hbekflahz2byd2ag
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello=20

On Tue, Nov 08, 2022 at 04:22:21PM +0200, Andy Shevchenko wrote:
> devm_pwmchip_add() can be called by a module that optionally
> instantiates PWM chip. In case of CONFIG_PWM=3Dn, the compilation
> can't be performed. Hence, add a necessary stub.
>=20
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
>  include/linux/pwm.h | 5 +++++
>  1 file changed, 5 insertions(+)
>=20
> diff --git a/include/linux/pwm.h b/include/linux/pwm.h
> index d70c6e5a839d..bba492eea96c 100644
> --- a/include/linux/pwm.h
> +++ b/include/linux/pwm.h
> @@ -478,6 +478,11 @@ static inline int pwmchip_remove(struct pwm_chip *ch=
ip)
>  	return -EINVAL;
>  }
> =20
> +static inline int devm_pwmchip_add(struct device *dev, struct pwm_chip *=
chip)
> +{
> +	return -EINVAL;
> +}
> +

I'm a bit surprised to see this returning -EINVAL and not -ENOSYS. But
that's in line with the other stubs, so:

Acked-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--hbekflahz2byd2ag
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmNsoyQACgkQwfwUeK3K
7AkwtAgAlngwWjscEhoQXRiD28VBXc9a5O4+98O/r+kYB2f4/9rN6+2ET0CWOpzd
8KDQ9B5IuGoSKhII3IwDcM4rRDI3DwECHp23BbLQL6NXjgxtw3eYZ7hJwUDEXpRE
85aPp4cSqFMMkEpCOx8dLnj6rRxrR+l2kmsonH8ZpOM38kVvvkpD8+UPKFL7X/Kj
ENy05dR+v2QEWE1UzYNuHHxWS3D61v9+H2Ae2DGHI0JH9+24hSTLwYvAE4SivcIY
O1mTM7pKNsoFuCORxf1Vit/f8ZDWD+3miMg0cfIU0AgqxaPACkZpjf/7CZ99WjJr
okFGA+bWbJp7tPxqjDpAhJPJTb7Ctw==
=4ga8
-----END PGP SIGNATURE-----

--hbekflahz2byd2ag--