Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Nov 2022 08:21:44 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Mika Westerberg <mika.westerberg@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-pwm@vger.kernel.org, Andy Shevchenko <andy@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 3/6] pwm: lpss: Include headers we are direct user of
Message-ID: <20221110072144.2s37r52qcpi6utgh@pengutronix.de>
References: <20221108142226.63161-1-andriy.shevchenko@linux.intel.com>
 <20221108142226.63161-4-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kl3orhl5l6nepqs2"
Content-Disposition: inline
In-Reply-To: <20221108142226.63161-4-andriy.shevchenko@linux.intel.com>
Precedence: bulk


--kl3orhl5l6nepqs2
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Tue, Nov 08, 2022 at 04:22:23PM +0200, Andy Shevchenko wrote:
> For the sake of integrity, include headers we are direct user of.
>=20
> While at it, move the struct pwm_lpss_chip to be after
> the struct pwm_lpss_boardinfo as the former uses pointer
> to the latter.

That part is fine.

> Replace device.h with a forward declaration in order to improve
> the compilation time due to reducing overhead of device.h parsing
> with entire train of dependencies.

Together with "For the sake of integrity, include headers we are direct
user of." this makes an a bit schizophrenic impression on me. You add
<linux/types.h> because the file is a direct user of it, but you drop
<linux/device.h> despite being a direct user.

If you adapt the reasoning to something like:

Replace the inclusion of <linux/device.h> by a forward declaration of
struct device plus a (cheaper) #include of <linux/types.h> as
<linux/device.h> is an expensive include (measured in compiler effort).

I could better live with it. I would even split this into two patches
then. (i.e. move struct pwm_lpss_chip vs the include and forward change)

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--kl3orhl5l6nepqs2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmNspoUACgkQwfwUeK3K
7Al4jAf+KJNGvp8Rn+uVlNVAhxjiKuIbYR8EWHPnYLHmuS/aIZbajf5eWL/5mFVx
tVVxe6MgD/wKubSURgJqRfqhn+k+D3AzH/oegvru0QhE//qQ1liKwqsV/A+0CwGB
Aoue0nW3Fbt/psnD3j6t6J6o0Y7HDUkSYmFDelc9GZxtVlEXABLkUucXRjcSclWo
dRuVSFYYj+ggI79yMTdU8WpyijehVCKvTULeZSMXJiDR9IieJYikZyIHJuM3if4I
JXSiD6ihnTpLByKK2ppH1tQO6LlUrJvWWjUD0LIJofQqbEFRSEQ4dag8qf1iR7GV
HZKl/FYFmJdpIcO6Sxg/621RqQSj5Q==
=A+z8
-----END PGP SIGNATURE-----

--kl3orhl5l6nepqs2--