Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Nov 2022 08:38:31 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Mika Westerberg <mika.westerberg@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-pwm@vger.kernel.org, Andy Shevchenko <andy@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 5/6] pwm: lpss: Add pwm_lpss_probe() stub
Message-ID: <20221110073831.ggudvgl6jzgbo2vb@pengutronix.de>
References: <20221108142226.63161-1-andriy.shevchenko@linux.intel.com>
 <20221108142226.63161-6-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="c2ikj363pkmkwzsq"
Content-Disposition: inline
In-Reply-To: <20221108142226.63161-6-andriy.shevchenko@linux.intel.com>
Precedence: bulk


--c2ikj363pkmkwzsq
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 08, 2022 at 04:22:25PM +0200, Andy Shevchenko wrote:
> In case the PWM LPSS module is not provided, allow users to be
> compiled with a help of a pwm_lpss_probe() stub.
>=20
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
>  include/linux/platform_data/x86/pwm-lpss.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>=20
> diff --git a/include/linux/platform_data/x86/pwm-lpss.h b/include/linux/p=
latform_data/x86/pwm-lpss.h
> index 296bd837ddbb..c868b396ed2c 100644
> --- a/include/linux/platform_data/x86/pwm-lpss.h
> +++ b/include/linux/platform_data/x86/pwm-lpss.h
> @@ -4,6 +4,8 @@
>  #ifndef __PLATFORM_DATA_X86_PWM_LPSS_H
>  #define __PLATFORM_DATA_X86_PWM_LPSS_H
> =20
> +#include <linux/err.h>
> +#include <linux/kconfig.h>
>  #include <linux/types.h>
> =20
>  struct device;
> @@ -27,7 +29,16 @@ struct pwm_lpss_boardinfo {
>  	bool other_devices_aml_touches_pwm_regs;
>  };
> =20
> +#if IS_REACHABLE(CONFIG_PWM_LPSS)
>  struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev, void __iomem *b=
ase,
>  				     const struct pwm_lpss_boardinfo *info);
> +#else
> +static inline
> +struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev, void __iomem *b=
ase,
> +				     const struct pwm_lpss_boardinfo *info)
> +{
> +	return ERR_PTR(-ENODEV);

Would it be more consistent to return the same value as the pwmchip_add
stub does?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--c2ikj363pkmkwzsq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmNsqnQACgkQwfwUeK3K
7Akn9wf9H/bc8ldHeuoeAwBk70DIIRDsgQ1NPv2mRbmhXfgZR4IffDdmU/OqZFPo
jWCw2AUBKxMOMW8wzmhdYkUd183UYX0eAIvW1PFkuZk3shrGkiV/XMh2MVfR/8FT
owv6sQ7VCcPWgy6fBkACC1hQy/7gdoyIUaRXySDwlBd0Krj3FMhYQHR1Wv1vhCrJ
V4Grgfym9zH99n1cBFro6x3QW9KAx27W9yjCZoymuNnbHVpB7OnkvJrJNj/w4O59
YPiuNjtVPZvmTZKvnpmOxFCHM+5VfWp0nhV4capqArNjD2pqSK8+f645Jkl6vgoe
nnrEX+PYEGHdmCjmVcgVNeAXmWMiGQ==
=LgpM
-----END PGP SIGNATURE-----

--c2ikj363pkmkwzsq--