Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Nov 2022 08:02:36 +0000
Message-ID: <87mt8zutib.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Richard Fitzgerald <rf@opensource.cirrus.com>
Cc:     <lee@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <linus.walleij@linaro.org>,
        <broonie@kernel.org>, <tglx@linutronix.de>,
        <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <patches@opensource.cirrus.com>
Subject: Re: [PATCH 09/12] irqchip: cirrus: Add driver for Cirrus Logic CS48L31/32/33 codecs
In-Reply-To: <20221109165331.29332-10-rf@opensource.cirrus.com>
References: <20221109165331.29332-1-rf@opensource.cirrus.com>
        <20221109165331.29332-10-rf@opensource.cirrus.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 09 Nov 2022 16:53:28 +0000,
Richard Fitzgerald <rf@opensource.cirrus.com> wrote:
> 
> The Cirrus Logic CS48L31/32/33 audio codecs contain a programmable
> interrupt controller with a variety of interrupt sources, including
> GPIOs that can be used as interrupt inputs.
> 
> This driver provides the handling for the interrupt controller. As the
> codec is accessed via regmap, the generic regmap_irq functionality
> is used to do most of the work.
>

I cannot spot a shred of interrupt controller code in there. This
belongs IMO to the MFD code. It is also a direct copy of the existing
irq-madera.c code, duplicated for no obvious reason.

	M.

-- 
Without deviation from the norm, progress is not possible.