Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc:     michael@walle.cc, jingchang.lu@freescale.com,
        tomonori.sakita@sord.co.jp, atsushi.nemoto@sord.co.jp,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: [PATCH V2 5/5] tty: serial: fsl_lpuart: clear LPUART Status Register in lpuart32_shutdown()
Date:   Thu, 10 Nov 2022 16:17:28 +0800
Message-Id: <20221110081728.10172-6-sherry.sun@nxp.com>
In-Reply-To: <20221110081728.10172-1-sherry.sun@nxp.com>
References: <20221110081728.10172-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1g0zNDY6hdxJXBFYIhaDopPkSeN/i4Ch2x2tYstajYw7bLTZmoXQcw6b2Bs+?=
 =?us-ascii?Q?HR+TGpS+DYpwJBVuXNhNljzCzkhFHlUVaHCoBzhaIHqy9taCX6fQhcTYr/NO?=
 =?us-ascii?Q?N+5QM4xjbzsQroPnDlsA1jhzFZypeldIjwekvn05Egyx5f0WgcE47TTMPzwW?=
 =?us-ascii?Q?WZ6GZDQEdVXr5WOk3mJL8bJRmlctaBEjWdMBctg8hwEDbib/bHRmPbxDrYwv?=
 =?us-ascii?Q?1kfRDETrrz1OaFHB+nkzBbtqeVYQ2SQ0yAPZYyodbAV9F0WRJvdfTtBwadtK?=
 =?us-ascii?Q?poV79jIRsFHkYcyrZAAiY4Jr01bUoCkSAYYpYu5rJrxbZy48k4kTGOYTRqRS?=
 =?us-ascii?Q?HKRQEswEECMew/dodC95AxwqAfpetBVCmeKjRvsZ9o6UF21ou7AoIYb93cv9?=
 =?us-ascii?Q?3mE39Kyq9/hasr+L+iyh78aj8BKLOzMJHfynTURwWxro22dKnZ6VVj+swE4Y?=
 =?us-ascii?Q?Aktw74FZqZqoYzHRAY7LX4tmlgT6K+PESli5qEuLnF8dBt1aCtdFRW1jsXrP?=
 =?us-ascii?Q?pGG6Gw+MK+UZJ2QmuFsjgeFA7XYB3TcMIPGCu6VSAQdtnqxfJpLJELQdSXGC?=
 =?us-ascii?Q?iy7SneYBsOE8shWeFpfIm+q8NQ2a2oor3fMB2mpAliTK6eYchR88YTUoV9ht?=
 =?us-ascii?Q?UZx586oLQ+y1wmJVqycIkK7agKcdltHop22SBEmCL2Z6PxYwwpECWmzloh3i?=
 =?us-ascii?Q?eeREz45HGW8fqjMm/x79Rv+U0kk32mWuIi6YflOWEkonTDbVmjR8nI+KnCoU?=
 =?us-ascii?Q?2LFAU0h28jXB0ITPlFBaFGuIyzD9v6CEZ6h4uds8yVUjLxfmD9Scv5rb+Fqb?=
 =?us-ascii?Q?rj9xXrtt8Gnnwz0TqL1BPA7FY8mItC/+xJQgLwBMmmNfidSSnbIcq7tbzv0l?=
 =?us-ascii?Q?B0fvYMd9r0jajuJQnWvzayWStiRynfB+E/aLMIx/QbYwDjRG33cbQzNh/A3O?=
 =?us-ascii?Q?kbpPxSldlN8yW5oDnAAyrBKVizBYuYM9vObHr0zxDRehRSbn8fuuBfM24ED8?=
 =?us-ascii?Q?2amc8Gojv1GnGKGc1GZX5Q0M3RXKhmGFci0vGjuuuhpcixhOZh6XaeNkgfht?=
 =?us-ascii?Q?CbTcoLWfmhG0cfHyeCNpSmG3cxeRE6LDs6q6Y6kinrpWwHNgxhv1bwINlS6B?=
 =?us-ascii?Q?BX3XmzHvN9T9yy3qyqLNu3VOmhtzdlsYvtnCQxIrMiTPjgNDe7qvXW1uOIT2?=
 =?us-ascii?Q?+VTptYNjuY0tDIVFP/tlEM76gOyIdVFIv1MBoqWitTVPUndJe8L/6l9o8CNZ?=
 =?us-ascii?Q?WXnkp/uwqAb0fnTutpcAAM95APjHQjCR4FT/Vtnojm/5Pe5woYyKSwZpuNPv?=
 =?us-ascii?Q?cgpEjSX25EwsiNvzgotF2wpJTrb0FD1zylHcOZcnKtYCuKRpJuphkZeJkGbc?=
 =?us-ascii?Q?zBXSJoSE3/HqnBptGA/8ZdE1Q/aDnn01ZNcCuwX8umoZOdQYlU5QsgIq7lhj?=
 =?us-ascii?Q?fUaG6p/VPWdv4IWTP6btcxByR2wjRuUn3w2QxQpT9J0ialpkecoJvz9sLSxH?=
 =?us-ascii?Q?GnRxR0MBSkDfRU3IWpcJl7pewGfSk3Wx8MZVmN89lODFOk32K0Dd0gQILoXu?=
 =?us-ascii?Q?JM/0jTTpCcUZDZd89SNAqY8XBLvAMY5raMZdCpBl?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac1aa27e-ab9e-4fbf-56ce-08dac2f451eb
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 08:19:43.1188
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X6WS36qGXD4QWjswYPTz3Z3XkJmgIfkITtPxGeYR8a0NwNVGmgOPNPJwgiPeqwaSajZV6wzyWF50JzMIyTTwuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7923
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The LPUART Status Register needs to be cleared when closing the uart
port to get a clean environment when reopening the uart.

Fixes: 380c966c093e ("tty: serial: fsl_lpuart: add 32-bit register interface support")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
Changes in V2:
1. Split one patch into four smaller patches to improve the commit
messages and add Fixes tag as suggested by Ilpo.
---
 drivers/tty/serial/fsl_lpuart.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index c297be11422a..75162c4784dd 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1769,6 +1769,10 @@ static void lpuart32_shutdown(struct uart_port *port)
 
 	spin_lock_irqsave(&port->lock, flags);
 
+	/* clear statue */
+	temp = lpuart32_read(&sport->port, UARTSTAT);
+	lpuart32_write(&sport->port, temp, UARTSTAT);
+
 	/* disable Rx/Tx DMA */
 	temp = lpuart32_read(port, UARTBAUD);
 	temp &= ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
-- 
2.17.1