Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Nov 2022 09:02:17 +0100
From:   Herve Codina <herve.codina@bootlin.com>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Magnus Damm <magnus.damm@gmail.com>,
        Gareth Williams <gareth.williams.jx@renesas.com>,
        linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH 1/7] soc: renesas: r9a06g032-sysctrl: Export function to
 get H2MODE from CFG_USB register
Message-ID: <20221110090217.4f4f4a0e@bootlin.com>
In-Reply-To: <CAMuHMdUGz3z12Wwg8AoYwC7SN7xtAj7Osq6S9gO1mA+_KD4-vg@mail.gmail.com>
References: <20221107135825.583877-1-herve.codina@bootlin.com>
        <20221107135825.583877-2-herve.codina@bootlin.com>
        <CAMuHMdVbWGYPkspMx40S02cr6sX2LZkGwye3JQCtiPtLhuDCPw@mail.gmail.com>
        <20221107175446.29c93376@bootlin.com>
        <CAMuHMdUGz3z12Wwg8AoYwC7SN7xtAj7Osq6S9gO1mA+_KD4-vg@mail.gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Geert,

Oops, my bad I removed all people from the email previously.
Re-added them on this reply.=20

On Mon, 7 Nov 2022 20:23:06 +0100
Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Hi Herv=C3=A9,
>=20
> On Mon, Nov 7, 2022 at 5:54 PM Herve Codina <herve.codina@bootlin.com> wr=
ote:
> > On Mon, 7 Nov 2022 15:40:53 +0100
> > Geert Uytterhoeven <geert@linux-m68k.org> wrote: =20
> > > On Mon, Nov 7, 2022 at 2:59 PM Herve Codina <herve.codina@bootlin.com=
> wrote: =20
> > > > The CFG_USB register is located within the system controller.
> > > >
> > > > We need a helper to get the H2MODE value from the CFG_USB register
> > > > without syscon.
> > > >
> > > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> =20
> > > =20
> > > > --- a/drivers/clk/renesas/r9a06g032-clocks.c
> > > > +++ b/drivers/clk/renesas/r9a06g032-clocks.c
> > > > @@ -25,6 +25,8 @@
> > > >  #include <linux/spinlock.h>
> > > >  #include <dt-bindings/clock/r9a06g032-sysctrl.h>
> > > >
> > > > +#define R9A06G032_SYSCTRL_USB    0x00
> > > > +#define R9A06G032_SYSCTRL_USB_H2MODE  (1<<1)
> > > >  #define R9A06G032_SYSCTRL_DMAMUX 0xA0
> > > >
> > > >  struct r9a06g032_gate {
> > > > @@ -341,6 +343,22 @@ int r9a06g032_sysctrl_set_dmamux(u32 mask, u32=
 val)
> > > >  }
> > > >  EXPORT_SYMBOL_GPL(r9a06g032_sysctrl_set_dmamux);
> > > >
> > > > +
> > > > +/* Exported helper to get the H2MODE bit from USB register */
> > > > +int r9a06g032_sysctrl_get_usb_h2mode(bool *h2mode)
> > > > +{
> > > > +       u32 usb;
> > > > +
> > > > +       if (!sysctrl_priv)
> > > > +               return -EPROBE_DEFER;
> > > > +
> > > > +       usb =3D readl(sysctrl_priv->reg + R9A06G032_SYSCTRL_USB);
> > > > +       *h2mode =3D (usb & R9A06G032_SYSCTRL_USB_H2MODE) ? true : f=
alse;
> > > > +
> > > > +       return 0; =20
> > >
> > > Perhaps not pass *h2mode, but just return USB_ROLE_{HOST,DEVICE}
> > > (enum usb_role in <linux/usb/role.h>), or a negative error code? =20
> >
> > Yes, good idea.
> > I will also rename the function :
> >   enum usb_role r9a06g032_sysctrl_get_usb_role(void);
> >
> > Is that ok for you or do you prefer that I keep the previous name ? =20
>=20
> r9a06g032_sysctrl_get_usb_role() sounds fine!
> But it should return "int", as the return value can be a negative error c=
ode,
> too.

All right, I will do that in v2 series.

Thanks,
Herv=C3=A9

--=20
Herv=C3=A9 Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com