Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <865d6c3e-cc23-bc4d-de91-41d090847843@linaro.org>
Date:   Thu, 10 Nov 2022 09:36:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2 3/3] ARM: dts: qcom-msm8960-cdp: align TLMM pin
 configuration with DT schema
Content-Language: en-US
To:     Bjorn Andersson <andersson@kernel.org>
Cc:     Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Konrad Dybcio <konrad.dybcio@linaro.org>
References: <20221109105140.48196-1-krzysztof.kozlowski@linaro.org>
 <20221109105140.48196-3-krzysztof.kozlowski@linaro.org>
 <20221110033753.oyhl7z2edsrkkepg@builder.lan>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20221110033753.oyhl7z2edsrkkepg@builder.lan>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/11/2022 04:37, Bjorn Andersson wrote:
> On Wed, Nov 09, 2022 at 11:51:40AM +0100, Krzysztof Kozlowski wrote:
>> DT schema expects TLMM pin configuration nodes to be named with
>> '-state' suffix and their optional children with '-pins' suffix.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>
>> ---
>>
>> Changes since v1:
>> 1. Add Rb tag
>> ---
>>  arch/arm/boot/dts/qcom-msm8960-cdp.dts | 19 +++++++++----------
>>  1 file changed, 9 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom-msm8960-cdp.dts b/arch/arm/boot/dts/qcom-msm8960-cdp.dts
>> index 3a484ac53917..9a3a510f88ca 100644
>> --- a/arch/arm/boot/dts/qcom-msm8960-cdp.dts
>> +++ b/arch/arm/boot/dts/qcom-msm8960-cdp.dts
>> @@ -60,33 +60,32 @@ &gsbi5_serial {
>>  };
>>  
>>  &msmgpio {
>> -	spi1_default: spi1_default {
>> -		 mux {
>> -			pins = "gpio6", "gpio7", "gpio9";
>> -			function = "gsbi1";
>> -		 };
>> -
>> -		 mosi {
>> +	spi1_default: spi1-default-state {
>> +		 mosi-pins {
>>  			pins = "gpio6";
>> +			function = "gsbi1";
>>  			drive-strength = <12>;
>>  			bias-disable;
>>  		 };
>>  
>> -		 miso {
>> +		 miso-pins {
>>  			pins = "gpio7";
>> +			function = "gsbi1";
>>  			drive-strength = <12>;
>>  			bias-disable;
>>  		 };
>>  
>> -		 cs {
>> +		 cs-pins {
>>  			pins = "gpio8";
>> +			function = "gpio";
> 
> I'm changing this to "gsbi1" while applying this patch.

Thanks Bjorn. This was missing in original DTS, so I assumed intention
was a GPIO-based CS. I guess SPI-based also makes sense...

Best regards,
Krzysztof