Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1115-g8b801eadce-fm-20221102.001-g8b801ead
Mime-Version: 1.0
Message-Id: <d9b1e753-3bdd-4b8f-935e-718b0b590ace@app.fastmail.com>
In-Reply-To: <213cb0f3-10ce-45b1-aa5d-41d753a0cadd@app.fastmail.com>
References: <20221109043845.16617-1-balamanikandan.gunasundar@microchip.com>
 <Y2vghlEEmE+Bdm0v@lunn.ch>
 <213cb0f3-10ce-45b1-aa5d-41d753a0cadd@app.fastmail.com>
Date:   Thu, 10 Nov 2022 10:02:25 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Andrew Lunn" <andrew@lunn.ch>,
        "Balamanikandan Gunasundar" <balamanikandan.gunasundar@microchip.com>
Cc:     "Ulf Hansson" <ulf.hansson@linaro.org>,
        linux-kernel@vger.kernel.org,
        linux-atm-general@lists.sourceforge.net,
        "linux-mmc @ vger . kernel . org" <linux-mmc@vger.kernel.org>,
        "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
        ludovic.desroches@microchip.com, 3chas3@gmail.com,
        Netdev <netdev@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mmc: atmel-mci: Convert to gpio descriptors
Content-Type: text/plain
Precedence: bulk

On Thu, Nov 10, 2022, at 09:05, Arnd Bergmann wrote:
> On Wed, Nov 9, 2022, at 18:16, Andrew Lunn wrote:
>> On Wed, Nov 09, 2022 at 10:08:45AM +0530, Balamanikandan Gunasundar wrote:
>>> Replace the legacy GPIO APIs with gpio descriptor consumer interface.
>>
>> I was wondering why you Cc: netdev and ATM. This clearly has nothing
>> to do with those lists.
>>
>> You well foul of
>>
>> M:	Chas Williams <3chas3@gmail.com>
>> L:	linux-atm-general@lists.sourceforge.net (moderated for non-subscribers)
>> L:	netdev@vger.kernel.org
>> S:	Maintained
>> W:	http://linux-atm.sourceforge.net
>> F:	drivers/atm/
>> F:	include/linux/atm*
>> F:	include/uapi/linux/atm*
>>
>> Maybe these atm* should be more specific so they don't match atmel :-)
>
> The uapi headers look unambiguous to me, for the three headers in
> include/linux/, only the atmdev.h is actually significant, while
> linux/atm.h and linux/atm_tcp.h could each be folded into the one
> C file that actually uses the contents.

Actually the situation for the linux/atmel*.h headers is similar:
most of them are only used in one file, and the linux/atmel-mci.h
contents should just be moved into drivers/mmc/host/atmel-mci.c
as part of Balamanikandan's patch, to allow further cleanups.

linux/atmel-isc-media.h similarly can go into its drivers as a
separate patch if desired.

The linux/atmel-ssc.h could ideally be cleaned up to get moved
into sound/soc/atmel/ along with drivers/misc/atmel-ssc.c.
The atmel-scc driver is technically also used by
sound/spi/at73c213.c, but that driver has been orphaned since
2014, with commit 2e591e7b3ac2 ("ARM: at91: remove
at91sam9261/at91sam9g10 legacy board support"), as nobody
ever added DT probing support to it.

      Arnd