Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     jaegeuk@kernel.org
Cc:     chao@kernel.org, frank.li@vivo.com,
        linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: remove gc_urgent_high_remaining node
Date:   Thu, 10 Nov 2022 16:19:48 +0800
Message-Id: <20221110081948.31673-1-frank.li@vivo.com>
In-Reply-To: <Y1wQp4Z9sHEqfWV1@google.com>
References: <Y1wQp4Z9sHEqfWV1@google.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fhWWSn5n4gFqzNGmF6I2ruJIXSpa4BblmryV82puo5fvVlkFTjKLp9w8OzES?=
 =?us-ascii?Q?kl18CwThQjwAFAZnzefc0OgCh2cZvJXzmff60hT+VTue8/5qJTPOhkM3Q10u?=
 =?us-ascii?Q?tfOpoPva3IQ3w+4gMtIxh5FVyqfPdkmXfrwkaamXquDAJyOBdhCdxHs+54gD?=
 =?us-ascii?Q?AnrKanbmPHvDaLsKq5mTG13DN73YUnaewy1e9+RCGt8Dfz1nm9z6zcOlU5fg?=
 =?us-ascii?Q?SI/Zj2mkUZ5fkVmpbdBlgBbkJbS5h8/dDThwKYIRAZYCIbjy8CbUN5/ALdtJ?=
 =?us-ascii?Q?cxI1eGFVoRRnoqTtmee5S6wsZXj7WNRMCg3fsSTR/up77qC/B3nrMYQ2p6lQ?=
 =?us-ascii?Q?DeXhjQyqCG4oVwdNGl9B+EeKiMcx2c1LRkJjMaez/9ZGHlaF9En6vEDTpD6S?=
 =?us-ascii?Q?3t9TP7vgnqIdctQMN0xxL5fMydPjNtrZWSfGpWV7ozMD3Ex//MtW4KU1z3Ty?=
 =?us-ascii?Q?i29/1uTxUHDW+RseD4/tOpJUZuK2pW6HkVukPLVx0eIRJztUN3NaGH998Ers?=
 =?us-ascii?Q?Qvsre+5SJH6jJn4KenQJrRV64A/EXCgXPK64SONjHeBH6Ti8lgUpE1o0UJl/?=
 =?us-ascii?Q?UBAnreWvGqdnu6wVmn79TC/sJxSx9nmKK45rT7F77iUy6MWHGzZpvnVxG3RY?=
 =?us-ascii?Q?R1BLT1ZKshp/7jg5MpOgWmpxw7NeexX4g4yD3y/vnbaMdmysXI3GCoNxfFND?=
 =?us-ascii?Q?Crp+94qUWz6eG4OiTyvSnrWJ75TSShucMoWZ4MuJ2EltlGbyB1W6q55nrnLH?=
 =?us-ascii?Q?qoLOMB+rI93WwOSXqPxWoLCdJJSXlJ0PDjLESWZnSdZirgQ9NJarTN6u0Qvc?=
 =?us-ascii?Q?fiUeqyllWr0mrFvZtBxczFLTAsw3edf73ojC+HJStATMK56vIGt1/QDwbPKJ?=
 =?us-ascii?Q?BwFU/8x4yzeXD1Mw8nara3smtrPRbq1Yh9StR8S06jX6h8nnG2t7qtYtLEUb?=
 =?us-ascii?Q?T21RWu1ukSyGWW7BT1LSqTMqn4HbFtV7Ug26L8C0y4bYgfcsfI0Xb0XySf9C?=
 =?us-ascii?Q?tTRMhYo6u1jJOwASj//B7lPTRlbavr2W4vWrds+uskALrsOZAc/UnOxzjIl0?=
 =?us-ascii?Q?v9omsewIvM9Ls4+O6igfVfKBR9wJxmT4IG/A/QMGSas5QLXOpbFfTtqpdZAn?=
 =?us-ascii?Q?zg0Ye3lmvWgWSyz2Bi0vJxWJSqhQbsnUHrxafM1usGQ/06yMkC5OFrDQ+lQI?=
 =?us-ascii?Q?5AxNQUaWldruKY4721CVmzWO1eL7keFTMI17F8+waV93nAiI113wRyUGIpLc?=
 =?us-ascii?Q?rSoXSAmBzPtp0fm7Nr38+4wMp1qR1ZwdXhnkOchQri9WL++98pz8QR73w+Fe?=
 =?us-ascii?Q?MKQxt5zwIW8ZBceJh6suJYBH0wBcl6CHHB5QH15icYImSXc0NsJZpnoBOBpE?=
 =?us-ascii?Q?e21Q00cP96dtaITHN/Z8Z4NO9nznVa1wB2TodoVoa1i6r4EF0JUrKCMTUN6S?=
 =?us-ascii?Q?dN4lvNh/UBgsHPeCWoBhrOOf7qdIuOrUvX7uw3YC7rd5p3H/OpXZKKVQbhHt?=
 =?us-ascii?Q?ka007OnoTBHl8PwQhiSdtqsFttD70tp3fiAIuIllrp+H7QLYn4oeI8p+2k4B?=
 =?us-ascii?Q?Cba9p+iczrvufnghIVMzVOZ8Vbg1SO6EFcoW9Vsk?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 669dfe0f-7b7b-4293-7740-08dac2f45a26
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 08:19:56.9141
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6HUI3W+wC8n8p5ih9cpHPA6b+z4JgCpnYpHQVQWLXapPGOqN0Fmmo7ERy5aOvtmfAIik+Xm1NAB+uWJZGOmDaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5361
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jaegeuk,

> Hi,

> I modified and integrated some patches as below. Could you please take a look?

> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=d34f1e7212c1965a409d4581a32a92a1c91495fc

I've looked at the relevant changes on the branch, looks good to me.

One small question, does the name need to be changed to gc_remaining_count?
There are already controls based on the number of gcs, maybe we can add a
gc_remaining_ms later? Control the gc mode based on the expected time. When
the count is reduced to 0 or the gc ends and the expected value is reached,
switch back to the normal mode.

Thx,
Yangtao