Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc:     michael@walle.cc, jingchang.lu@freescale.com,
        tomonori.sakita@sord.co.jp, atsushi.nemoto@sord.co.jp,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: [PATCH V2 4/5] tty: serial: fsl_lpuart: disable Rx/Tx DMA in lpuart32_shutdown()
Date:   Thu, 10 Nov 2022 16:17:27 +0800
Message-Id: <20221110081728.10172-5-sherry.sun@nxp.com>
In-Reply-To: <20221110081728.10172-1-sherry.sun@nxp.com>
References: <20221110081728.10172-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hLD4upmXYB3a6iRcnIxQ0O3+Zkb1kgD/37njQosPgJBez7vivlX512kDtER1?=
 =?us-ascii?Q?WPdyruoFiwf99TlNUlMV5LNbR4VxjtoiFjxaJGyV2ra7UJmFs1CU6sbGO8i6?=
 =?us-ascii?Q?ikXI1smjuSWeLzZa8xBTUNPu1Oi6qDi5KkVWwrWXUtEroGq2PQYdiSspXA0f?=
 =?us-ascii?Q?si7d7DiyfvrBU+KPWwvfaLObJEPv05L1VrtgaT78HV8edX0aPg3CAWyO8rlW?=
 =?us-ascii?Q?l0WjIP9CufVPa1Op1ci26m5Q0+NkHe9XdmOwitD5d/9uE4rEcr/JT/jGnAlq?=
 =?us-ascii?Q?DdV4KQ23KCqXIQGxe98cw/hr1+CId8jqlCBSfxnxkafiFPonAGZVSiMGrrF9?=
 =?us-ascii?Q?GUzVJTHI0Iw0TMPK6DYOCPJ0S2qvbY2N+RArCcSO4iSjkQ+4hH8jVyZqVoqA?=
 =?us-ascii?Q?RKhjU9nCbT1sNY2wMbQK62NMf5TkOuGGSIvfQiTfutxAyK4F2dRqauVkx7b8?=
 =?us-ascii?Q?mHu0m8MMQ9MgnuWxwUBjPTy3egzx73xHhSHcJiU1glBGD/kIeuUemTJG8raa?=
 =?us-ascii?Q?yEJMU+t4trkMnVNj0Hj6kUWmqZm4x6xuCp9SH7R0u4Si8764GMYjP224FQb5?=
 =?us-ascii?Q?5bBxCNrBlkhQgtZ+4BZj3Jor2uXAvZPpOBrcN2ZBv4G5fTjzrHb2JRIqLdqv?=
 =?us-ascii?Q?drDyrJHAL+gIPuOL4EjYvR7PNNRZYILfy9/OQaaFsgrn2tHKqM7zXadVkOji?=
 =?us-ascii?Q?8ai1C5b/xmGzRG8rUmMW6zGd/5d5yVVaWfL1lE9IIlvlwFHxz1J5IN3jTl6x?=
 =?us-ascii?Q?mqgC3TMZyrfB0NB8rMPsAo05oT9D0NEfcvBXyerWnBM4n0qAxWFWCtcDFND2?=
 =?us-ascii?Q?W+ImA289v6pAhjF/4jU1oP3k0yTdRbX4iWAk61rNZjmPyBt5PgxNU6fowL9C?=
 =?us-ascii?Q?AVNRntAqk0YHRSqCmX/jgpPNhNTrbwmIxUdbcxJtsY0YlT9Qz8clM8OpFbSi?=
 =?us-ascii?Q?MjylaEzs48gIOB84NBRUzcIBXqB8MkhsuYk7UAipm5YBYaA5RoszznzytPwh?=
 =?us-ascii?Q?mt0HbFL4Uk8CF9+A19kw0PWAr1roV9Ehs2ID+0zKhKSGbwslUroCYRmRm3mi?=
 =?us-ascii?Q?gwAYdXsHcOPtf+KStnoWKVvt+gF4FouGdLnHcjH5ulVTnwNQaRQwsaJWAmKc?=
 =?us-ascii?Q?5d+i3GO1Ga/fH/mqYxOvNgouqc08a9nztMOzQYHj5Ln6V/N3OQ2r3dkJi2uB?=
 =?us-ascii?Q?dalFvfYcoaiirLyT4C0LH7xweq9JuFq2vzNhqK2ecfqFIGV5dGp5DXNKuwFF?=
 =?us-ascii?Q?Gu55j5vOAWg/QbRlZACc1lPJSdNpY5nD06KbU67jvGzWrLO2G1y+miNSsGBf?=
 =?us-ascii?Q?FTKUaqlv6cwrrCNLJx/rdM3e9rZgGl6aqDBtqafeUzaAHv6pDaWN8VluvBHA?=
 =?us-ascii?Q?kB919bvV7lMeLHWOvsXyXsQxJPhLu8+xOVddFwAYhwi5ymxiXq1wESYIMoQw?=
 =?us-ascii?Q?uhP2tJYtv71OxHaRSiafiZnxI33oAmb8wOjuUNcuQ58u5wmKgSKQ+mndm5yW?=
 =?us-ascii?Q?h78uRo+YLoG9Mb+D9QA0qhLM883XOv8t+9rK/9dmEpEpEXw/uLWoQHXoqR0O?=
 =?us-ascii?Q?83diLGhCvNYKJwLG7IaNAxfk7ou8XP578nVaJr7m?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf058292-f10e-47bf-c8e8-08dac2f44f67
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 08:19:38.9950
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w8otUT0GgzDNZQdYGJyYu7/fHYsbDDEcphAlMx6geJ3CrULfSE/d/R8d5QZrBrTosu8w5EC/kzPmKvN/cjZyVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8916
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

UARTBAUD_RDMAE and UARTBAUD_TDMAE are enabled in lpuart32_startup(), but
lpuart32_shutdown() not disable them, only free the dma ring buffer and
release the dma channels, so here disable the Rx/Tx DMA first in
lpuart32_shutdown().

Fixes: 42b68768e51b ("serial: fsl_lpuart: DMA support for 32-bit variant")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
Changes in V2:
1. Split one patch into four smaller patches to improve the commit
messages and add Fixes tag as suggested by Ilpo.
---
 drivers/tty/serial/fsl_lpuart.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index a6f7b056d57b..c297be11422a 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1769,6 +1769,11 @@ static void lpuart32_shutdown(struct uart_port *port)
 
 	spin_lock_irqsave(&port->lock, flags);
 
+	/* disable Rx/Tx DMA */
+	temp = lpuart32_read(port, UARTBAUD);
+	temp &= ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
+	lpuart32_write(port, temp, UARTBAUD);
+
 	/* disable Rx/Tx and interrupts */
 	temp = lpuart32_read(port, UARTCTRL);
 	temp &= ~(UARTCTRL_TE | UARTCTRL_RE | UARTCTRL_ILIE |
-- 
2.17.1