Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e3fc40c9-6e4e-d8de-63ce-ce34d78fa883@suse.cz>
Date:   Thu, 10 Nov 2022 10:40:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH] tools/vm/slabinfo: indicates the cause of the EACCES
 error
Content-Language: en-US
To:     Rong Tao <rtoax@foxmail.com>, akpm@linux-foundation.org
Cc:     Rong Tao <rongtao@cestc.cn>,
        =?UTF-8?Q?St=c3=a9phane_Graber?= <stgraber@ubuntu.com>,
        Yuanzheng Song <songyuanzheng@huawei.com>,
        linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>,
        David Rientjes <rientjes@google.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Pekka Enberg <penberg@kernel.org>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        Roman Gushchin <roman.gushchin@linux.dev>
References: <tencent_C9D7A6D118445E036021CE2CB4CB4495E207@qq.com>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <tencent_C9D7A6D118445E036021CE2CB4CB4495E207@qq.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/8/22 13:47, Rong Tao wrote:
> From: Rong Tao <rongtao@cestc.cn>
> 
> If you don't run slabinfo with a superuser, return 0 when read_slab_dir()
> reads get_obj_and_str("slabs", &t), because fopen() fails (sometimes
> EACCES), causing slabcache() to return directly, without any error during
> this time, we should tell the user about the EACCES problem instead of
> running successfully($?=0) without any error printing.
> 
>  For example:
>  $ ./slabinfo
>  Permission denied, Try using superuser  <== What this submission did
>  $ sudo ./slabinfo
>  Name            Objects Objsize   Space Slabs/Part/Cpu  O/S O %Fr %Ef Flg
>  Acpi-Namespace     5950      48  286.7K         65/0/5   85 0   0  99
>  Acpi-Operand      13664      72  999.4K       231/0/13   56 0   0  98
>  ...
> 
> Signed-off-by: Rong Tao <rongtao@cestc.cn>

Thanks, added to slab.git slab/for-6.2/tools

> ---
>  tools/vm/slabinfo.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
> index 0fffaeedee76..cfaeaea71042 100644
> --- a/tools/vm/slabinfo.c
> +++ b/tools/vm/slabinfo.c
> @@ -157,9 +157,11 @@ static unsigned long read_obj(const char *name)
>  {
>  	FILE *f = fopen(name, "r");
>  
> -	if (!f)
> +	if (!f) {
>  		buffer[0] = 0;
> -	else {
> +		if (errno == EACCES)
> +			fatal("%s, Try using superuser\n", strerror(errno));
> +	} else {
>  		if (!fgets(buffer, sizeof(buffer), f))
>  			buffer[0] = 0;
>  		fclose(f);