Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Nov 2022 10:28:55 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Jacob Bai <jacob.bai.au@gmail.com>
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] staging: rtl8192e: rename r8192E_hwimg.c/h to
 table.c/h
Message-ID: <Y2zEV0kBNSKLBXDt@kroah.com>
References: <cover.1667723306.git.jacob.bai.au@gmail.com>
 <9bb563727915e3f3edd863837608336b99564462.1667723306.git.jacob.bai.au@gmail.com>
 <Y2p0dNLBqiWFPzB9@kroah.com>
 <Y2yt6ERX3szKn2W7@jacob-Ubuntu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y2yt6ERX3szKn2W7@jacob-Ubuntu>
Precedence: bulk

On Thu, Nov 10, 2022 at 06:53:12PM +1100, Jacob Bai wrote:
> On Tue, Nov 08, 2022 at 04:23:32PM +0100, Greg KH wrote:
> > On Sun, Nov 06, 2022 at 07:31:17PM +1100, Jacob Bai wrote:
> > > Same as other rtlwifi drivers, use table.c/h.
> > 
> > You say what you do here, but not why.
> > 
> > Why rename the file?  What's wrong with the existing name?  It's not
> > causing any problems, right?
> > 
> > thanks,
> > 
> > greg k-h
> >
> No, it's not causing problems. As we are trying to move this driver out
> of staging folder, so I checked how current drivers naming
> files/variables, turns out they all named those two files as table.c/h.
> Maybe we can do the file renaming as the last step.

There are lots of other issues in this driver to cause it not to be able
to be moved out of staging at the moment.  The name of these files is
not one of those issues from what I can tell.

thanks,

greg k-h