Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <63635101-df2d-c698-6112-8db2e747a95c@intel.com>
Date:   Thu, 10 Nov 2022 01:40:46 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v2 10/14] platform/x86/intel/ifs: Add metadata validation
Content-Language: en-US
To:     "Joseph, Jithu" <jithu.joseph@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-11-jithu.joseph@intel.com>
 <a0f6723b-ecfa-ba5b-5779-c7326cd31a86@intel.com>
 <6b98f0ef-8529-43eb-1774-ba81c0bb0839@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <6b98f0ef-8529-43eb-1774-ba81c0bb0839@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnNzNDV0RG1xVHR3VXBIZXZHTkExSVRhemE4QzRneXoza0UyY0lodng2OUxl?=
 =?utf-8?B?b1JzYzBkRHRNUGF1M3hkYlNNeTU2N0FaSmZwK2x6aEdDY0M0MjEwVndlUUJB?=
 =?utf-8?B?ZHFZUnEvOWhYcmtWM1htUWNORFlyQ0RmVlJnSlpQMHgzaUNlSVkrSUJBZmt4?=
 =?utf-8?B?QmdjWWxxWGNBYXZveHZYSVNsc0xhVUxZY1JWb3EwRG15T1NxbVNjNkFYNDRv?=
 =?utf-8?B?bDBHKzNmTjBYT2VtcXJ5b2FuN2RDR0dYcG1pOEF6NkpzYk51cnEra25GaUZj?=
 =?utf-8?B?NFRzbTE2enU2eWdVNlpvMU1LL0phSDhJd1E0Qnk4TFMzZy91V0NIcVBzWWJv?=
 =?utf-8?B?MkIzNlZ1ZTQ0VkladVZEcFIrZTBBTm1xTGtGSmRidFNJdHJvQ0RVWlNrMFlT?=
 =?utf-8?B?SmF0aDRpWWI3VE1JZ245N3J3MURBdjNFYzFHZVZHMUk0NCtGTFJGSjlvMGhE?=
 =?utf-8?B?ZUMyTUs5cVpGaVYvVml5NGdWQXN0RVIrZjcvSjFVV2J2KzJUQzdFL3M2WmEr?=
 =?utf-8?B?UmV2OGVtbUErbHRYYXhZNi9FeW9DVFd3UFNDSDdVMjdPb2cxT1ZSMWFlVmcv?=
 =?utf-8?B?MUUzMEhSRkdUeGtQZ1VxODlqYWdsL2R6a1o2dHJuOUZDbkdEK1pCTkdCWjNN?=
 =?utf-8?B?aVJWWmJ6VTVwZklnVUNCYXZ4WStMaWpDYmVWbkxPZGlVRjVHWVNGWHc4bWxW?=
 =?utf-8?B?Slg4NGh5dG1MM3B5VVN2WkxUSFFBUFJocUJ2QlVlRXdxUVJBUS9tUHZlY21E?=
 =?utf-8?B?M1Q4amVUTmVaZUdqWDAxMytEWVpBSTRHSXFJWkpQVzY3Y0xuL0g4UVAxaElo?=
 =?utf-8?B?VklmMkt1OWVpWVgxanViSTZxNXpNQkw3OGN5MFJyWWRiRDdtRXovRVk4Z3RV?=
 =?utf-8?B?MEI3Nk42emV0NU16RWhVdHFLTDlTa1kzOVhFdHM4TzRIYmdhYXhkL201Zk14?=
 =?utf-8?B?SDZseE1zT1pJYlFObGdOSm84WEVwMFR2Y3NYNG5XR0tHN2V0OHR6QndFOE5l?=
 =?utf-8?B?blArSllENUtHNmJTTnNxZlluaUkrbHduS0ZSdU5PbXV3U2g3cURUUGFGa3pz?=
 =?utf-8?B?SVpVV1EzbUVQaWdiLzRTWkNpZ21STXpwZzhrTE1iTmFmck5YaWwrb3Q3Tkdr?=
 =?utf-8?B?S2FpOXIranI4NlNsZFgzOUQ3MTlqKzZGVkg4NkJZZ2c2WlA4VHUrdEZJL2NY?=
 =?utf-8?B?L01QbGcrQUtRMUpqR2E4Z1ZvbVNoNkhEREVaQW9kYk5KSFFMdmFCUWZuZWYy?=
 =?utf-8?B?NU5VeFdUUitoZzU3Zi9nQXpjYlNFRVZGL3ZPNE4wL2V0d1hUb0ZzV1hkYjNY?=
 =?utf-8?B?Smp6bDlnQzVPOE5MUHgreUJMWkI5UTZNU1hPSjBZZUFrMU5ZQXkwbXRRbElI?=
 =?utf-8?B?V1NSWWJMMlZCY3Z2YnM3UGtFNHM3TkhZck5iM2ZBNEVKYmc4R0tjczh0NlBS?=
 =?utf-8?B?NFk0REp0N1FCSzQ0dGV4c1c5cFZXQUxLKzh2N1hXSWVKd0Z4eW8xZFNweEQv?=
 =?utf-8?B?dDhpZ0RJWGplNENkd1EwNyt4cmxMWTQ2Ym1FaDMvbStFQjFjcHl4YklnaUtT?=
 =?utf-8?B?RlFnL3h4cVJZOThqK21jdFQ0R1dhSzc2TDhsakt6V1Z6S3pCTzlBMkZ2b1M1?=
 =?utf-8?B?RXRNYlh5MklobFBTekNzaE9lNGVkVmE0RHIzeGhDdFBPTjZWKzZ1dks5VHJh?=
 =?utf-8?B?QU5FRklEUCt6OTRUUkFFS2NyMU4wZDduOUM0VG44QVRvNVNINlNkV2RSaU0r?=
 =?utf-8?B?bVVmSDBmcDJNM0hKZFdyQmJiaFhCN0hERllwTTRpaWtlSDVaQXV6c0RMeXJz?=
 =?utf-8?B?L2Y3M3NSZE5RdHZkdmNGd0cyZURNRTZwTEJibVhNRk1ObUdabGkzb1NzeVRM?=
 =?utf-8?B?NG1LTkVIaUhwY2dHWldlS2hnMmxmTjY1ZWVKMEVaZnRsd3Z6dkRUVDByOFpW?=
 =?utf-8?B?ay9BWWQ4T1ZLTzB5ek5jRmt4Qm5aMDk0M3hOV1daa0NQVUErR3VNZ1pkTnFG?=
 =?utf-8?B?cy9FRXpaVHU0aTlSWTJXdXdDSmFwL3hWN2VHUE1xTW1KVU5wTW9iVGNBVHpy?=
 =?utf-8?B?QTViQ1FuY2RKZU5SaEhDalpqYzdKSkZkdm43dG9Id250N3lXQkttZDJQenVn?=
 =?utf-8?Q?0B5Fd4PPdzxcTHQWjd1gNMXLm?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 701bb734-6833-41d1-3622-08dac2ffa622
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 09:40:48.8086
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uwOzzRQHPAMAjIp9/o3Eh5ExTYc4Zv5oOvt3Ep2Ztwt6mwe4dR3r+Nh1r+jSxvFwKmZQIrni5HzAFrIvX9Y+Ag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6463
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/9/2022 5:22 PM, Joseph, Jithu wrote:

> Here is the layout of the metadata section in an IFS test image.
> Test Data (chunks) follow the struct meta_data  defined in load.c
> 

Thanks, this helps clarify things around the test data placement in this 
patch. I think it would be useful to include the below information in 
the commit message as well.

Given that,

Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>

>      IFS Metadata layout
>     +----------------------+  0
>     |META_TYPE_IFS (=1)    |
>     +----------------------+
>     |meta_size             |
>     +----------------------+
>     |test type             |
>     +----------------------+
>     |fusa info             |
>     +----------------------+
>     |total images          |
>     +----------------------+
>     |current image#        |
>     +----------------------+
>     |total chunks          |
>     +----------------------+
>     |starting chunk        |
>     +----------------------+
>     |size per chunk        |
>     +----------------------+
>     |chunks per stride     |
>     +----------------------+
>     |Reserved[54]          |
>     +----------------------+ 256
>     |                      |
>     |                      |
>     |                      |
>     |                      |
>     |Test Data/Chunks      |
>     |                      |
>     |                      |
>     |                      |
>     |                      |
>     +----------------------+  meta_size
>     |   META_TYPE_END (=0) |
>     +----------------------+  meta_size + 4
>     |   size of end (=8)   |
>     |                      |
>     +----------------------+  meta_size + 8
> 
> 
> Jithu