Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221108142226.63161-1-andriy.shevchenko@linux.intel.com>
 <20221108142226.63161-2-andriy.shevchenko@linux.intel.com> <20221110070718.bqpam7h3hjf2hkip@pengutronix.de>
In-Reply-To: <20221110070718.bqpam7h3hjf2hkip@pengutronix.de>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 10 Nov 2022 11:54:46 +0200
Message-ID: <CAHp75VcQ98Rxxq4Zw0AAp8rEtRg7oAb_eR_hyMFRx7AQnCifCw@mail.gmail.com>
Subject: Re: [PATCH v2 1/6] pwm: Add a stub for devm_pwmchip_add()
To:     =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-pwm@vger.kernel.org, Andy Shevchenko <andy@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Nov 10, 2022 at 9:07 AM Uwe Kleine-K=C3=B6nig
<u.kleine-koenig@pengutronix.de> wrote:
> On Tue, Nov 08, 2022 at 04:22:21PM +0200, Andy Shevchenko wrote:

...

> > +static inline int devm_pwmchip_add(struct device *dev, struct pwm_chip=
 *chip)
> > +{
> > +     return -EINVAL;
> > +}
> > +
>
> I'm a bit surprised to see this returning -EINVAL and not -ENOSYS. But
> that's in line with the other stubs, so:

Exactly my thoughts when I created such a change.

> Acked-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>

Thank you!

--=20
With Best Regards,
Andy Shevchenko