Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp505188rwb; Thu, 10 Nov 2022 04:01:58 -0800 (PST) X-Google-Smtp-Source: AMsMyM6+TDPQPFgNMNgweLCMyHZldzJOTMMZgbUlqom6cqhLEVvKJFyy+Zae5xJlVNCYr0FQtFA3 X-Received: by 2002:a17:902:ab15:b0:187:734:96a1 with SMTP id ik21-20020a170902ab1500b00187073496a1mr62388801plb.4.1668081718307; Thu, 10 Nov 2022 04:01:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668081718; cv=none; d=google.com; s=arc-20160816; b=GU5Md3S7Xx9rCSAbaQqCZRovopmHvbCGaMkClU66M/on6bahEG4v4i3qX+0W52e1ct F0j2mhmhCSqKZk3pAp7xdXG3U4/85ZCcbcEEEJfSHGYF+iow31GFY13ot8ujnwFb5wzm fTnBDrMtJre1elNqhojCfHOx+hWlHJsLucTRjezGX3XnLgk52MibNB+s/R/Cm93mgaQt YvBWBlRgUHscv0OVtUuXqcBCzLfIc10WuAEqlNcd5CvgnCbolD/uRw96q9idzbP7Ak3/ NHsmnmTDoASmiY80NQQTbUifyOFuns8ep5G6l7+ogIOk9x3hnMfVPj3zrJ69DXvKxUX0 /TRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=M/bfkY3he+z+54lCAwGOvId+BMfqdZ1/lFx/xUS+yX4=; b=qyRcJTeH6pAecWAQWHOp7D80qXaqaHJ0d86kwgocBY+ZQnPnKdcEkewXj2lSNTVIlq eC4EK1FnDmqVslYXCb1vM0PImE1IC/I+hMZyE+MP4NygNNYTdYf3D5VOJnQTDnJfwtfm QqFWl9wrQK+IB7hIR3mlCrptkPJBZDxl4CxlyET0bjEFUxZ7VWBHvHZxhmyrc8bl6Mlr KSyynvmqs4WfginpGq6UJaG3Negvswwpow1WoQ73vyzdut3fi+zKNuVqLfBQIy427X9n M88hFozSBb1k0bBc98M2I7+MHuTk20qKnLamoIw9hfWJeMQVZXT2GzB7F71X2zw//DB3 k+eQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Kge9KkGp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b140-20020a621b92000000b0056b8f6cd527si16510611pfb.61.2022.11.10.04.01.40; Thu, 10 Nov 2022 04:01:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Kge9KkGp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229827AbiKJLYc (ORCPT + 92 others); Thu, 10 Nov 2022 06:24:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229575AbiKJLYa (ORCPT ); Thu, 10 Nov 2022 06:24:30 -0500 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66A5753EDA; Thu, 10 Nov 2022 03:24:30 -0800 (PST) Received: by mail-ot1-x336.google.com with SMTP id p8-20020a056830130800b0066bb73cf3bcso919605otq.11; Thu, 10 Nov 2022 03:24:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=M/bfkY3he+z+54lCAwGOvId+BMfqdZ1/lFx/xUS+yX4=; b=Kge9KkGpGIjiOCRlbWdZnt3Tp398py3Z/sQgzSTP/8EhYFNkjV3Ycjr2dgN5crbGfG qNJVu/hxqFSigFzNaXOERuEXwVq9nrwMjBCQjpEw3o5vmER+pQQpWg4l/xJABvJyWF5J dYdu1IvzGWLnh+13kvTR8c/3yfTnBoxQ1U/oQ9f5zwzSpXNFiGxZMkW4sJ0M8EEiKvcz 7kbCEklSDPtFfgDOf/EiOdGn4m+sqBi2eFwFy0kB7oohdJFe6txXF9C2U6vWEvo62nEd C1e9gNzW9xVBr3d7ESQqa1fjXoYeYLf0b8WkWI08vaWUs5pq6wY9k+38qD84ICz7wZpu mM7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M/bfkY3he+z+54lCAwGOvId+BMfqdZ1/lFx/xUS+yX4=; b=Q8hGMiLGoHFuNfNQiAbdzu5QX80Yt+ETScOBB3zfrfEKbW43EH+Tor+7fYco2jhY0/ BZxxHE17sSIJBaX0ZjKUPTG4Qj3fM7mJW7HsVuht0NQYhJDgRRLaUvrKypE28uAdymBK ePD37cJbt+Qy/Pk6Dh57RUAZ11j3TdotFO3x9xsMNFaCPndSEf/QLQYpWLUjdDWbgugK k9q71Otgzi1ONWhM85GlEXdSv3oDppYXiBPnhHitrez0gHO5oL20+6vZmsdul43bmUA5 6g+JvqDmTIznsijeulDu/vmVVkmawUH8CRaJVzqzKOr1veGsOHVA4olO6vLDxKQbsSA3 Um8A== X-Gm-Message-State: ACrzQf0dWytYRMFVIhu5AxlQgrQE+zTNXfrPkkO6xpoplgTTy8/l+DHi /a96dqHhRNIaY+EolQwcDYYPshPlOSDMBd/34XJ90eyYxdc= X-Received: by 2002:a9d:6aca:0:b0:655:e3c3:f66c with SMTP id m10-20020a9d6aca000000b00655e3c3f66cmr1304816otq.344.1668079469730; Thu, 10 Nov 2022 03:24:29 -0800 (PST) MIME-Version: 1.0 References: <20221110031311.1629288-1-linmq006@gmail.com> <67a1782c-9b7d-055a-5e62-456294cb4401@redhat.com> In-Reply-To: <67a1782c-9b7d-055a-5e62-456294cb4401@redhat.com> From: Ilya Dryomov Date: Thu, 10 Nov 2022 12:24:16 +0100 Message-ID: Subject: Re: [PATCH] ceph: Fix NULL vs IS_ERR checking in ceph_getattr To: Xiubo Li Cc: Miaoqian Lin , Jeff Layton , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2022 at 6:45 AM Xiubo Li wrote: > > Hi Miaoqian, > > Thanks for your patch. This has already been fixed by Dan Carpenter > weeks ago and already in the ceph-client's testing branch, please see [1]: > > [1] > https://github.com/ceph/ceph-client/commit/ffc4d66a34bb5bd76d0a3f83bebf500d96a8e37c It's also present in linux-next: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ffc4d66a34bb5bd76d0a3f83bebf500d96a8e37c Thanks, Ilya