Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Vivek Yadav" <vivek.2311@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        <rcsekar@samsung.com>, <krzysztof.kozlowski+dt@linaro.org>,
        <wg@grandegger.com>, <mkl@pengutronix.de>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <pankaj.dubey@samsung.com>, <ravi.patel@samsung.com>,
        <alim.akhtar@samsung.com>, <linux-fsd@tesla.com>,
        <robh+dt@kernel.org>
Cc:     <linux-can@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <aswani.reddy@samsung.com>, <sriranjani.p@samsung.com>
In-Reply-To: <709daf8b-a58e-9247-c5d8-f3be3e60fe70@linaro.org>
Subject: RE: [PATCH v2 1/6] dt-bindings: Document the SYSREG specific
 compatibles found on FSD SoC
Date:   Thu, 10 Nov 2022 16:48:03 +0530
Message-ID: <000001d8f4f6$1c7e96e0$557bc4a0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQFejcOECimRbNc2gYBlewkpfd/ZqQHz7ogqAVwjo3kCSHwOh68AC28Q
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20221109100928.109478-1-vivek.2311@samsung.com>
        <CGME20221109100245epcas5p38a01aed025f491d39a09508ebcdcef84@epcas5p3.samsung.com>
        <20221109100928.109478-2-vivek.2311@samsung.com>
        <709daf8b-a58e-9247-c5d8-f3be3e60fe70@linaro.org>
Precedence: bulk


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski=40linaro.org>
> Sent: 09 November 2022 16:39
> To: Vivek Yadav <vivek.2311=40samsung.com>; rcsekar=40samsung.com;
> krzysztof.kozlowski+dt=40linaro.org; wg=40grandegger.com;
> mkl=40pengutronix.de; davem=40davemloft.net; edumazet=40google.com;
> kuba=40kernel.org; pabeni=40redhat.com; pankaj.dubey=40samsung.com;
> ravi.patel=40samsung.com; alim.akhtar=40samsung.com; linux-fsd=40tesla.co=
m;
> robh+dt=40kernel.org
> Cc: linux-can=40vger.kernel.org; netdev=40vger.kernel.org; linux-
> kernel=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org; linux-
> samsung-soc=40vger.kernel.org; devicetree=40vger.kernel.org;
> aswani.reddy=40samsung.com; sriranjani.p=40samsung.com
> Subject: Re: =5BPATCH v2 1/6=5D dt-bindings: Document the SYSREG specific
> compatibles found on FSD SoC
>=20
> On 09/11/2022 11:09, Vivek Yadav wrote:
> > From: Sriranjani P <sriranjani.p=40samsung.com>
> >
>=20
> Use subject prefixes matching the subsystem (git log --oneline -- ...).
>=20
Okay, I will add the correct prefixes.
> > Describe the compatible properties for SYSREG controllers found on FSD
> > SoC.
>=20
> This is ARM SoC patch, split it from the patchset.
>
I understand this patch is not to be subset of CAN patches, I will send the=
se patches separately.
These patches will be used by EQos patches. As per reference, I am adding t=
he Address link.
https://lore.kernel.org/all/20221104120517.77980-1-sriranjani.p=40samsung.c=
om/
=20
> >
> > Signed-off-by: Alim Akhtar <alim.akhtar=40samsung.com>
> > Signed-off-by: Pankaj Kumar Dubey <pankaj.dubey=40samsung.com>
> > Signed-off-by: Ravi Patel <ravi.patel=40samsung.com>
> > Signed-off-by: Vivek Yadav <vivek.2311=40samsung.com>
> > Cc: devicetree=40vger.kernel.org
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt=40linaro.org>
> > Cc: Rob Herring <robh+dt=40kernel.org>
>=20
> Drop the Cc list from commit log. It's not helpful.
>=20
Okay, I will remove.
> > Signed-off-by: Sriranjani P <sriranjani.p=40samsung.com>
> > ---
> >  .../devicetree/bindings/arm/tesla-sysreg.yaml =7C 50
> +++++++++++++++++++
> >  MAINTAINERS                                   =7C  1 +
> >  2 files changed, 51 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/arm/tesla-sysreg.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml
> > b/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml
> > new file mode 100644
> > index 000000000000..bbcc6dd75918
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml
>=20
> arm is only for top level stuff. This goes to soc under tesla or samsung
> directory.
>=20
Okay, this is specific to Samsung fsd SoC, I will be moving this file to ar=
m/samsung in next patch series. Hope that is fine.
> > =40=40 -0,0 +1,50 =40=40
> > +=23 SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
> > +---
> > +=24id:
> > +https://protect2.fireeye.com/v1/url?k=3D1ad2834a-7b59967c-1ad30805-
> 000b
> > +abff9b5d-1f65584e412e916c&q=3D1&e=3Da870a282-632a-4896-ae53-
> 3ecb50f02be5&
> > +u=3Dhttp%3A%2F%2Fdevicetree.org%2Fschemas%2Farm%2Ftesla-
> sysreg.yaml%23
> > +=24schema:
> > +https://protect2.fireeye.com/v1/url?k=3D13876e33-720c7b05-1386e57c-
> 000b
> > +abff9b5d-edae3ff711999305&q=3D1&e=3Da870a282-632a-4896-ae53-
> 3ecb50f02be5&
> > +u=3Dhttp%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23
> > +
> > +title: Tesla Full Self-Driving platform's system registers
> > +
> > +maintainers:
> > +  - Alim Akhtar <alim.akhtar=40samsung.com>
> > +
> > +description: =7C
> > +  This is a system control registers block, providing multiple low
> > +level
> > +  platform functions like board detection and identification,
> > +software
> > +  interrupt generation.
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
>=20
> No need for oneOf.
>=20
Removing this results into dt_binding_check error, so this is required.
> > +      - items:
> > +          - enum:
> > +              - tesla,sysreg_fsys0
> > +              - tesla,sysreg_peric
>=20
> From where did you get underscores in compatibles?
>=20
I have seen in MCAN Driver <drivers/net/can/m_can/m_can_platform.c> and als=
o too many other yaml files.
Do you have any ref standard guideline of compatible which says underscore =
is not allowed.
> > +          - const: syscon
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - =7C
> > +    soc =7B
> > +      =23address-cells =3D <2>;
> > +      =23size-cells =3D <2>;
> > +
> > +      sysreg_fsys0: system-controller=4015030000 =7B
> > +            compatible =3D =22tesla,sysreg_fsys0=22, =22syscon=22;
>=20
> Use 4 spaces for example indentation.
>=20
Okay I will make it 4 spaces indentation.
> > +            reg =3D <0x0 0x15030000 0x0 0x1000>;
> > +      =7D;
> > +
> > +      sysreg_peric: system-controller=4014030000 =7B
> > +            compatible =3D =22tesla,sysreg_peric=22, =22syscon=22;
> > +            reg =3D <0x0 0x14030000 0x0 0x1000>;
> > +      =7D;
>=20
> One example is enough, they are the same.
kay  I will remove 1 example.
> > +    =7D;
> > diff --git a/MAINTAINERS b/MAINTAINERS index
> > a198da986146..56995e7d63ad 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > =40=40 -2943,6 +2943,7 =40=40 M:	linux-fsd=40tesla.com
> >  L:	linux-arm-kernel=40lists.infradead.org (moderated for non-
> subscribers)
> >  L:	linux-samsung-soc=40vger.kernel.org
> >  S:	Maintained
> > +F:	Documentation/devicetree/bindings/arm/tesla-sysreg.yaml
> >  F:	arch/arm64/boot/dts/tesla*
> >
> >  ARM/TETON BGA MACHINE SUPPORT
>=20
> Best regards,
> Krzysztof

Thanks for reviewing the patches.