Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Nov 2022 20:57:23 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Vlastimil Babka <vbabka@suse.cz>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        "Dmitry Vyukov" <dvyukov@google.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        "Kees Cook" <keescook@chromium.org>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kasan-dev@googlegroups.com" <kasan-dev@googlegroups.com>
Subject: Re: [PATCH v7 1/3] mm/slub: only zero requested size of buffer for
 kzalloc when debug enabled
Message-ID: <Y2z1M4zc2Re5Fsdl@feng-clx>
References: <20221021032405.1825078-1-feng.tang@intel.com>
 <20221021032405.1825078-2-feng.tang@intel.com>
 <09074855-f0ee-8e4f-a190-4fad583953c3@suse.cz>
 <Y2xuAiZD9IEMwkSh@feng-clx>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y2xuAiZD9IEMwkSh@feng-clx>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YGfyzronEWuA+Wtk+kd6mixXg5T0ckCbTivo2ZCF+15u3BWbjIo17w6cXe01?=
 =?us-ascii?Q?f71RdNoVRswB1bNZq+KkfQNcKEt9olE0Wjrk8J4k3Q4o3C5dmpsnneqGdSvy?=
 =?us-ascii?Q?KUQKEKtDzfCjypltPZ/XpeZbueEhPuzGa2UfhT0wLUK6ivCe6ZgvLk4qjU8M?=
 =?us-ascii?Q?q4TAN+9Hid+ObmQPVoo2IaLlC5pSqAQ4WexaaH04KpKqXc0qFmQHy8GW8cKF?=
 =?us-ascii?Q?/m3Se64mO74Biim+01gt+sbBUtYr2ptnmtNWFP1Ap01zhO9UTrtJMfx2cJiJ?=
 =?us-ascii?Q?ZgkqQQGRWEFzjrkmhDiqHnCDMJp5Qf7FTp1ncHP9cZekP047qKb6yqHx2Xfy?=
 =?us-ascii?Q?eDda635aiQkbp5NsuuEOPQTdzgkPc3YtjYK9kt66bW07km5C8RGWOaq1yCEY?=
 =?us-ascii?Q?jsafk8sqFV2YFmGb4t8L88FIrrRBZvTn8oYAMD01SRhWWieKr3GSg3PVlzE0?=
 =?us-ascii?Q?IQr5Mo13kS/JpIBbJXeVBdLIrivNC5Q2uLf7LMC5efRNGzaBbAUZg3tO2A6c?=
 =?us-ascii?Q?32tc0hZrxa3f+JrFby4Bk5f8TRIEDLh5prEx3j/P4Um7muKOzhFIw7tNt2Di?=
 =?us-ascii?Q?+LHn2LrLYbr21furmSYJjSv82zIGwjbAOfFAmAu7zXAP7M36MbaMcRLYRU/a?=
 =?us-ascii?Q?K19CHvYxZWPv9Nv2Kxrns6zX7z7xgpYp4EGQZgBRD3folBxYHOd+5roVGEDH?=
 =?us-ascii?Q?lqy3/SumUZRYzsa8XZEi16l7SRXzwuiDRY9W/jCnKmkWH3V4+NJ4rShT9C0w?=
 =?us-ascii?Q?69Wes7hitStcNvZYXxaxXh2M6b6TS7JF5ezruNshn0FVo3hSvRDMQ541KCzo?=
 =?us-ascii?Q?Ldg6CRmoqvNInSz1NE6so0MCyUd8wiXcnPu7szERgg8Q110IVn4Esc/kI1jU?=
 =?us-ascii?Q?3NOdcwWLDwkj6ZNOSnTKYIP0eqD464+sH4cWR0QVG5ME82KTKnwlfqquX8zI?=
 =?us-ascii?Q?QFujmvD2ViOsZNnqzNlq1p6e4ftGQHDsRSJi0dnpwg+z9XZmvpjeOdLVqgKP?=
 =?us-ascii?Q?mKMXYw25vXMYMTeFhVhy9NHBxDuMIt1ANA43AsOpyMXFBP/6LfGSI2N4xKHw?=
 =?us-ascii?Q?yqpKNB5oHCmbZgt17bs8a7/BLYKLBZ/0Ee48eUbkvVMCj4q/1CAHZB29zEJ6?=
 =?us-ascii?Q?WAtlQQojhPQ0V1VPjO1iCrfIxBkKnQgG2HXCanHhHRc7vFZ507ddj0vKdjEU?=
 =?us-ascii?Q?xCnKA05XTU2lzEPforb2P3ZB5xwnz+uETrEQOrpC+v6j5vn8v8/5nlf38PB/?=
 =?us-ascii?Q?B3Sfe+Qj57ugZvAZeBoSAtis6G0kcRFiP5wPyvVUvO1KCwBht2i/qvDADZoY?=
 =?us-ascii?Q?7PyPDxrNKioOg2Mz0u9yDH6PrQ2HeVThJwLrzXnu1A9VqVEM3SA0dgDmAF+u?=
 =?us-ascii?Q?mhISER1tfMDgh0wCkaOkIaXhBTKABzI0JEcUQTa7eIyQKBvRUWFzPm5dUw3e?=
 =?us-ascii?Q?G/c5vP8/HTl6mpSgXjnkUqAhNbGdfSXXfKHcCVMz4VVSjmp7yQUJDHxAsp79?=
 =?us-ascii?Q?lujxsRFAcrJrRJZFjbFKhbJaZTPkbnNVR1d0KDal+SD/NVHxEg7cMGyOLBxz?=
 =?us-ascii?Q?PS/OFuGkvRJd6dvr1UTOyuKQVBZTvPuqfj/LBvb6?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e0271127-6c89-4a12-65a8-08dac31b90a7
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 13:00:38.7268
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8L6/duzjLYNsZWgtPtwD1qcTmIcg0xxc/U+zUmF60ZPIxVT9YrDXii7dzYqii2PYKE0q9ntkkq64p1NtvvWR9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6324
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 10, 2022 at 11:20:34AM +0800, Tang, Feng wrote:
> On Wed, Nov 09, 2022 at 03:28:19PM +0100, Vlastimil Babka wrote:
[...]
> > > +	/*
> > > +	 * For kmalloc object, the allocated memory size(object_size) is likely
> > > +	 * larger than the requested size(orig_size). If redzone check is
> > > +	 * enabled for the extra space, don't zero it, as it will be redzoned
> > > +	 * soon. The redzone operation for this extra space could be seen as a
> > > +	 * replacement of current poisoning under certain debug option, and
> > > +	 * won't break other sanity checks.
> > > +	 */
> > > +	if (kmem_cache_debug_flags(s, SLAB_STORE_USER) &&
> > 
> > Shouldn't we check SLAB_RED_ZONE instead? Otherwise a debugging could be
> > specified so that SLAB_RED_ZONE is set but SLAB_STORE_USER?
> 
> Thanks for the catch!
> 
> I will add check for SLAB_RED_ZONE. The SLAB_STORE_USER is for
> checking whether 'orig_size' field exists. In earlier discussion,
> we make 'orig_size' depend on STORE_USER, https://lore.kernel.org/lkml/1b0fa66c-f855-1c00-e024-b2b823b18678@suse.cz/ 

Below is the updated patch, please review, thanks! 

- Feng

-----8>----
From b2a92f0c2518ef80fcda340f1ad37b418ee32d85 Mon Sep 17 00:00:00 2001
From: Feng Tang <feng.tang@intel.com>
Date: Thu, 20 Oct 2022 20:47:31 +0800
Subject: [PATCH 1/3] mm/slub: only zero requested size of buffer for kzalloc
 when debug enabled

kzalloc/kmalloc will round up the request size to a fixed size
(mostly power of 2), so the allocated memory could be more than
requested. Currently kzalloc family APIs will zero all the
allocated memory.

To detect out-of-bound usage of the extra allocated memory, only
zero the requested part, so that redzone sanity check could be
added to the extra space later.

For kzalloc users who will call ksize() later and utilize this
extra space, please be aware that the space is not zeroed any
more when debug is enabled. (Thanks to Kees Cook's effort to
sanitize all ksize() user cases [1], this won't be a big issue).

[1]. https://lore.kernel.org/all/20220922031013.2150682-1-keescook@chromium.org/#r
Signed-off-by: Feng Tang <feng.tang@intel.com>
Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
---
 mm/slab.c |  7 ++++---
 mm/slab.h | 19 +++++++++++++++++--
 mm/slub.c | 10 +++++++---
 3 files changed, 28 insertions(+), 8 deletions(-)

diff --git a/mm/slab.c b/mm/slab.c
index 4b265174b6d5..1eddec4a50e4 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3258,7 +3258,8 @@ slab_alloc_node(struct kmem_cache *cachep, struct list_lru *lru, gfp_t flags,
 	init = slab_want_init_on_alloc(flags, cachep);
 
 out:
-	slab_post_alloc_hook(cachep, objcg, flags, 1, &objp, init);
+	slab_post_alloc_hook(cachep, objcg, flags, 1, &objp, init,
+				cachep->object_size);
 	return objp;
 }
 
@@ -3511,13 +3512,13 @@ int kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, size_t size,
 	 * Done outside of the IRQ disabled section.
 	 */
 	slab_post_alloc_hook(s, objcg, flags, size, p,
-				slab_want_init_on_alloc(flags, s));
+			slab_want_init_on_alloc(flags, s), s->object_size);
 	/* FIXME: Trace call missing. Christoph would like a bulk variant */
 	return size;
 error:
 	local_irq_enable();
 	cache_alloc_debugcheck_after_bulk(s, flags, i, p, _RET_IP_);
-	slab_post_alloc_hook(s, objcg, flags, i, p, false);
+	slab_post_alloc_hook(s, objcg, flags, i, p, false, s->object_size);
 	kmem_cache_free_bulk(s, i, p);
 	return 0;
 }
diff --git a/mm/slab.h b/mm/slab.h
index 8c4aafb00bd6..2551214392c7 100644
--- a/mm/slab.h
+++ b/mm/slab.h
@@ -730,12 +730,27 @@ static inline struct kmem_cache *slab_pre_alloc_hook(struct kmem_cache *s,
 
 static inline void slab_post_alloc_hook(struct kmem_cache *s,
 					struct obj_cgroup *objcg, gfp_t flags,
-					size_t size, void **p, bool init)
+					size_t size, void **p, bool init,
+					unsigned int orig_size)
 {
+	unsigned int zero_size = s->object_size;
 	size_t i;
 
 	flags &= gfp_allowed_mask;
 
+	/*
+	 * For kmalloc object, the allocated memory size(object_size) is likely
+	 * larger than the requested size(orig_size). If redzone check is
+	 * enabled for the extra space, don't zero it, as it will be redzoned
+	 * soon. The redzone operation for this extra space could be seen as a
+	 * replacement of current poisoning under certain debug option, and
+	 * won't break other sanity checks.
+	 */
+	if (kmem_cache_debug_flags(s, SLAB_STORE_USER) &&
+	    (s->flags & SLAB_RED_ZONE) &&
+	    (s->flags & SLAB_KMALLOC))
+		zero_size = orig_size;
+
 	/*
 	 * As memory initialization might be integrated into KASAN,
 	 * kasan_slab_alloc and initialization memset must be
@@ -746,7 +761,7 @@ static inline void slab_post_alloc_hook(struct kmem_cache *s,
 	for (i = 0; i < size; i++) {
 		p[i] = kasan_slab_alloc(s, p[i], flags, init);
 		if (p[i] && init && !kasan_has_integrated_init())
-			memset(p[i], 0, s->object_size);
+			memset(p[i], 0, zero_size);
 		kmemleak_alloc_recursive(p[i], s->object_size, 1,
 					 s->flags, flags);
 		kmsan_slab_alloc(s, p[i], flags);
diff --git a/mm/slub.c b/mm/slub.c
index 0a14e7bc278c..13490f317f5f 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -3387,7 +3387,11 @@ static __always_inline void *slab_alloc_node(struct kmem_cache *s, struct list_l
 	init = slab_want_init_on_alloc(gfpflags, s);
 
 out:
-	slab_post_alloc_hook(s, objcg, gfpflags, 1, &object, init);
+	/*
+	 * When init equals 'true', like for kzalloc() family, only
+	 * @orig_size bytes might be zeroed instead of s->object_size
+	 */
+	slab_post_alloc_hook(s, objcg, gfpflags, 1, &object, init, orig_size);
 
 	return object;
 }
@@ -3844,11 +3848,11 @@ int kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, size_t size,
 	 * Done outside of the IRQ disabled fastpath loop.
 	 */
 	slab_post_alloc_hook(s, objcg, flags, size, p,
-				slab_want_init_on_alloc(flags, s));
+			slab_want_init_on_alloc(flags, s), s->object_size);
 	return i;
 error:
 	slub_put_cpu_ptr(s->cpu_slab);
-	slab_post_alloc_hook(s, objcg, flags, i, p, false);
+	slab_post_alloc_hook(s, objcg, flags, i, p, false, s->object_size);
 	kmem_cache_free_bulk(s, i, p);
 	return 0;
 }
-- 
2.34.1