Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Nov 2022 13:01:27 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Richard Fitzgerald <rf@opensource.cirrus.com>
Cc:     Marc Zyngier <maz@kernel.org>, lee@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linus.walleij@linaro.org,
        tglx@linutronix.de, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH 09/12] irqchip: cirrus: Add driver for Cirrus Logic
 CS48L31/32/33 codecs
Message-ID: <Y2z2JwQaYS9N5A8x@sirena.org.uk>
References: <20221109165331.29332-1-rf@opensource.cirrus.com>
 <20221109165331.29332-10-rf@opensource.cirrus.com>
 <87mt8zutib.wl-maz@kernel.org>
 <c0c05799-6424-7edf-01b3-e28a10907b2c@opensource.cirrus.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="s9XagPH0CfsDB+cb"
Content-Disposition: inline
In-Reply-To: <c0c05799-6424-7edf-01b3-e28a10907b2c@opensource.cirrus.com>
Precedence: bulk


--s9XagPH0CfsDB+cb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Nov 10, 2022 at 11:22:26AM +0000, Richard Fitzgerald wrote:
> On 10/11/2022 08:02, Marc Zyngier wrote:

> > belongs IMO to the MFD code.

> We did once put interrupt support in MFD for an older product line but
> the MFD maintainer doesn't like the MFD being a dumping-ground for
> random other functionality that have their own subsystems.

There's bits of this like logging the top level error interrupts that
seem like they clearly fit in the driver for the top level chip (SYSCLK
possibly in the audio driver, dunno if it gets used by other functions),
they're users of the interrupt controller rather than part of the
interrupt controller.

> >  It is also a direct copy of the existing
> > irq-madera.c code, duplicated for no obvious reason.

> It's not a duplicate. The register map of this device is different
> (different addressing, 32-bit registers not 16-bit)

Isn't that just a data difference which could be parameterised?

--s9XagPH0CfsDB+cb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmNs9iYACgkQJNaLcl1U
h9C6/gf9GfHmYBwIwz3hP4w+omdX4OnqxZu0y5L3ZYq/q7x3gRz+YHxA83Z+7rrN
1PEYL9nJmSYS1niCtRDCT3EDLrcoD5AX7Ouv7wc6m7cze4zQaLH8h92foGwPZd5u
AMo6jxPBMTOhL5+8LQfOTSJFOBuQEMb3i8rPWG7Sx+YeIseD1xWvoevpBPWYjjwW
zqpPB+lfEF9o+gmnrbyAXOGWsTxYoa7PjCQkSwrvzrDj7GLzHvVhmDKI8wrp+tSt
ldgt7y1VZfMUinAsmYl2PtPy8tLkfxDfd/NvFxZydwtBNbxo+EAcam7aOSWx1Wkv
g6zdzussbdiTH3+QlsfyUy9gKCnnbQ==
=dwPr
-----END PGP SIGNATURE-----

--s9XagPH0CfsDB+cb--