Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6b282110-c9dc-c4ae-9003-1e75c3a0ff98@nvidia.com>
Date:   Thu, 10 Nov 2022 13:18:30 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] pwm: tegra: Fix 32 bit build
Content-Language: en-US
To:     Steven Price <steven.price@arm.com>,
        Thierry Reding <thierry.reding@gmail.com>
Cc:     =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
        linux-tegra@vger.kernel.org
References: <20221110114549.34121-1-steven.price@arm.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20221110114549.34121-1-steven.price@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVhXZUt6K0hrNFZCaWJJakRNTkpIdVpTVVJQdjZEWU9Mc3dyVHFnblVSQU9m?=
 =?utf-8?B?UFFtWHV1Ti81dDE5Qnc2WjhZQldmYzFsaExEcTF2S2hwL25kUHNTVXpaWTBw?=
 =?utf-8?B?R09YTmdrWVNsckNCTWRtYlFMTEVIZkJTQ21EUHhpTFZMSVUxV3ZjV1pQMGhT?=
 =?utf-8?B?aTJucDlqWnRjcjB3VjhqblUzNjdpbkZjR3RTUWMyeWRTTU1ZKzB2VTg2OFdX?=
 =?utf-8?B?dzgxV3NncjZiRy9na1BVWGZwRUVyU1ZFMHBVaHdVVlFIUW1kaVNJWGNacDUv?=
 =?utf-8?B?SVQyaytWNTlUbmVXdjZXdmdYRkEvUXNiNUtvL3VmUHkrbDVQNDJwQ0JuRkFw?=
 =?utf-8?B?NGpuSlRhdVpIaHU4UXRVYnRVWlhNa2F0bGpKajNpVjFBK0s1aENmWmJTVnl4?=
 =?utf-8?B?dXB2TzdqeWdadGNBUHpMdVpFRzczVE1UVWdENThnZ3ZpZEtCZGxqMnpVN2Nn?=
 =?utf-8?B?Y0hzOFNnb0VoYmYwNjNpZHJjS2dkS2dIMEZaNCt5RHFiTzc3bkZydFR2UFhG?=
 =?utf-8?B?N01ETXZ6dXo2ZGpOUUs1UEFxbE5ZYVhwOEE0ZnA1K0NzNWZzdkJ0WHpNa2VC?=
 =?utf-8?B?bEFMK2J3bitUSXhyNlFhZTZkSW5jRVdnbzJsZzkxRmIxRjdvbXdJQVFtSXc3?=
 =?utf-8?B?QkRoaHAwajlXa2tnWUNycENqMTQ4WXdtaEtWdlVBY1JrcmN2VHg3Tm8zdmtG?=
 =?utf-8?B?RFZxczdQczFYczQ1ZUpORjJNMUlXOGN2d2JmTHMvOFpmUjFZR2l0K29VK0ZF?=
 =?utf-8?B?Umo2TjBHR0g4K2pySmZiYlgvazJOdWpHMlIxVy80c0NmTUJjbWlveFpGUXor?=
 =?utf-8?B?dk9wcGxIeWpWaUp6ZTFDOVZ1Q29TOVUxekNVeVI5VXBHOHZiL2FFOHZiMVhu?=
 =?utf-8?B?eEtmQkNsZGRhcU9pR2xwSjY4SnZ5dTB2OTB0TGJGc1E1TjVnN2lRV2kzWFFh?=
 =?utf-8?B?SFkyYndXM0JMWVNpWDRVWkQvNHMzZkJCbDRnLzZvT2pHUlY2ZWxQSS9SdGV0?=
 =?utf-8?B?Q0VacENhYmdHb2d1MitSM3VHK21rcVUxcmwvY3BFdkptM0kyK3llckVUVFlZ?=
 =?utf-8?B?VDFGUXpWL3hkbXQvRnY3djBFMVhUVGdGN2dEYTl2OEZ0TmNEalZGeW5Tcklk?=
 =?utf-8?B?em9zMVFzTEtEN21WeXBUSTlCenVHRW92VjdmS3VSTlN1MzJKWGhNUU1MRi9G?=
 =?utf-8?B?T3d0Q2NHRUFzVXZpcy9hN0liTlJDck5NQ2dRdnI5b0NWb2xhbWlFaDU1Vzha?=
 =?utf-8?B?LzlQem9pc1U4ck8rUXFiRkoxWmRhTldaYzlxbWNWUE9jL3lvSytTMkxHQUhJ?=
 =?utf-8?B?YnF1S05VRno2MHNjVFppcjZldExUSkpRTjZRaER3WXU0YllRSlFuY29TYnY1?=
 =?utf-8?B?NWF0N29vRzN0cFdFWm1xTno3Y0pkeDEzWnZ0OWE4R1BQYmVFQ1JTYlJ0Yjc2?=
 =?utf-8?B?aG1PbDVzc2NqUVdvSlRHd2RVL01zSThFbGxGWlpRa05IVm5xVzZxWFZkYmRE?=
 =?utf-8?B?Y0Q3eUFidUwyVEdqdGRWNy9RUWhiV2QrUHlOSHdHYkV2QmQwbFVib3E1cU9T?=
 =?utf-8?B?RmNjY3l2S3QyTzdRa3Zld1BvcENteER2eC8vZkd4OUNoK1Fqa1NwYStDUTBj?=
 =?utf-8?B?SEFVOUdRaUJnbVRjbjg3NUQ0dmhRZHBHaGN1MWkvUGFzampOTHl4am5ONlVH?=
 =?utf-8?B?NFpTRkhDZUFLRE1ESWRsSHAzNmdJYTRkaWJyQjVEMFd1WGZuVHhkeEpWcXo0?=
 =?utf-8?B?RjlNSFZwYWtFZFNEclFMT01tY2J2ZG4vNjdBd3B2SElqYTZ1NndxNlR2RjY1?=
 =?utf-8?B?TU9mSzEra1FpdkxuRVNDMkNCVG14TW1qaHZCQkNNbitTd0tmR1ZuUDZFVFVu?=
 =?utf-8?B?cUtlaXhEVlRURDN2RkNBVHJIWFZRQ0Yxb0dHSE5ISzZHSWFpV0Fwd0l1anM3?=
 =?utf-8?B?Mm9KdjhsbHpHaVRrN0grdUU4a0Z4WlVlcEtsS1NiWlpHV0daRnhnY3d5UjRp?=
 =?utf-8?B?ZkJ3UG04VW5PSFVkQTRTNzNWNmVnQ2lDcVRodzFpSnN3Y3N2R3N6RU8zZEh4?=
 =?utf-8?B?Y0pIaEo1cEJHSzFVU05LTEIxeTI5NTRNNjNYMG1aUVFuSW9NQWM1QmhFNHY4?=
 =?utf-8?B?QmNQbHpKelg5bDZiUnpEeE1PcC9Mc3BRVU1qNXJLMnNoRVorUjByZ3ptdnNR?=
 =?utf-8?B?U1E9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62516a3c-ea71-47ab-b3ed-08dac31e1346
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 13:18:36.8369
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7MfdqDHpL7wx1K1w4ihh6wbppqWWKlgV78tANbi0/5JmMDocfnGGDJgjclpCHtXqPyTt0FLjfwgG932K0s6Wxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6828
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/11/2022 11:45, Steven Price wrote:
> The value of NSEC_PER_SEC << PWM_DUTY_WIDTH doesn't fix within a 32 bit
> integer causing a build warning/error (and the value truncated):
> 
>    drivers/pwm/pwm-tegra.c: In function ‘tegra_pwm_config’:
>    drivers/pwm/pwm-tegra.c:148:53: error: result of ‘1000000000 << 8’ requires 39 bits to represent, but ‘long int’ only has 32 bits [-Werror=shift-overflow=]
>      148 |   required_clk_rate = DIV_ROUND_UP_ULL(NSEC_PER_SEC << PWM_DUTY_WIDTH,
>          |                                                     ^~
> 
> Explicitly cast to a u64 to ensure the correct result.
> 
> Fixes: cfcb68817fb3 ("pwm: tegra: Improve required rate calculation")
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
>   drivers/pwm/pwm-tegra.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c
> index 6fc4b69a3ba7..249dc0193297 100644
> --- a/drivers/pwm/pwm-tegra.c
> +++ b/drivers/pwm/pwm-tegra.c
> @@ -145,7 +145,7 @@ static int tegra_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
>   		 * source clock rate as required_clk_rate, PWM controller will
>   		 * be able to configure the requested period.
>   		 */
> -		required_clk_rate = DIV_ROUND_UP_ULL(NSEC_PER_SEC << PWM_DUTY_WIDTH,
> +		required_clk_rate = DIV_ROUND_UP_ULL((u64)NSEC_PER_SEC << PWM_DUTY_WIDTH,
>   						     period_ns);
>   
>   		if (required_clk_rate > clk_round_rate(pc->clk, required_clk_rate))


Thanks!

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Jon

-- 
nvpublic