Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937948AbXHGWC3 (ORCPT ); Tue, 7 Aug 2007 18:02:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S966616AbXHGVhN (ORCPT ); Tue, 7 Aug 2007 17:37:13 -0400 Received: from sovereign.computergmbh.de ([85.214.69.204]:55800 "EHLO sovereign.computergmbh.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966596AbXHGVhI (ORCPT ); Tue, 7 Aug 2007 17:37:08 -0400 Date: Tue, 7 Aug 2007 23:37:06 +0200 (CEST) From: Jan Engelhardt To: Greg KH cc: linux-kernel@vger.kernel.org, stable@kernel.org, Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, bunk@stusta.de, Ingo Molnar , "David S. Miller" Subject: Re: [2.6.22.2 review 09/84] Fix rfkill IRQ flags. In-Reply-To: <20070807204308.GJ23028@kroah.com> Message-ID: References: <20070807204034.882009319@mini.kroah.org> <20070807204308.GJ23028@kroah.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 660 Lines: 25 On Aug 7 2007 13:43, Greg KH wrote: > >added this 64-bit bug: > > .... > unsigned int flags; > > spin_lock_irqsave(&task->lock, flags); > .... > >irq 'flags' must be unsigned long, not unsigned int. The -rt tree has >strict checks about this on 64-bit so this triggered a build failure. Since the check is a compile-time one, would not it be good to add it to the regular linux tree too? Jan -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/