Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp707332rwb; Thu, 10 Nov 2022 06:30:35 -0800 (PST) X-Google-Smtp-Source: AMsMyM5g+ySlLdI8SDrQSCMFa3B+eOuwEot4SSeZxsr5LiuzrBoq0M6hSM7KbbufUX2d2i8C7fie X-Received: by 2002:a50:ee82:0:b0:463:a83c:d762 with SMTP id f2-20020a50ee82000000b00463a83cd762mr2323312edr.44.1668090635667; Thu, 10 Nov 2022 06:30:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668090635; cv=none; d=google.com; s=arc-20160816; b=pfeF55I4YW9vzVElmV5GtYhd8ptJWMFGGUHiUJwWcwPHIDc35IZh878aEiGX/0n6TH mMWASn8/vBMM3auuMbd1cnpj5GyoZqlvIqebfZbug7HY30LBsWsxbnguPJlgZtNsCp2E kyXdjcjGKlN67CMwZ5lJWUfUhh1jloJM+JSV4oOqGLgmuQ1O82H0LwwcjKrEc43XwY5W w6Bu5cS83n5tVBQ4kWv4xuMnnJSISTqmlO8Q8ZE89JG1BaMNT/nfMNK45X/ZpgzVuh2D W18vRU27y00OjbOaPhKv337ZEyll1LjMaRaiNK5/ck1/xbIu8uXFoy2rck0pGjFX5jTr VZyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+2SL6ff+kWU3cRnOVLAgE4xFk13QlakKrQ2biA/MOFk=; b=uZMoimQQRg+LMZO+CIL/I6lt7Ir0SU+wJfvy1K+GbW3r9UHBa34cNb7pXqWrkbH68P xSbbvAdzYQ0LPeG1hBAKiXC1eUL2s5glZ0ez4bEegDFbxBYOWcAompz5/o9o6IgIxJvw p1xnNwf6z/GuqlFTZtFQZIc7HMg97he/1C1qEuKKTVdoP/eV5c/sv3G9rP7u/oHPHKj+ dZuDJEX5az0aoEGMIixv8LA8x6vk9Mw6VW4feQG2La86uNyBgeX8u9CnbFTnD7WlhuDU q/XkDUXPiPj4ciFCoFbEiLN0PjyrpKKd5F1Gle+RJ++71zqKWOqo2T6l/8SOGkHPp4f2 hLzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="EuIyH5/S"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m10-20020a056402510a00b00462ab8923ccsi17747349edd.600.2022.11.10.06.30.12; Thu, 10 Nov 2022 06:30:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="EuIyH5/S"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230491AbiKJNKQ (ORCPT + 92 others); Thu, 10 Nov 2022 08:10:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230413AbiKJNKF (ORCPT ); Thu, 10 Nov 2022 08:10:05 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB8E4742E4; Thu, 10 Nov 2022 05:09:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=+2SL6ff+kWU3cRnOVLAgE4xFk13QlakKrQ2biA/MOFk=; b=EuIyH5/SgPwinwGVfhlkSvXX9T QYIWVUUpFLMJ1/VLX/4LOg7QgEVH0mldjOJQcwR4OnqFEqrkwyX2iIwPWWJcJnXEloCeEswJy/wqI 9brl46KEwRradfMiK3oQ7E0leXkrMbmrUstoBFjcllp0JZUwlOrzTD7cCvRKHOGkWpYw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ot7Iv-002259-6L; Thu, 10 Nov 2022 14:09:13 +0100 Date: Thu, 10 Nov 2022 14:09:13 +0100 From: Andrew Lunn To: Michael Sit Wei Hong Cc: Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tan Tee Min , Lay Kuan Loon , Ong Boon Leong , Looi Hong Aun , Voon Weifeng , Zulkifli Muhammad Husaini , Gan Yi Fang Subject: Re: [PATCH net v2 RESEND 1/1] net: phy: dp83867: Fix SGMII FIFO depth for non OF devices Message-ID: References: <20221110054938.925347-1-michael.wei.hong.sit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221110054938.925347-1-michael.wei.hong.sit@intel.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2022 at 01:49:38PM +0800, Michael Sit Wei Hong wrote: > Current driver code will read device tree node information, > and set default values if there is no info provided. > > This is not done in non-OF devices leading to SGMII fifo depths being > set to the smallest size. > > This patch sets the value to the default value of the PHY as stated in the > PHY datasheet. > > Fixes: 4dc08dcc9f6f ("net: phy: dp83867: introduce critical chip default init for non-of platform") > Signed-off-by: Michael Sit Wei Hong https://www.spinics.net/lists/netdev/msg858366.html When sending a new version, please add any Acked-by, or Reviewed-by tags you have received. It helps get your patch merged if it can easily be seen is has been reviewed. Andrew