Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Nov 2022 15:28:38 +0100
Message-ID: <87bkpeq3xl.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Ye Bin <yebin@huaweicloud.com>
Cc:     perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        yebin10@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda: fix potential memleak in 'add_widget_node'
In-Reply-To: <20221110144539.2989354-1-yebin@huaweicloud.com>
References: <20221110144539.2989354-1-yebin@huaweicloud.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 10 Nov 2022 15:45:39 +0100,
Ye Bin wrote:
> 
> From: Ye Bin <yebin10@huawei.com>
> 
> As 'kobject_add' may allocated memory for 'kobject->name' when return error.
> And in this function, if call 'kobject_add' failed didn't free kobject.
> So call 'kobject_put' to recycling resources.
> 
> Signed-off-by: Ye Bin <yebin10@huawei.com>

Thanks, applied now.


Takashi